Skip to contentSkip to conversation

bind: fix build with openssl

PATCH New Baruch Siach 3 participants 5 messages Jul 18, 2018 – Jul 19, 2018

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 bind: fix build with openssl

The bind configure.in uses AC_TRY_RUN that is not compatible with cross compile. Disable eddsa unconditionally since it requires a newer OpenSSL version than we currently have. Enable aes; this is always supported in current OpenSSL versions.

Fixes:
http://autobuild.buildroot.net/results/3ed/3edb1659954b00401b68ffc7e1c8b3c29581c0e4/
http://autobuild.buildroot.net/results/025/025e377b51b39ba34647636ad0d0661a3cb95572/
http://autobuild.buildroot.net/results/725/7250564e780e43e793ae6c8c526985e5519681f4/

---
 package/bind/bind.mk | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
package/bind/bind.mk +3 -1
index c4429ef6cc7f..e71eddcd7f00 100644
@@ -61,7 +61,9 @@ BIND_CONF_ENV += \
 	ac_cv_func_EVP_sha512=yes
 BIND_CONF_OPTS += \
 	--with-openssl=$(STAGING_DIR)/usr LIBS="-lz" \
-	--with-ecdsa=yes
+	--with-ecdsa=yes \
+	--with-eddsa=no \
+	--with-aes=yes
 # GOST cipher support requires openssl extra engines
 ifeq ($(BR2_PACKAGE_OPENSSL_ENGINES),y)
 BIND_CONF_OPTS += --with-gost=yes
Signature · 1 line
2.18.0
#1 lore raw

PATCH 2/2 bind: fix build with zlib

The bind configure.in now checks for "${with_zlib}/include/zlib.h". Remove the redundant "include/".

---
 package/bind/bind.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/bind/bind.mk +1 -1
index e71eddcd7f00..d478a7f6e12c 100644
@@ -33,7 +33,7 @@ BIND_CONF_OPTS = \
 	--enable-filter-aaaa
 
 ifeq ($(BR2_PACKAGE_ZLIB),y)
-BIND_CONF_OPTS += --with-zlib=$(STAGING_DIR)/usr/include
+BIND_CONF_OPTS += --with-zlib=$(STAGING_DIR)/usr
 BIND_DEPENDENCIES += zlib
 else
 BIND_CONF_OPTS += --without-zlib
Signature · 1 line
2.18.0
#2 lore raw

PATCH 2/2 bind: fix build with zlib

Quoted 6 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Baruch" == Baruch Siach <[email protected]> writes:

The bind configure.in now checks for "${with_zlib}/include/zlib.h". Remove the redundant "include/".

Committed to 2018.02.x and 2018.05.x, thanks.

Signature · 1 line
Bye, Peter Korsgaard
#3 lore raw

PATCH 1/2 bind: fix build with openssl

In reply to Baruch Siach

Hello,

Quoted 10 lines · Baruch Siach

The bind configure.in uses AC_TRY_RUN that is not compatible with cross compile. Disable eddsa unconditionally since it requires a newer OpenSSL version than we currently have. Enable aes; this is always supported in current OpenSSL versions.

Fixes:
http://autobuild.buildroot.net/results/3ed/3edb1659954b00401b68ffc7e1c8b3c29581c0e4/
http://autobuild.buildroot.net/results/025/025e377b51b39ba34647636ad0d0661a3cb95572/
http://autobuild.buildroot.net/results/725/7250564e780e43e793ae6c8c526985e5519681f4/

Quoted 4 lines
---
 package/bind/bind.mk | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Both applied. Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
#4 lore raw

PATCH 1/2 bind: fix build with openssl

In reply to Baruch Siach
Quoted 7 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Baruch" == Baruch Siach <[email protected]> writes:

The bind configure.in uses AC_TRY_RUN that is not compatible with cross compile. Disable eddsa unconditionally since it requires a newer OpenSSL version than we currently have. Enable aes; this is always supported in current OpenSSL versions.

Quoted 6 lines

Fixes:
http://autobuild.buildroot.net/results/3ed/3edb1659954b00401b68ffc7e1c8b3c29581c0e4/
http://autobuild.buildroot.net/results/025/025e377b51b39ba34647636ad0d0661a3cb95572/
http://autobuild.buildroot.net/results/725/7250564e780e43e793ae6c8c526985e5519681f4/

Committed to 2018.02.x and 2018.05.x, thanks.

Signature · 1 line
Bye, Peter Korsgaard