drm/amd/display: Honor pplib stutter mask for all ASICs in DC
Subsystems (3)
PATCH 1/1 drm/amd/display: Honor pplib stutter mask for all ASICs in DC
[Why]
We were only setting this mask for DCN, but should really use it universally for all ASICs.
[How]
Move the assignment out of the Raven switch statement.
--- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +2 -4
@@ -1528,10 +1528,6 @@ static int amdgpu_dm_initialize_drm_device(struct amdgpu_device *adev)DRM_ERROR ("DM: Failed to initialize IRQ\n" ); goto fail; } -/* -* Temporary disable until pplib/smu interaction is implemented -*/ - dm->dc->debug.disable_stutter = amdgpu_pp_feature_mask &PP_STUTTER_MODE ? false : true;break ;#endif default :
@@ -1539,6 +1535,8 @@ static int amdgpu_dm_initialize_drm_device(struct amdgpu_device *adev) goto fail; } + dm->dc->debug.disable_stutter = amdgpu_pp_feature_mask &PP_STUTTER_MODE ? false : true; +return 0 ; fail:kfree (aencoder);
Signature · 6 lines
2.17.1 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
A message that is not in the archive (sent off-list or not yet received): 20180717145436.3805-1-harry.wentland-5C7GfCeVMHo@public.gmane.org
Alex Deucher
Reviewed-byQuoted 7 lines · Harry Wentland
[Why]
We were only setting this mask for DCN, but should really use it universally for all ASICs.[How]
Move the assignment out of the Raven switch statement.
Quoted 7 lines
I thought we had previously enabled stutter for CZ. Does that use a different path or was the code reworked in the interim?
Quoted 31 lines
--- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +2
-5@@ -1528,10 +1528,6 @@ static int amdgpu_dm_initialize_drm_device(struct amdgpu_device *adev)DRM_ERROR ("DM: Failed to initialize IRQ\n" ); goto fail; } -/* -* Temporary disable until pplib/smu interaction is implemented -*/ - dm->dc->debug.disable_stutter = amdgpu_pp_feature_mask &PP_STUTTER_MODE ? false : true;break ;#endif default :@@ -1539,6 +1535,8 @@ static int amdgpu_dm_initialize_drm_device(struct amdgpu_device *adev) goto fail; } + dm->dc->debug.disable_stutter = amdgpu_pp_feature_mask &PP_STUTTER_MODE ? false : true; +return 0 ; fail:kfree (aencoder); --2.17.1
Quoted 4 lines
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
PATCH v2 1/1 drm/amd/display: Honor pplib stutter mask for all ASICs in DC
In reply to a message not in the archive[Why]
We were only setting this mask for DCN, but should really use it universally for all ASICs.
[How]
Move the assignment out of the Raven switch statement for all ASICs other than Stoney and Carrizo.
v2: Keep stutter always on for Carrizo and Stoney (Alex)
--- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +3 -4
@@ -1528,10 +1528,6 @@ static int amdgpu_dm_initialize_drm_device(struct amdgpu_device *adev)DRM_ERROR ("DM: Failed to initialize IRQ\n" ); goto fail; } -/* -* Temporary disable until pplib/smu interaction is implemented -*/ - dm->dc->debug.disable_stutter = amdgpu_pp_feature_mask &PP_STUTTER_MODE ? false : true;break ;#endif default :
@@ -1539,6 +1535,9 @@ static int amdgpu_dm_initialize_drm_device(struct amdgpu_device *adev) goto fail; } +if (adev->asic_type !=CHIP_CARRIZO && adev->asic_type !=CHIP_STONEY ) + dm->dc->debug.disable_stutter = amdgpu_pp_feature_mask &PP_STUTTER_MODE ? false : true; +return 0 ; fail:kfree (aencoder);
Signature · 6 lines
2.17.1 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
A message that is not in the archive (sent off-list or not yet received): 20180719194909.31695-1-harry.wentland-5C7GfCeVMHo@public.gmane.org
Alex Deucher
Reviewed-byQuoted 10 lines · Harry Wentland
[Why]
We were only setting this mask for DCN, but should really use it universally for all ASICs.[How]
Move the assignment out of the Raven switch statement for all ASICs other than Stoney and Carrizo.v2: Keep stutter always on for Carrizo and Stoney (Alex)
Quoted 7 lines
Quoted 32 lines
--- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +3
-5@@ -1528,10 +1528,6 @@ static int amdgpu_dm_initialize_drm_device(struct amdgpu_device *adev)DRM_ERROR ("DM: Failed to initialize IRQ\n" ); goto fail; } -/* -* Temporary disable until pplib/smu interaction is implemented -*/ - dm->dc->debug.disable_stutter = amdgpu_pp_feature_mask &PP_STUTTER_MODE ? false : true;break ;#endif default :@@ -1539,6 +1535,9 @@ static int amdgpu_dm_initialize_drm_device(struct amdgpu_device *adev) goto fail; } +if (adev->asic_type !=CHIP_CARRIZO && adev->asic_type !=CHIP_STONEY ) + dm->dc->debug.disable_stutter = amdgpu_pp_feature_mask &PP_STUTTER_MODE ? false : true; +return 0 ; fail:kfree (aencoder); --2.17.1
Quoted 4 lines
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx