drm/amd/powerplay: slow UCLK switch when multiple displays not in sync
Subsystems (2)
PATCH 1/3 drm/amd/powerplay: slow UCLK switch when multiple displays not in sync
Slow switch for UCLK when there is multiple displays and they are not in sync.
--- drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c +2 -1
@@ -3780,7 +3780,8 @@ static int vega10_notify_smc_display_config_after_ps_adjustment(uint32_t i;struct pp_display_clock_request clock_req; -if (hwmgr->display_config->num_display >1 ) +if ((hwmgr->display_config->num_display >1 ) && + !hwmgr->display_config->multi_monitor_in_sync)vega10_notify_smc_display_change (hwmgr, false);else vega10_notify_smc_display_change (hwmgr, true);
Signature · 6 lines
2.18.0 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
A message that is not in the archive (sent off-list or not yet received): [email protected]
PATCH 2/3 drm/amd/powerplay: correct the argument for PPSMC_MSG_SetUclkFastSwitch
The argument was set wrongly. Fast/slow switch was asked when there is actually a slow/fast switch needed.
--- drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c | 2 +- drivers/gpu/drm/amd/powerplay/hwmgr/vega12_hwmgr.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c +1 -1
@@ -3705,7 +3705,7 @@ static void vega10_notify_smc_display_change(struct pp_hwmgr *hwmgr, {smum_send_msg_to_smc_with_parameter (hwmgr, PPSMC_MSG_SetUclkFastSwitch, - has_disp ?0 :1 ); + has_disp ?1 :0 ); } int vega10_display_clock_voltage_request(struct pp_hwmgr *hwmgr,
drivers/gpu/drm/amd/powerplay/hwmgr/vega12_hwmgr.c +1 -1
@@ -1334,7 +1334,7 @@ static int vega12_notify_smc_display_change(struct pp_hwmgr *hwmgr,if (data->smu_features[GNLD_DPM_UCLK ].enabled)return smum_send_msg_to_smc_with_parameter (hwmgr, PPSMC_MSG_SetUclkFastSwitch, - has_disp ?0 :1 ); + has_disp ?1 :0 );return 0 ; }
Signature · 6 lines
2.18.0 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
A message that is not in the archive (sent off-list or not yet received): [email protected]
RE: [PATCH 2/3] drm/amd/powerplay: correct the argument for PPSMC_MSG_SetUclkFastSwitch
Ping ..
Quoted 46 lines
-----Original Message-----
From: Evan Quan <[email protected]>
Sent: Friday, July 20, 2018 10:35 AM
To: [email protected]
Cc: Zhu, Rex <[email protected]>; Quan, Evan <[email protected]>
Subject: [PATCH 2/3] drm/amd/powerplay: correct the argument forPPSMC_MSG_SetUclkFastSwitchThe argument was set wrongly. Fast/slow switch was asked when there is actually a slow/fast switch needed.
Change-Id Ibcfdf741dea1700cc3796f84291606231e732f4bSigned-off-by Evan Quan <[email protected]>--- drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c | 2 +- drivers/gpu/drm/amd/powerplay/hwmgr/vega12_hwmgr.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c +1
-1@@ -3705,7 +3705,7 @@ static void vega10_notify_smc_display_change(struct pp_hwmgr *hwmgr, {smum_send_msg_to_smc_with_parameter (hwmgr, PPSMC_MSG_SetUclkFastSwitch, - has_disp ? 0 : 1); + has_disp ? 1 : 0); } int vega10_display_clock_voltage_request(struct pp_hwmgr *hwmgr, diff --git
a/drivers/gpu/drm/amd/powerplay/hwmgr/vega12_hwmgr.cb/drivers/gpu/drm/amd/powerplay/hwmgr/vega12_hwmgr.cindex4ed218dd8ba7..35f96dacb50a100644drivers/gpu/drm/amd/powerplay/hwmgr/vega12_hwmgr.c +1
-1@@ -1334,7 +1334,7 @@ static int vega12_notify_smc_display_change(struct pp_hwmgr *hwmgr, if (data->smu_features[GNLD_DPM_UCLK].enabled)return smum_send_msg_to_smc_with_parameter (hwmgr, PPSMC_MSG_SetUclkFastSwitch, - has_disp ?0 :1 ); + has_disp ?1 :0 );return 0 ;
Quoted 3 lines
}
--
2.18.0
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
A message that is not in the archive (sent off-list or not yet received): SN6PR12MB265616FADB384E7692A4D8CAE4560-kxOKjb6HO/FeL/[email protected]
Zhu, Rex
Reviewed-by Rex ZhuRe: [PATCH 2/3] drm/amd/powerplay: correct the argument for PPSMC_MSG_SetUclkFastSwitch
Series is:
Best Regards
Rex
________________________________
From: Quan, Evan
Sent: Monday, July 23, 2018 2:38 PM
To: Quan, Evan; [email protected]
Cc: Zhu, Rex
Subject: RE: [PATCH 2/3] drm/amd/powerplay: correct the argument for PPSMC_MSG_SetUclkFastSwitch
Ping ..
Quoted 46 lines
-----Original Message-----
From: Evan Quan <[email protected]>
Sent: Friday, July 20, 2018 10:35 AM
To: [email protected]
Cc: Zhu, Rex <[email protected]>; Quan, Evan <[email protected]>
Subject: [PATCH 2/3] drm/amd/powerplay: correct the argument forPPSMC_MSG_SetUclkFastSwitchThe argument was set wrongly. Fast/slow switch was asked when there is actually a slow/fast switch needed.
Change-Id Ibcfdf741dea1700cc3796f84291606231e732f4bSigned-off-by Evan Quan <[email protected]>--- drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c | 2 +- drivers/gpu/drm/amd/powerplay/hwmgr/vega12_hwmgr.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c +1
-1@@ -3705,7 +3705,7 @@ static void vega10_notify_smc_display_change(struct pp_hwmgr *hwmgr, {smum_send_msg_to_smc_with_parameter (hwmgr, PPSMC_MSG_SetUclkFastSwitch, - has_disp ? 0 : 1); + has_disp ? 1 : 0); } int vega10_display_clock_voltage_request(struct pp_hwmgr *hwmgr, diff --git
a/drivers/gpu/drm/amd/powerplay/hwmgr/vega12_hwmgr.cb/drivers/gpu/drm/amd/powerplay/hwmgr/vega12_hwmgr.cindex4ed218dd8ba7..35f96dacb50a100644drivers/gpu/drm/amd/powerplay/hwmgr/vega12_hwmgr.c +1
-1@@ -1334,7 +1334,7 @@ static int vega12_notify_smc_display_change(struct pp_hwmgr *hwmgr, if (data->smu_features[GNLD_DPM_UCLK].enabled)return smum_send_msg_to_smc_with_parameter (hwmgr, PPSMC_MSG_SetUclkFastSwitch, - has_disp ?0 :1 ); + has_disp ?1 :0 );return 0 ;
Quoted 3 lines
}
--
2.18.0
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
PATCH 3/3 drm/amd/powerplay: disallow slow switch if NBPState is disabled
In reply to a message not in the archiveOtherwise there may be potential SMU performance issues.
--- drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c | 5 ++++- drivers/gpu/drm/amd/powerplay/hwmgr/vega12_hwmgr.c | 5 ++++- 2 files changed, 8 insertions(+), 2 deletions(-)
drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c +4 -1
@@ -3779,9 +3779,12 @@ static int vega10_notify_smc_display_config_after_ps_adjustment(struct PP_Clocks min_clocks = {0 };uint32_t i;struct pp_display_clock_request clock_req; +bool uclk_switching_disabled = + (bool )hwmgr->display_config->nb_pstate_switch_disable;if ((hwmgr->display_config->num_display >1 ) && - !hwmgr->display_config->multi_monitor_in_sync) + !hwmgr->display_config->multi_monitor_in_sync && + !uclk_switching_disabled)vega10_notify_smc_display_change (hwmgr, false);else vega10_notify_smc_display_change (hwmgr, true);
drivers/gpu/drm/amd/powerplay/hwmgr/vega12_hwmgr.c +4 -1
@@ -1387,9 +1387,12 @@ static int vega12_notify_smc_display_config_after_ps_adjustment( (struct vega12_hwmgr *)(hwmgr->backend);struct PP_Clocks min_clocks = {0 };struct pp_display_clock_request clock_req; +bool uclk_switching_disabled = + (bool )hwmgr->display_config->nb_pstate_switch_disable;if ((hwmgr->display_config->num_display >1 ) && - !hwmgr->display_config->multi_monitor_in_sync) + !hwmgr->display_config->multi_monitor_in_sync && + !uclk_switching_disabled)vega12_notify_smc_display_change (hwmgr, false);else vega12_notify_smc_display_change (hwmgr, true);
Signature · 6 lines
2.18.0 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
A message that is not in the archive (sent off-list or not yet received): [email protected]
Re: [PATCH 3/3] drm/amd/powerplay: disallow slow switch if NBPState is disabled
+ bool uclk_switching_disabled =
+(bool)hwmgr->display_config->nb_pstate_switch_disable;
Don't need type convert.
Best Regards
Rex
________________________________
From: amd-gfx <amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org> on behalf of Evan Quan <[email protected]>
Sent: Friday, July 20, 2018 10:35 AM
To: [email protected]
Cc: Quan, Evan; Zhu, Rex
Subject: [PATCH 3/3] drm/amd/powerplay: disallow slow switch if NBPState is disabled
Otherwise there may be potential SMU performance issues.
--- drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c | 5 ++++- drivers/gpu/drm/amd/powerplay/hwmgr/vega12_hwmgr.c | 5 ++++- 2 files changed, 8 insertions(+), 2 deletions(-)
drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c +4 -1
@@ -3779,9 +3779,12 @@ static int vega10_notify_smc_display_config_after_ps_adjustment(struct PP_Clocks min_clocks = {0 };uint32_t i;struct pp_display_clock_request clock_req; +bool uclk_switching_disabled = + (bool )hwmgr->display_config->nb_pstate_switch_disable;if ((hwmgr->display_config->num_display >1 ) && - !hwmgr->display_config->multi_monitor_in_sync) + !hwmgr->display_config->multi_monitor_in_sync && + !uclk_switching_disabled)vega10_notify_smc_display_change (hwmgr, false);else vega10_notify_smc_display_change (hwmgr, true);
drivers/gpu/drm/amd/powerplay/hwmgr/vega12_hwmgr.c +4 -1
@@ -1387,9 +1387,12 @@ static int vega12_notify_smc_display_config_after_ps_adjustment( (struct vega12_hwmgr *)(hwmgr->backend);struct PP_Clocks min_clocks = {0 };struct pp_display_clock_request clock_req; +bool uclk_switching_disabled = + (bool )hwmgr->display_config->nb_pstate_switch_disable;if ((hwmgr->display_config->num_display >1 ) && - !hwmgr->display_config->multi_monitor_in_sync) + !hwmgr->display_config->multi_monitor_in_sync && + !uclk_switching_disabled)vega12_notify_smc_display_change (hwmgr, false);else vega12_notify_smc_display_change (hwmgr, true);
--
2.18.0
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
amd-gfx Info Page - freedesktop.org<https://lists.freedesktop.org/mailman/listinfo/amd-gfx>
lists.freedesktop.org
Subscribing to amd-gfx: Subscribe to amd-gfx by filling out the following form. Use of all freedesktop.org lists is subject to our Code of Conduct.
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
A message that is not in the archive (sent off-list or not yet received): CY4PR12MB168739D42A1638743A55AF34FB510-rpdhrqHFk06Y0SjTqZDccQdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org
Re: [PATCH 3/3] drm/amd/powerplay: disallow slow switch if NBPState is disabled
Hi Evan,
Changing the title to "Only allow slow switch if NB pstate switch is enabled" can make patch more
understandable.
Best Regards
Rex
________________________________
From: amd-gfx <amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org> on behalf of Zhu, Rex <[email protected]>
Sent: Friday, July 20, 2018 4:43 PM
To: Quan, Evan; [email protected]
Subject: Re: [PATCH 3/3] drm/amd/powerplay: disallow slow switch if NBPState is disabled
+ bool uclk_switching_disabled =
+(bool)hwmgr->display_config->nb_pstate_switch_disable;
Don't need type convert.
Best Regards
Rex
________________________________
From: amd-gfx <amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org> on behalf of Evan Quan <[email protected]>
Sent: Friday, July 20, 2018 10:35 AM
To: [email protected]
Cc: Quan, Evan; Zhu, Rex
Subject: [PATCH 3/3] drm/amd/powerplay: disallow slow switch if NBPState is disabled
Otherwise there may be potential SMU performance issues.
--- drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c | 5 ++++- drivers/gpu/drm/amd/powerplay/hwmgr/vega12_hwmgr.c | 5 ++++- 2 files changed, 8 insertions(+), 2 deletions(-)
drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c +4 -1
@@ -3779,9 +3779,12 @@ static int vega10_notify_smc_display_config_after_ps_adjustment(struct PP_Clocks min_clocks = {0 };uint32_t i;struct pp_display_clock_request clock_req; +bool uclk_switching_disabled = + (bool )hwmgr->display_config->nb_pstate_switch_disable;if ((hwmgr->display_config->num_display >1 ) && - !hwmgr->display_config->multi_monitor_in_sync) + !hwmgr->display_config->multi_monitor_in_sync && + !uclk_switching_disabled)vega10_notify_smc_display_change (hwmgr, false);else vega10_notify_smc_display_change (hwmgr, true);
drivers/gpu/drm/amd/powerplay/hwmgr/vega12_hwmgr.c +4 -1
@@ -1387,9 +1387,12 @@ static int vega12_notify_smc_display_config_after_ps_adjustment( (struct vega12_hwmgr *)(hwmgr->backend);struct PP_Clocks min_clocks = {0 };struct pp_display_clock_request clock_req; +bool uclk_switching_disabled = + (bool )hwmgr->display_config->nb_pstate_switch_disable;if ((hwmgr->display_config->num_display >1 ) && - !hwmgr->display_config->multi_monitor_in_sync) + !hwmgr->display_config->multi_monitor_in_sync && + !uclk_switching_disabled)vega12_notify_smc_display_change (hwmgr, false);else vega12_notify_smc_display_change (hwmgr, true);
--
2.18.0
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
amd-gfx Info Page - freedesktop.org<https://lists.freedesktop.org/mailman/listinfo/amd-gfx>
lists.freedesktop.org
Subscribing to amd-gfx: Subscribe to amd-gfx by filling out the following form. Use of all freedesktop.org lists is subject to our Code of Conduct.
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
A message that is not in the archive (sent off-list or not yet received): CY4PR12MB16876A0FBFDBF6FC8EA5C8C2FB510-rpdhrqHFk06Y0SjTqZDccQdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org
RE: [PATCH 3/3] drm/amd/powerplay: disallow slow switch if NBPState is disabled
Sent out the revised patch.
Regards,
Evan
From: Zhu, Rex
Sent: Friday, July 20, 2018 6:08 PM
To: Quan, Evan <[email protected]>; [email protected]
Subject: Re: [PATCH 3/3] drm/amd/powerplay: disallow slow switch if NBPState is disabled
Hi Evan,
Changing the title to "Only allow slow switch if NB pstate switch is enabled" can make patch more
understandable.
Best Regards
Rex
________________________________
From: amd-gfx <[email protected]<mailto:[email protected]>> on behalf of Zhu, Rex <[email protected]<mailto:[email protected]>>
Sent: Friday, July 20, 2018 4:43 PM
To: Quan, Evan; [email protected]<mailto:[email protected]>
Subject: Re: [PATCH 3/3] drm/amd/powerplay: disallow slow switch if NBPState is disabled
+ bool uclk_switching_disabled =
+(bool)hwmgr->display_config->nb_pstate_switch_disable;
Don't need type convert.
Best Regards
Rex
________________________________
From: amd-gfx <[email protected]<mailto:[email protected]>> on behalf of Evan Quan <[email protected]<mailto:[email protected]>>
Sent: Friday, July 20, 2018 10:35 AM
To: [email protected]<mailto:[email protected]>
Cc: Quan, Evan; Zhu, Rex
Subject: [PATCH 3/3] drm/amd/powerplay: disallow slow switch if NBPState is disabled
Otherwise there may be potential SMU performance issues.
--- drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c | 5 ++++- drivers/gpu/drm/amd/powerplay/hwmgr/vega12_hwmgr.c | 5 ++++- 2 files changed, 8 insertions(+), 2 deletions(-)
drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c +4 -1
@@ -3779,9 +3779,12 @@ static int vega10_notify_smc_display_config_after_ps_adjustment(struct PP_Clocks min_clocks = {0 };uint32_t i;struct pp_display_clock_request clock_req; +bool uclk_switching_disabled = + (bool )hwmgr->display_config->nb_pstate_switch_disable;if ((hwmgr->display_config->num_display >1 ) && - !hwmgr->display_config->multi_monitor_in_sync) + !hwmgr->display_config->multi_monitor_in_sync && + !uclk_switching_disabled)vega10_notify_smc_display_change (hwmgr, false);else vega10_notify_smc_display_change (hwmgr, true);
drivers/gpu/drm/amd/powerplay/hwmgr/vega12_hwmgr.c +4 -1
@@ -1387,9 +1387,12 @@ static int vega12_notify_smc_display_config_after_ps_adjustment( (struct vega12_hwmgr *)(hwmgr->backend);struct PP_Clocks min_clocks = {0 };struct pp_display_clock_request clock_req; +bool uclk_switching_disabled = + (bool )hwmgr->display_config->nb_pstate_switch_disable;if ((hwmgr->display_config->num_display >1 ) && - !hwmgr->display_config->multi_monitor_in_sync) + !hwmgr->display_config->multi_monitor_in_sync && + !uclk_switching_disabled)vega12_notify_smc_display_change (hwmgr, false);else vega12_notify_smc_display_change (hwmgr, true);
--
2.18.0
_______________________________________________
amd-gfx mailing list
[email protected]<mailto:[email protected]>
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
amd-gfx Info Page - freedesktop.org<https://lists.freedesktop.org/mailman/listinfo/amd-gfx>
lists.freedesktop.org
Subscribing to amd-gfx: Subscribe to amd-gfx by filling out the following form. Use of all freedesktop.org lists is subject to our Code of Conduct.
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Zhu, Rex
Reviewed-by Rex ZhuRegards
Rex
________________________________
From: amd-gfx <amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org> on behalf of Evan Quan <[email protected]>
Sent: Friday, July 20, 2018 10:35 AM
To: [email protected]
Cc: Quan, Evan; Zhu, Rex
Subject: [PATCH 1/3] drm/amd/powerplay: slow UCLK switch when multiple displays not in sync
Slow switch for UCLK when there is multiple displays and they are not in sync.
--- drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c +2 -1
@@ -3780,7 +3780,8 @@ static int vega10_notify_smc_display_config_after_ps_adjustment(uint32_t i;struct pp_display_clock_request clock_req; -if (hwmgr->display_config->num_display >1 ) +if ((hwmgr->display_config->num_display >1 ) && + !hwmgr->display_config->multi_monitor_in_sync)vega10_notify_smc_display_change (hwmgr, false);else vega10_notify_smc_display_change (hwmgr, true);
--
2.18.0
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
amd-gfx Info Page - freedesktop.org<https://lists.freedesktop.org/mailman/listinfo/amd-gfx>
lists.freedesktop.org
Subscribing to amd-gfx: Subscribe to amd-gfx by filling out the following form. Use of all freedesktop.org lists is subject to our Code of Conduct.
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx