Skip to contentSkip to conversation

imx-gpu-viv: add a missing backslash

PATCH New Laurent Hartanerot 3 participants 5 messages Jul 20, 2018 Arm i.MX and Layerscape

lore
Share & tools
lore

Laurent Hartanerot

author
#0 lore raw

PATCH 1/1 imx-gpu-viv: add a missing backslash

From: Laurent Hartanerot <[email protected]>

Signed-off-by Laurent Hartanerot <[email protected]>
---
 package/freescale-imx/imx-gpu-viv/imx-gpu-viv.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/freescale-imx/imx-gpu-viv/imx-gpu-viv.mk +1 -1
index 511e3b3b6c..25d25e1871 100644
@@ -79,7 +79,7 @@ endif
 ifeq ($(IMX_GPU_VIV_LIB_TARGET),x11)
 define IMX_GPU_VIV_FIXUP_PKGCONFIG
 	for lib in egl gbm glesv1_cm glesv2 vg; do \
-		ln -sf $${lib}_x11.pc $(@D)/gpu-core/usr/lib/pkgconfig/$${lib}.pc
+		ln -sf $${lib}_x11.pc $(@D)/gpu-core/usr/lib/pkgconfig/$${lib}.pc \
 	done
 endef
 endif
Signature · 1 line
2.11.0
#1 lore raw

PATCH 1/1 imx-gpu-viv: add a missing backslash

Quoted 13 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Laurent" == Laurent Hartanerot <[email protected]> writes:

From: Laurent Hartanerot <[email protected]>

Signed-off-by Laurent Hartanerot <[email protected]>
---
 package/freescale-imx/imx-gpu-viv/imx-gpu-viv.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/freescale-imx/imx-gpu-viv/imx-gpu-viv.mk +0 -0
index 511e3b3b6c..25d25e1871 100644

package/freescale-imx/imx-gpu-viv/imx-gpu-viv.mk endif · line 82

Quoted 5 lines
package/freescale-imx/imx-gpu-viv/imx-gpu-viv.mk +1 -1
@@ -79,7 +79,7 @@ endif
 ifeq ($(IMX_GPU_VIV_LIB_TARGET),x11)
 define IMX_GPU_VIV_FIXUP_PKGCONFIG
 	for lib in egl gbm glesv1_cm glesv2 vg; do \
-		ln -sf $${lib}_x11.pc $(@D)/gpu-core/usr/lib/pkgconfig/$${lib}.pc
+		ln -sf $${lib}_x11.pc $(@D)/gpu-core/usr/lib/pkgconfig/$${lib}.pc \

A semicolon is also missing. I've changed it to do '|| exit 1; \' like we do elsewhere to catch failures and committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard
#2 lore raw

PATCH 1/1 imx-gpu-viv: add a missing backslash

Hello,

Quoted 8 lines · Peter Korsgaard
Quoted 7 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Laurent" == Laurent Hartanerot <[email protected]> writes:

From: Laurent Hartanerot <[email protected]>

Signed-off-by Laurent Hartanerot <[email protected]>
---
 package/freescale-imx/imx-gpu-viv/imx-gpu-viv.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 13 lines

package/freescale-imx/imx-gpu-viv/imx-gpu-viv.mk endif · line 82

Quoted 10 lines
package/freescale-imx/imx-gpu-viv/imx-gpu-viv.mk +1 -1
index 511e3b3b6c..25d25e1871 100644
@@ -79,7 +79,7 @@ endif
 ifeq ($(IMX_GPU_VIV_LIB_TARGET),x11)
 define IMX_GPU_VIV_FIXUP_PKGCONFIG
 	for lib in egl gbm glesv1_cm glesv2 vg; do \
-		ln -sf $${lib}_x11.pc $(@D)/gpu-core/usr/lib/pkgconfig/$${lib}.pc
+		ln -sf $${lib}_x11.pc $(@D)/gpu-core/usr/lib/pkgconfig/$${lib}.pc \

A semicolon is also missing. I've changed it to do '|| exit 1; \' like we do elsewhere to catch failures and committed, thanks.

Actually, in this sort of case, I would prefer to use a make for loop:

	$(foreach lib,egl gbm glesv1_cm glesv2 vg, \
		ln -sf $(lib)_x11.pc $(@D)/gpu-core/usr/lib/pkgconfig/$(lib).pc
	)

make automatically aborts the loop if there's an error, and $(lib) is more readable than $${lib}.

Best regards,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
#3 lore raw

PATCH 1/1 imx-gpu-viv: add a missing backslash

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Thomas" == Thomas Petazzoni <[email protected]> writes:

Hi,

Quoted 11 lines
Quoted 2 lines

A semicolon is also missing. I've changed it to do '|| exit 1; \' like we do elsewhere to catch failures and committed, thanks.

Actually, in this sort of case, I would prefer to use a make for loop:

	$(foreach lib,egl gbm glesv1_cm glesv2 vg, \
		ln -sf $(lib)_x11.pc $(@D)/gpu-core/usr/lib/pkgconfig/$(lib).pc
	)

make automatically aborts the loop if there's an error, and $(lib) is more readable than $${lib}.

Correct. I left it like this as the file has several other shell loops.

Signature · 1 line
Bye, Peter Korsgaard