Skip to contentSkip to conversation

Staging: pi433: rf69: fixed a multi line comment issue

PATCH In review Mark Railton 2 participants 3 messages Jul 19, 2018 – Jul 21, 2018 Staging

lore
Share & tools
lore

Mark Railton

author
#0 lore raw

PATCH 1/1 Staging: pi433: rf69: fixed a multi line comment issue

Fixed a coding style issue

Signed-off-by Mark Railton <[email protected]>
---
 drivers/staging/pi433/rf69.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/staging/pi433/rf69.c +2 -1
index 90280e9b006d..14826fb505dd 100644
@@ -618,7 +618,8 @@ bool rf69_get_flag(struct spi_device *spi, enum flag flag)
 	case fifo_full:
 		return (rf69_read_reg(spi, REG_IRQFLAGS2) & MASK_IRQFLAGS2_FIFO_FULL);
 /*	case fifo_not_empty:
- *		return (rf69_read_reg(spi, REG_IRQFLAGS2) & MASK_IRQFLAGS2_FIFO_NOT_EMPTY); */
+ *		return (rf69_read_reg(spi, REG_IRQFLAGS2) & MASK_IRQFLAGS2_FIFO_NOT_EMPTY);
+ */
 	case fifo_empty:
 		return !(rf69_read_reg(spi, REG_IRQFLAGS2) & MASK_IRQFLAGS2_FIFO_NOT_EMPTY);
 	case fifo_level_below_threshold:
Signature · 1 line
2.17.1
maintainer
#1 lore raw
Quoted 12 lines · Mark Railton

Fixed a coding style issue

Signed-off-by Mark Railton <[email protected]>
---
 drivers/staging/pi433/rf69.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/staging/pi433/rf69.c +0 -0
index 90280e9b006d..14826fb505dd 100644

drivers/staging/pi433/rf69.c bool rf69_get_flag(struct spi_device *spi, enum flag flag) · line 622

Quoted 6 lines
drivers/staging/pi433/rf69.c +2 -1
@@ -618,7 +618,8 @@ bool rf69_get_flag(struct spi_device *spi, enum flag flag)
 	case fifo_full:
 		return (rf69_read_reg(spi, REG_IRQFLAGS2) & MASK_IRQFLAGS2_FIFO_FULL);
 /*	case fifo_not_empty:
- *		return (rf69_read_reg(spi, REG_IRQFLAGS2) & MASK_IRQFLAGS2_FIFO_NOT_EMPTY); */
+ *		return (rf69_read_reg(spi, REG_IRQFLAGS2) & MASK_IRQFLAGS2_FIFO_NOT_EMPTY);
+ */

Ick, just delete this whole thing if it isn't being used, don't make it prettier :)

thanks,

greg k-h

author
#2 lore raw
Quoted 23 lines · Greg KH
Quoted 12 lines · Mark Railton

Fixed a coding style issue

Signed-off-by Mark Railton <[email protected]>
---
 drivers/staging/pi433/rf69.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/staging/pi433/rf69.c +0 -0
index 90280e9b006d..14826fb505dd 100644

drivers/staging/pi433/rf69.c bool rf69_get_flag(struct spi_device *spi, enum flag flag) · line 622

Quoted 6 lines
drivers/staging/pi433/rf69.c +2 -1
@@ -618,7 +618,8 @@ bool rf69_get_flag(struct spi_device *spi, enum flag flag)
 	case fifo_full:
 		return (rf69_read_reg(spi, REG_IRQFLAGS2) & MASK_IRQFLAGS2_FIFO_FULL);
 /*	case fifo_not_empty:
- *		return (rf69_read_reg(spi, REG_IRQFLAGS2) & MASK_IRQFLAGS2_FIFO_NOT_EMPTY); */
+ *		return (rf69_read_reg(spi, REG_IRQFLAGS2) & MASK_IRQFLAGS2_FIFO_NOT_EMPTY);
+ */

Ick, just delete this whole thing if it isn't being used, don't make it prettier :)

Quoted 3 lines

thanks,

greg k-h

Apologies, should have realised that to begin with. Have sent a new patch with the correct change.

Thanks,

Mark