genhd: register_disk: inform about dev_set_name() failure

PATCH New Eugene Korenevsky 1 participant 1 message Jul 21, 2018 Block layer

lore

Share & tools

lore

Eugene Korenevsky

author

2018-07-21 22:28 UTC #0 lore raw

PATCH 1/1 genhd: register_disk: inform about dev_set_name() failure

Although dev_set_name() failure is not fatal, it is better to print a warning message into dmesg about it.

Signed-off-by Eugene Korenevsky <[email protected]>

---
 block/genhd.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

block/genhd.c +3 -1

index f1543a45e73b..071f8cbd529a 100644
@@ -577,7 +577,9 @@ static void register_disk(struct device *parent, struct gendisk *disk)
 
 	ddev->parent = parent;
 
-	dev_set_name(ddev, "%s", disk->disk_name);
+	err = dev_set_name(ddev, "%s", disk->disk_name);
+	if (err)
+		pr_warn("%s: cannot set disk name: %d", __func__, err);
 
 	/* delay uevents, until we scanned partition table */
 	dev_set_uevent_suppress(ddev, 1);

Signature · 1 line

2.18.0