staging: dgnc: dgnc_tty.c: Avoid '(' at the end of line

PATCH New Nishad Kamdar 1 participant 1 message Jul 22, 2018 Staging

Share & tools

Nishad Kamdar

author

2018-07-22 18:48 UTC #0 lore raw

PATCH v2 1/1 staging: dgnc: dgnc_tty.c: Avoid '(' at the end of line

Bring the first argument to the previous line, remove a superfluous () in the second argument by using !, and align the lines to match open parenthesis. Issue found by checkpatch.

Signed-off-by Nishad Kamdar <[email protected]>

---
Changes since v1:
- Remove a superfluous () and use ! instead, in the second argument.

---
 drivers/staging/dgnc/dgnc_tty.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

drivers/staging/dgnc/dgnc_tty.c +3 -4

index 9f9b9a5b4b27..f91eaa1c3b67 100644
@@ -883,10 +883,9 @@ static int dgnc_tty_open(struct tty_struct *tty, struct file *file)
 	 * touched safely, the close routine will signal the
 	 * ch_flags_wait to wake us back up.
 	 */
-	rc = wait_event_interruptible(
-				ch->ch_flags_wait,
-				(((ch->ch_tun.un_flags |
-				ch->ch_pun.un_flags) & UN_CLOSING) == 0));
+	rc = wait_event_interruptible(ch->ch_flags_wait,
+				      !((ch->ch_tun.un_flags |
+				      ch->ch_pun.un_flags) & UN_CLOSING));
 	/* If ret is non-zero, user ctrl-c'ed us */
 	if (rc)
 		return -EINTR;

Signature · 1 line

2.17.1