Makefile: help: BR2_DEFCONFIG for defconfig must be on command line
PATCH 1/1 Makefile: help: BR2_DEFCONFIG for defconfig must be on command line
The help text says that BR2_DEFCONFIG will be used as input, but a BR2_DEFCONFIG specified in the existing .config file will *not* be used. So say explicitly that it must be specified on the command line. Note that both "BR2_DEFCONFIG=... make defconfig" and
"make defconfig BR2_DEFCONFIG=..." will work.
While we're at it, add a semicolon to separate the two statements.
Note that this overflows the help text beyond 80 characters, but that is already the case in many other lines.
--- Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
Makefile +2 -2
@@ -1020,8 +1020,8 @@ help: @echo ' silentoldconfig - Same as oldconfig, but quietly, additionally update deps' @echo ' olddefconfig - Same as silentoldconfig but sets new symbols to their default value' @echo ' randconfig - New config with random answer to all options' - @echo ' defconfig - New config with default answer to all options' - @echo ' BR2_DEFCONFIG, if set, is used as input' + @echo ' defconfig - New config with default answer to all options;' + @echo ' BR2_DEFCONFIG, if set on the command line, is used as input' @echo ' savedefconfig - Save current config to BR2_DEFCONFIG (minimal config)' @echo ' allyesconfig - New config where all options are accepted with yes' @echo ' allnoconfig - New config where all options are answered with no'
Signature · 1 line
2.18.0
Thomas Petazzoni
AppliedPATCH 1/1 Makefile: help: BR2_DEFCONFIG for defconfig must be on command line
Hello,
Quoted 6 lines · Arnout Vandecappelle (Essensium/Mind)
The help text says that
BR2_DEFCONFIGwill be used as input, but aBR2_DEFCONFIGspecified in the existing .config file will *not* be used. So say explicitly that it must be specified on the command line. Note that both "BR2_DEFCONFIG=... make defconfig" and
"make defconfig BR2_DEFCONFIG=..." will work.
Quoted 6 lines
While we're at it, add a semicolon to separate the two statements.
Note that this overflows the help text beyond 80 characters, but that is already the case in many other lines.
Reported-by "aissen" on IRC
aissen is Anisse Astier, so I've fixed that up when applying.
Quoted 4 lines
--- Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
Applied to master, thanks.
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com
PATCH 1/1 Makefile: help: BR2_DEFCONFIG for defconfig must be on command line
In reply to Arnout Vandecappelle (Essensium/Mind)Quoted 8 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Arnout" == Arnout Vandecappelle (Essensium/Mind) <[email protected]> writes:
The help text says that
BR2_DEFCONFIGwill be used as input, but aBR2_DEFCONFIGspecified in the existing .config file will *not* be used. So say explicitly that it must be specified on the command line. Note that both "BR2_DEFCONFIG=... make defconfig" and
"make defconfig BR2_DEFCONFIG=..." will work.
Quoted 7 lines
While we're at it, add a semicolon to separate the two statements.
Note that this overflows the help text beyond 80 characters, but that is already the case in many other lines.
Reported-by "aissen" on IRC
Committed to 2018.02.x and 2018.05.x, thanks.
Signature · 1 line
Bye, Peter Korsgaard