Skip to contentSkip to conversation

drm/amd/powerplay: allow slow switch only if NBPState enabled v2

PATCH In review Evan Quan 2 participants 2 messages Jul 23, 2018 1 message not in the archive

Subsystems (2)
lore
Share & tools
lore

Evan Quan

author
#0 lore raw

PATCH 1/1 drm/amd/powerplay: allow slow switch only if NBPState enabled v2

Otherwise there may be potential SMU performance issues.

v2: fix commit description and coding style

Change-Id I05a09bb05407f7b3705d79a1d2c6628385c80461
---
 drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c | 3 ++-
 drivers/gpu/drm/amd/powerplay/hwmgr/vega12_hwmgr.c | 3 ++-
 2 files changed, 4 insertions(+), 2 deletions(-)
drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c +2 -1
index 002ed77a5268..a05de8e39d6a 100644
@@ -3781,7 +3781,8 @@ static int vega10_notify_smc_display_config_after_ps_adjustment(
 	struct pp_display_clock_request clock_req;
 
 	if ((hwmgr->display_config->num_display > 1) &&
-	     !hwmgr->display_config->multi_monitor_in_sync)
+	     !hwmgr->display_config->multi_monitor_in_sync &&
+	     !hwmgr->display_config->nb_pstate_switch_disable)
 		vega10_notify_smc_display_change(hwmgr, false);
 	else
 		vega10_notify_smc_display_change(hwmgr, true);
drivers/gpu/drm/amd/powerplay/hwmgr/vega12_hwmgr.c +2 -1
index 35f96dacb50a..0789d64246ca 100644
@@ -1389,7 +1389,8 @@ static int vega12_notify_smc_display_config_after_ps_adjustment(
 	struct pp_display_clock_request clock_req;
 
 	if ((hwmgr->display_config->num_display > 1) &&
-		!hwmgr->display_config->multi_monitor_in_sync)
+	     !hwmgr->display_config->multi_monitor_in_sync &&
+	     !hwmgr->display_config->nb_pstate_switch_disable)
 		vega12_notify_smc_display_change(hwmgr, false);
 	else
 		vega12_notify_smc_display_change(hwmgr, true);
Signature · 6 lines
2.18.0

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): [email protected]

#2 lore raw

________________________________
From: amd-gfx <amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org> on behalf of Evan Quan <[email protected]>
Sent: Monday, July 23, 2018 2:37:46 AM
To: [email protected]
Cc: Quan, Evan; Zhu, Rex
Subject: [PATCH] drm/amd/powerplay: allow slow switch only if NBPState enabled v2

Otherwise there may be potential SMU performance issues.

v2: fix commit description and coding style

Change-Id I05a09bb05407f7b3705d79a1d2c6628385c80461
---
 drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c | 3 ++-
 drivers/gpu/drm/amd/powerplay/hwmgr/vega12_hwmgr.c | 3 ++-
 2 files changed, 4 insertions(+), 2 deletions(-)
drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c +2 -1
index 002ed77a5268..a05de8e39d6a 100644
@@ -3781,7 +3781,8 @@ static int vega10_notify_smc_display_config_after_ps_adjustment(
         struct pp_display_clock_request clock_req;
 
         if ((hwmgr->display_config->num_display > 1) &&
-            !hwmgr->display_config->multi_monitor_in_sync)
+            !hwmgr->display_config->multi_monitor_in_sync &&
+            !hwmgr->display_config->nb_pstate_switch_disable)
                 vega10_notify_smc_display_change(hwmgr, false);
         else
                 vega10_notify_smc_display_change(hwmgr, true);
drivers/gpu/drm/amd/powerplay/hwmgr/vega12_hwmgr.c +2 -1
index 35f96dacb50a..0789d64246ca 100644
@@ -1389,7 +1389,8 @@ static int vega12_notify_smc_display_config_after_ps_adjustment(
         struct pp_display_clock_request clock_req;
 
         if ((hwmgr->display_config->num_display > 1) &&
-               !hwmgr->display_config->multi_monitor_in_sync)
+            !hwmgr->display_config->multi_monitor_in_sync &&
+            !hwmgr->display_config->nb_pstate_switch_disable)
                 vega12_notify_smc_display_change(hwmgr, false);
         else
                 vega12_notify_smc_display_change(hwmgr, true);

--
2.18.0

_______________________________________________
amd-gfx mailing list [email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx