Skip to contentSkip to conversation

iotests: remove LUKS support from test 226

PATCH Applied John Snow 2 participants 2 messages Jul 13, 2018 – Jul 23, 2018

lore
Share & tools
lore

John Snow

author
#0 lore raw

PATCH v2 1/1 iotests: remove LUKS support from test 226

This test doesn't actually care about the format anyway, it just supports "all formats" as a convenience. LUKS however does not use a simple image filename which confuses this iotest.

We can simply skip the test for formats that use IMGOPTSSYNTAX for their filenames without missing much coverage.

---
V2: Test against IMGOPTSSYNTAX instead of 'luks' directly (Kevin)

 tests/qemu-iotests/226 | 3 +++
 1 file changed, 3 insertions(+)
tests/qemu-iotests/226 +3 -0
index 460aea2fc9..34987d43f9 100755
@@ -41,6 +41,9 @@ trap "_cleanup; exit \$status" 0 1 2 3 15
 
 # Generic format, but tests file-protocol specific error handling
 _supported_fmt generic
+if [ "$IMGOPTSSYNTAX" = "true" ]; then
+    _unsupported_fmt $IMGFMT
+fi
 _supported_proto file
 _supported_os Linux
 
Signature · 1 line
2.14.4
Applied
#1 lore raw

Am 13.07.2018 um 19:37 hat John Snow geschrieben:

Quoted 8 lines

This test doesn't actually care about the format anyway, it just supports "all formats" as a convenience. LUKS however does not use a simple image filename which confuses this iotest.

We can simply skip the test for formats that use IMGOPTSSYNTAX for their filenames without missing much coverage.

Thanks, applied to the block branch.

Kevin