Drivers: Xen: xlate_mmu.c: Fixed comment layout
PATCH 1/1 Drivers: Xen: xlate_mmu.c: Fixed comment layout
Fixed issue with multi line comment
--- drivers/xen/xlate_mmu.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/xen/xlate_mmu.c +3 -2
@@ -151,8 +151,9 @@ int xen_xlate_remap_gfn_array(struct vm_area_struct *vma,struct remap_data data;unsigned long range =DIV_ROUND_UP (nr,XEN_PFN_PER_PAGE ) <<PAGE_SHIFT ; -/* Kept here for the purpose of making sure code doesn't break -x86 PVOPS */ +/* Kept here for the purpose of making sure code doesn't +* break x86 PVOPS +*/ BUG_ON (!((vma->vm_flags & (VM_PFNMAP |VM_IO )) == (VM_PFNMAP |VM_IO ))); data.fgfn = gfn;
Signature · 1 line
2.17.1
Quoted 1 line · Mark Railton
Fixed issue with multi line comment
Fix [not Fixed]
Quoted 11 lines
Signed-off-by Mark Railton <[email protected]>--- drivers/xen/xlate_mmu.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)drivers/xen/xlate_mmu.c +0
-0
drivers/xen/xlate_mmu.c int xen_xlate_remap_gfn_array(struct vm_area_struct *vma, · line 156
Quoted 8 lines
drivers/xen/xlate_mmu.c +3
-2@@ -151,8 +151,9 @@ int xen_xlate_remap_gfn_array(struct vm_area_struct *vma,struct remap_data data;unsigned long range =DIV_ROUND_UP (nr,XEN_PFN_PER_PAGE ) <<PAGE_SHIFT ; -/* Kept here for the purpose of making sure code doesn't break -x86 PVOPS */ +/* Kept here for the purpose of making sure code doesn't +* break x86 PVOPS +*/
That is still not the preferred kernel multi-line comment style. Documentation/process/coding-style.rst says:
/*
* This is the preferred style for multi-line
* comments in the Linux kernel source code.
* Please use it consistently.
*
* Description: A column of asterisks on the left side,
* with beginning and ending almost-blank lines. */
although Networking code has a slightly different preferred style (as in your patch).
Quoted 4 lines
drivers/xen/xlate_mmu.c +0
-0BUG_ON (!((vma->vm_flags & (VM_PFNMAP |VM_IO )) == (VM_PFNMAP |VM_IO ))); data.fgfn = gfn;
Signature · 6 lines
~Randy _______________________________________________ Xen-devel mailing list [email protected] https://lists.xenproject.org/mailman/listinfo/xen-devel
Quoted 1 line · Mark Railton
Fixed issue with multi line comment
Fix [not Fixed]
Quoted 11 lines
Signed-off-by Mark Railton <[email protected]>--- drivers/xen/xlate_mmu.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)drivers/xen/xlate_mmu.c +0
-0
drivers/xen/xlate_mmu.c int xen_xlate_remap_gfn_array(struct vm_area_struct *vma, · line 156
Quoted 8 lines
drivers/xen/xlate_mmu.c +3
-2@@ -151,8 +151,9 @@ int xen_xlate_remap_gfn_array(struct vm_area_struct *vma,struct remap_data data;unsigned long range =DIV_ROUND_UP (nr,XEN_PFN_PER_PAGE ) <<PAGE_SHIFT ; -/* Kept here for the purpose of making sure code doesn't break -x86 PVOPS */ +/* Kept here for the purpose of making sure code doesn't +* break x86 PVOPS +*/
That is still not the preferred kernel multi-line comment style. Documentation/process/coding-style.rst says:
/*
* This is the preferred style for multi-line
* comments in the Linux kernel source code.
* Please use it consistently.
*
* Description: A column of asterisks on the left side,
* with beginning and ending almost-blank lines. */
although Networking code has a slightly different preferred style (as in your patch).
Quoted 4 lines
drivers/xen/xlate_mmu.c +0
-0BUG_ON (!((vma->vm_flags & (VM_PFNMAP |VM_IO )) == (VM_PFNMAP |VM_IO ))); data.fgfn = gfn;
Signature · 1 line
~Randy
Quoted 37 lines · Randy Dunlap
Quoted 1 line · Mark Railton
Fixed issue with multi line comment
Fix [not Fixed]
Quoted 11 lines
Signed-off-by Mark Railton <[email protected]>--- drivers/xen/xlate_mmu.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)drivers/xen/xlate_mmu.c +0
-0drivers/xen/xlate_mmu.c int xen_xlate_remap_gfn_array(struct vm_area_struct *vma, · line 156
Quoted 8 lines
drivers/xen/xlate_mmu.c +3
-2@@ -151,8 +151,9 @@ int xen_xlate_remap_gfn_array(struct vm_area_struct *vma,struct remap_data data;unsigned long range =DIV_ROUND_UP (nr,XEN_PFN_PER_PAGE ) <<PAGE_SHIFT ; -/* Kept here for the purpose of making sure code doesn't break -x86 PVOPS */ +/* Kept here for the purpose of making sure code doesn't +* break x86 PVOPS +*/ That is still not the preferred kernel multi-line comment style.
Documentation/process/coding-style.rstsays:/*
* This is the preferred style for multi-line
* comments in the Linux kernel source code.
* Please use it consistently.
*
* Description: A column of asterisks on the left side,
* with beginning and ending almost-blank lines. */
Quoted 11 lines
although Networking code has a slightly different preferred style (as in your patch).
Quoted 4 lines
drivers/xen/xlate_mmu.c +0
-0BUG_ON (!((vma->vm_flags & (VM_PFNMAP |VM_IO )) == (VM_PFNMAP |VM_IO ))); data.fgfn = gfn;Signature · 1 line
~Randy
Thank's for the feedback, I'll get that updated now.
I'm still kinda new to this, I assume I need to send the new patch via git send-email?
Thanks,
Mark
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
Quoted 37 lines · Randy Dunlap
Quoted 1 line · Mark Railton
Fixed issue with multi line comment
Fix [not Fixed]
Quoted 11 lines
Signed-off-by Mark Railton <[email protected]>--- drivers/xen/xlate_mmu.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)drivers/xen/xlate_mmu.c +0
-0drivers/xen/xlate_mmu.c int xen_xlate_remap_gfn_array(struct vm_area_struct *vma, · line 156
Quoted 8 lines
drivers/xen/xlate_mmu.c +3
-2@@ -151,8 +151,9 @@ int xen_xlate_remap_gfn_array(struct vm_area_struct *vma,struct remap_data data;unsigned long range =DIV_ROUND_UP (nr,XEN_PFN_PER_PAGE ) <<PAGE_SHIFT ; -/* Kept here for the purpose of making sure code doesn't break -x86 PVOPS */ +/* Kept here for the purpose of making sure code doesn't +* break x86 PVOPS +*/ That is still not the preferred kernel multi-line comment style.
Documentation/process/coding-style.rstsays:/*
* This is the preferred style for multi-line
* comments in the Linux kernel source code.
* Please use it consistently.
*
* Description: A column of asterisks on the left side,
* with beginning and ending almost-blank lines. */
Quoted 11 lines
although Networking code has a slightly different preferred style (as in your patch).
Quoted 4 lines
drivers/xen/xlate_mmu.c +0
-0BUG_ON (!((vma->vm_flags & (VM_PFNMAP |VM_IO )) == (VM_PFNMAP |VM_IO ))); data.fgfn = gfn;Signature · 1 line
~Randy
Thank's for the feedback, I'll get that updated now.
I'm still kinda new to this, I assume I need to send the new patch via git send-email?
Thanks,
Mark
Quoted 47 lines · Mark Railton
Quoted 46 lines · Randy Dunlap
Quoted 1 line · Mark Railton
Fixed issue with multi line comment
Fix [not Fixed]
Quoted 11 lines
Signed-off-by Mark Railton <[email protected]>--- drivers/xen/xlate_mmu.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)drivers/xen/xlate_mmu.c +0
-0drivers/xen/xlate_mmu.c int xen_xlate_remap_gfn_array(struct vm_area_struct *vma, · line 156
Quoted 8 lines
drivers/xen/xlate_mmu.c +3
-2@@ -151,8 +151,9 @@ int xen_xlate_remap_gfn_array(struct vm_area_struct *vma,struct remap_data data;unsigned long range =DIV_ROUND_UP (nr,XEN_PFN_PER_PAGE ) <<PAGE_SHIFT ; -/* Kept here for the purpose of making sure code doesn't break -x86 PVOPS */ +/* Kept here for the purpose of making sure code doesn't +* break x86 PVOPS +*/ That is still not the preferred kernel multi-line comment style.
Documentation/process/coding-style.rstsays:/*
* This is the preferred style for multi-line
* comments in the Linux kernel source code.
* Please use it consistently.
*
* Description: A column of asterisks on the left side,
* with beginning and ending almost-blank lines. */although Networking code has a slightly different preferred style (as in your patch).
Quoted 4 lines
drivers/xen/xlate_mmu.c +0
-0BUG_ON (!((vma->vm_flags & (VM_PFNMAP |VM_IO )) == (VM_PFNMAP |VM_IO ))); data.fgfn = gfn;
Quoted 7 lines
Quoted 2 lines
Signature · 1 line
~RandyThank's for the feedback, I'll get that updated now.
I'm still kinda new to this, I assume I need to send the new patch via git send-email?
That is one option. Use whatever works for you.
There are several email clients that also work well. See Documentation/process/email-clients.rst.
Signature · 6 lines
~Randy _______________________________________________ Xen-devel mailing list [email protected] https://lists.xenproject.org/mailman/listinfo/xen-devel
Quoted 47 lines · Mark Railton
Quoted 46 lines · Randy Dunlap
Quoted 1 line · Mark Railton
Fixed issue with multi line comment
Fix [not Fixed]
Quoted 11 lines
Signed-off-by Mark Railton <[email protected]>--- drivers/xen/xlate_mmu.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)drivers/xen/xlate_mmu.c +0
-0drivers/xen/xlate_mmu.c int xen_xlate_remap_gfn_array(struct vm_area_struct *vma, · line 156
Quoted 8 lines
drivers/xen/xlate_mmu.c +3
-2@@ -151,8 +151,9 @@ int xen_xlate_remap_gfn_array(struct vm_area_struct *vma,struct remap_data data;unsigned long range =DIV_ROUND_UP (nr,XEN_PFN_PER_PAGE ) <<PAGE_SHIFT ; -/* Kept here for the purpose of making sure code doesn't break -x86 PVOPS */ +/* Kept here for the purpose of making sure code doesn't +* break x86 PVOPS +*/ That is still not the preferred kernel multi-line comment style.
Documentation/process/coding-style.rstsays:/*
* This is the preferred style for multi-line
* comments in the Linux kernel source code.
* Please use it consistently.
*
* Description: A column of asterisks on the left side,
* with beginning and ending almost-blank lines. */although Networking code has a slightly different preferred style (as in your patch).
Quoted 4 lines
drivers/xen/xlate_mmu.c +0
-0BUG_ON (!((vma->vm_flags & (VM_PFNMAP |VM_IO )) == (VM_PFNMAP |VM_IO ))); data.fgfn = gfn;
Quoted 7 lines
Quoted 2 lines
Signature · 1 line
~RandyThank's for the feedback, I'll get that updated now.
I'm still kinda new to this, I assume I need to send the new patch via git send-email?
That is one option. Use whatever works for you.
There are several email clients that also work well. See Documentation/process/email-clients.rst.
Signature · 1 line
~Randy
Quoted 53 lines · Randy Dunlap
Quoted 52 lines · Mark Railton
Quoted 37 lines · Randy Dunlap
Quoted 1 line · Mark Railton
Fixed issue with multi line comment
Fix [not Fixed]
Quoted 11 lines
Signed-off-by Mark Railton <[email protected]>--- drivers/xen/xlate_mmu.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)drivers/xen/xlate_mmu.c +0
-0drivers/xen/xlate_mmu.c int xen_xlate_remap_gfn_array(struct vm_area_struct *vma, · line 156
Quoted 8 lines
drivers/xen/xlate_mmu.c +3
-2@@ -151,8 +151,9 @@ int xen_xlate_remap_gfn_array(struct vm_area_struct *vma,struct remap_data data;unsigned long range =DIV_ROUND_UP (nr,XEN_PFN_PER_PAGE ) <<PAGE_SHIFT ; -/* Kept here for the purpose of making sure code doesn't break -x86 PVOPS */ +/* Kept here for the purpose of making sure code doesn't +* break x86 PVOPS +*/ That is still not the preferred kernel multi-line comment style.
Documentation/process/coding-style.rstsays:/*
* This is the preferred style for multi-line
* comments in the Linux kernel source code.
* Please use it consistently.
*
* Description: A column of asterisks on the left side,
* with beginning and ending almost-blank lines. */Quoted 11 lines
although Networking code has a slightly different preferred style (as in your patch).
Quoted 4 lines
drivers/xen/xlate_mmu.c +0
-0BUG_ON (!((vma->vm_flags & (VM_PFNMAP |VM_IO )) == (VM_PFNMAP |VM_IO ))); data.fgfn = gfn;Signature · 1 line
~RandyThank's for the feedback, I'll get that updated now.
Quoted 11 lines
Quoted 2 lines
I'm still kinda new to this, I assume I need to send the new patch via git send-email?
That is one option. Use whatever works for you.
There are several email clients that also work well. See
Documentation/process/email-clients.rst.Signature · 1 line
~Randy
From 57c8104d2a30020005be16df2ca69ed66f6c4ae9 Mon Sep 17 00:00:00 2001
From: Mark Railton <[email protected]>
Date: Mon, 23 Jul 2018 22:28:53 +0100
Subject: [PATCH] Drivers: Xen: xlate_mmu.c: Fixed comment layout
Fixed issue with multi line comment
--- drivers/xen/xlate_mmu.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
drivers/xen/xlate_mmu.c +4 -2
@@ -151,8 +151,10 @@ int xen_xlate_remap_gfn_array(struct vm_area_struct *vma,struct remap_data data;unsigned long range =DIV_ROUND_UP (nr,XEN_PFN_PER_PAGE ) <<PAGE_SHIFT ; -/* Kept here for the purpose of making sure code doesn't break -x86 PVOPS */ +/* +* Kept here for the purpose of making sure code doesn't +* break x86 PVOPS +*/ BUG_ON (!((vma->vm_flags & (VM_PFNMAP |VM_IO )) == (VM_PFNMAP |VM_IO ))); data.fgfn = gfn;
--
2.17.1
Randy Dunlap
Acked-byQuoted 96 lines · Mark Railton
Quoted 53 lines · Randy Dunlap
Quoted 52 lines · Mark Railton
Quoted 37 lines · Randy Dunlap
Quoted 1 line · Mark Railton
Fixed issue with multi line comment
Fix [not Fixed]
Quoted 11 lines
Signed-off-by Mark Railton <[email protected]>--- drivers/xen/xlate_mmu.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)drivers/xen/xlate_mmu.c +0
-0drivers/xen/xlate_mmu.c int xen_xlate_remap_gfn_array(struct vm_area_struct *vma, · line 156
Quoted 8 lines
drivers/xen/xlate_mmu.c +3
-2@@ -151,8 +151,9 @@ int xen_xlate_remap_gfn_array(struct vm_area_struct *vma,struct remap_data data;unsigned long range =DIV_ROUND_UP (nr,XEN_PFN_PER_PAGE ) <<PAGE_SHIFT ; -/* Kept here for the purpose of making sure code doesn't break -x86 PVOPS */ +/* Kept here for the purpose of making sure code doesn't +* break x86 PVOPS +*/ That is still not the preferred kernel multi-line comment style.
Documentation/process/coding-style.rstsays:/*
* This is the preferred style for multi-line
* comments in the Linux kernel source code.
* Please use it consistently.
*
* Description: A column of asterisks on the left side,
* with beginning and ending almost-blank lines. */Quoted 11 lines
although Networking code has a slightly different preferred style (as in your patch).
Quoted 4 lines
drivers/xen/xlate_mmu.c +0
-0BUG_ON (!((vma->vm_flags & (VM_PFNMAP |VM_IO )) == (VM_PFNMAP |VM_IO ))); data.fgfn = gfn;Signature · 1 line
~RandyThank's for the feedback, I'll get that updated now.
Quoted 11 lines
Quoted 2 lines
I'm still kinda new to this, I assume I need to send the new patch via git send-email?
That is one option. Use whatever works for you.
There are several email clients that also work well. See
Documentation/process/email-clients.rst.Signature · 1 line
~RandyFrom
57c8104d2a30020005be16df2ca69ed66f6c4ae9Mon Sep 17 00:00:00 2001
From: Mark Railton <[email protected]>
Date: Mon, 23 Jul 2018 22:28:53 +0100
Subject: [PATCH] Drivers: Xen:xlate_mmu.c: Fixed comment layoutFixed issue with multi line comment
Signed-off-by Mark Railton <[email protected]>--- drivers/xen/xlate_mmu.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)drivers/xen/xlate_mmu.c +4
-3@@ -151,8 +151,10 @@ int xen_xlate_remap_gfn_array(struct vm_area_struct *vma,struct remap_data data;unsigned long range =DIV_ROUND_UP (nr,XEN_PFN_PER_PAGE ) <<PAGE_SHIFT ; -/* Kept here for the purpose of making sure code doesn't break -x86 PVOPS */ +/* +* Kept here for the purpose of making sure code doesn't +* break x86 PVOPS +*/ BUG_ON (!((vma->vm_flags & (VM_PFNMAP |VM_IO )) == (VM_PFNMAP |VM_IO ))); data.fgfn = gfn; --
Quoted 1 line
2.17.1
Hi,
a. The subject and the patch description should be in present tense, i.e., Fix instead of Fixed.
b. Ideally you start a new email thread for new versions of a patch (but Cc:
the interested parties).
For the patch itself:
Thanks.
Signature · 6 lines
~Randy _______________________________________________ Xen-devel mailing list [email protected] https://lists.xenproject.org/mailman/listinfo/xen-devel
Randy Dunlap
Acked-byQuoted 96 lines · Mark Railton
Quoted 53 lines · Randy Dunlap
Quoted 52 lines · Mark Railton
Quoted 37 lines · Randy Dunlap
Quoted 1 line · Mark Railton
Fixed issue with multi line comment
Fix [not Fixed]
Quoted 11 lines
Signed-off-by Mark Railton <[email protected]>--- drivers/xen/xlate_mmu.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)drivers/xen/xlate_mmu.c +0
-0drivers/xen/xlate_mmu.c int xen_xlate_remap_gfn_array(struct vm_area_struct *vma, · line 156
Quoted 8 lines
drivers/xen/xlate_mmu.c +3
-2@@ -151,8 +151,9 @@ int xen_xlate_remap_gfn_array(struct vm_area_struct *vma,struct remap_data data;unsigned long range =DIV_ROUND_UP (nr,XEN_PFN_PER_PAGE ) <<PAGE_SHIFT ; -/* Kept here for the purpose of making sure code doesn't break -x86 PVOPS */ +/* Kept here for the purpose of making sure code doesn't +* break x86 PVOPS +*/ That is still not the preferred kernel multi-line comment style.
Documentation/process/coding-style.rstsays:/*
* This is the preferred style for multi-line
* comments in the Linux kernel source code.
* Please use it consistently.
*
* Description: A column of asterisks on the left side,
* with beginning and ending almost-blank lines. */Quoted 11 lines
although Networking code has a slightly different preferred style (as in your patch).
Quoted 4 lines
drivers/xen/xlate_mmu.c +0
-0BUG_ON (!((vma->vm_flags & (VM_PFNMAP |VM_IO )) == (VM_PFNMAP |VM_IO ))); data.fgfn = gfn;Signature · 1 line
~RandyThank's for the feedback, I'll get that updated now.
Quoted 11 lines
Quoted 2 lines
I'm still kinda new to this, I assume I need to send the new patch via git send-email?
That is one option. Use whatever works for you.
There are several email clients that also work well. See
Documentation/process/email-clients.rst.Signature · 1 line
~RandyFrom
57c8104d2a30020005be16df2ca69ed66f6c4ae9Mon Sep 17 00:00:00 2001
From: Mark Railton <[email protected]>
Date: Mon, 23 Jul 2018 22:28:53 +0100
Subject: [PATCH] Drivers: Xen:xlate_mmu.c: Fixed comment layoutFixed issue with multi line comment
Signed-off-by Mark Railton <[email protected]>--- drivers/xen/xlate_mmu.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)drivers/xen/xlate_mmu.c +4
-3@@ -151,8 +151,10 @@ int xen_xlate_remap_gfn_array(struct vm_area_struct *vma,struct remap_data data;unsigned long range =DIV_ROUND_UP (nr,XEN_PFN_PER_PAGE ) <<PAGE_SHIFT ; -/* Kept here for the purpose of making sure code doesn't break -x86 PVOPS */ +/* +* Kept here for the purpose of making sure code doesn't +* break x86 PVOPS +*/ BUG_ON (!((vma->vm_flags & (VM_PFNMAP |VM_IO )) == (VM_PFNMAP |VM_IO ))); data.fgfn = gfn; --
Quoted 1 line
2.17.1
Hi,
a. The subject and the patch description should be in present tense, i.e., Fix instead of Fixed.
b. Ideally you start a new email thread for new versions of a patch (but Cc:
the interested parties).
For the patch itself:
Thanks.
Signature · 1 line
~Randy
Quoted 105 lines · Randy Dunlap
Quoted 96 lines · Mark Railton
Quoted 53 lines · Randy Dunlap
Quoted 52 lines · Mark Railton
Quoted 37 lines · Randy Dunlap
Quoted 1 line · Mark Railton
Fixed issue with multi line comment
Fix [not Fixed]
Quoted 11 lines
Signed-off-by Mark Railton <[email protected]>--- drivers/xen/xlate_mmu.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)drivers/xen/xlate_mmu.c +0
-0drivers/xen/xlate_mmu.c int xen_xlate_remap_gfn_array(struct vm_area_struct *vma, · line 156
Quoted 8 lines
drivers/xen/xlate_mmu.c +3
-2@@ -151,8 +151,9 @@ int xen_xlate_remap_gfn_array(struct vm_area_struct *vma,struct remap_data data;unsigned long range =DIV_ROUND_UP (nr,XEN_PFN_PER_PAGE ) <<PAGE_SHIFT ; -/* Kept here for the purpose of making sure code doesn't break -x86 PVOPS */ +/* Kept here for the purpose of making sure code doesn't +* break x86 PVOPS +*/ That is still not the preferred kernel multi-line comment style.
Documentation/process/coding-style.rstsays:/*
* This is the preferred style for multi-line
* comments in the Linux kernel source code.
* Please use it consistently.
*
* Description: A column of asterisks on the left side,
* with beginning and ending almost-blank lines. */Quoted 11 lines
although Networking code has a slightly different preferred style (as in your patch).
Quoted 4 lines
drivers/xen/xlate_mmu.c +0
-0BUG_ON (!((vma->vm_flags & (VM_PFNMAP |VM_IO )) == (VM_PFNMAP |VM_IO ))); data.fgfn = gfn;Signature · 1 line
~RandyThank's for the feedback, I'll get that updated now.
Quoted 11 lines
Quoted 2 lines
I'm still kinda new to this, I assume I need to send the new patch via git send-email?
That is one option. Use whatever works for you.
There are several email clients that also work well. See
Documentation/process/email-clients.rst.Signature · 1 line
~RandyFrom
57c8104d2a30020005be16df2ca69ed66f6c4ae9Mon Sep 17 00:00:00 2001
From: Mark Railton <[email protected]>
Date: Mon, 23 Jul 2018 22:28:53 +0100
Subject: [PATCH] Drivers: Xen:xlate_mmu.c: Fixed comment layoutFixed issue with multi line comment
Signed-off-by Mark Railton <[email protected]>--- drivers/xen/xlate_mmu.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)drivers/xen/xlate_mmu.c +4
-3@@ -151,8 +151,10 @@ int xen_xlate_remap_gfn_array(struct vm_area_struct *vma,struct remap_data data;unsigned long range =DIV_ROUND_UP (nr,XEN_PFN_PER_PAGE ) <<PAGE_SHIFT ; -/* Kept here for the purpose of making sure code doesn't break -x86 PVOPS */ +/* +* Kept here for the purpose of making sure code doesn't +* break x86 PVOPS +*/ BUG_ON (!((vma->vm_flags & (VM_PFNMAP |VM_IO )) == (VM_PFNMAP |VM_IO ))); data.fgfn = gfn; --Quoted 1 line
2.17.1
Hi,
a. The subject and the patch description should be in present tense, i.e., Fix instead of Fixed.
Quoted 10 lines
b. Ideally you start a new email thread for new versions of a patch (but Cc:
the interested parties).For the patch itself:
Acked-by Randy Dunlap <[email protected]>Thanks.
Signature · 1 line
~Randy
Thank you for the feedback, I will make sure to take that on board.
Mark
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
Quoted 105 lines · Randy Dunlap
Quoted 96 lines · Mark Railton
Quoted 53 lines · Randy Dunlap
Quoted 52 lines · Mark Railton
Quoted 37 lines · Randy Dunlap
Quoted 1 line · Mark Railton
Fixed issue with multi line comment
Fix [not Fixed]
Quoted 11 lines
Signed-off-by Mark Railton <[email protected]>--- drivers/xen/xlate_mmu.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)drivers/xen/xlate_mmu.c +0
-0drivers/xen/xlate_mmu.c int xen_xlate_remap_gfn_array(struct vm_area_struct *vma, · line 156
Quoted 8 lines
drivers/xen/xlate_mmu.c +3
-2@@ -151,8 +151,9 @@ int xen_xlate_remap_gfn_array(struct vm_area_struct *vma,struct remap_data data;unsigned long range =DIV_ROUND_UP (nr,XEN_PFN_PER_PAGE ) <<PAGE_SHIFT ; -/* Kept here for the purpose of making sure code doesn't break -x86 PVOPS */ +/* Kept here for the purpose of making sure code doesn't +* break x86 PVOPS +*/ That is still not the preferred kernel multi-line comment style.
Documentation/process/coding-style.rstsays:/*
* This is the preferred style for multi-line
* comments in the Linux kernel source code.
* Please use it consistently.
*
* Description: A column of asterisks on the left side,
* with beginning and ending almost-blank lines. */Quoted 11 lines
although Networking code has a slightly different preferred style (as in your patch).
Quoted 4 lines
drivers/xen/xlate_mmu.c +0
-0BUG_ON (!((vma->vm_flags & (VM_PFNMAP |VM_IO )) == (VM_PFNMAP |VM_IO ))); data.fgfn = gfn;Signature · 1 line
~RandyThank's for the feedback, I'll get that updated now.
Quoted 11 lines
Quoted 2 lines
I'm still kinda new to this, I assume I need to send the new patch via git send-email?
That is one option. Use whatever works for you.
There are several email clients that also work well. See
Documentation/process/email-clients.rst.Signature · 1 line
~RandyFrom
57c8104d2a30020005be16df2ca69ed66f6c4ae9Mon Sep 17 00:00:00 2001
From: Mark Railton <[email protected]>
Date: Mon, 23 Jul 2018 22:28:53 +0100
Subject: [PATCH] Drivers: Xen:xlate_mmu.c: Fixed comment layoutFixed issue with multi line comment
Signed-off-by Mark Railton <[email protected]>--- drivers/xen/xlate_mmu.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)drivers/xen/xlate_mmu.c +4
-3@@ -151,8 +151,10 @@ int xen_xlate_remap_gfn_array(struct vm_area_struct *vma,struct remap_data data;unsigned long range =DIV_ROUND_UP (nr,XEN_PFN_PER_PAGE ) <<PAGE_SHIFT ; -/* Kept here for the purpose of making sure code doesn't break -x86 PVOPS */ +/* +* Kept here for the purpose of making sure code doesn't +* break x86 PVOPS +*/ BUG_ON (!((vma->vm_flags & (VM_PFNMAP |VM_IO )) == (VM_PFNMAP |VM_IO ))); data.fgfn = gfn; --Quoted 1 line
2.17.1
Hi,
a. The subject and the patch description should be in present tense, i.e., Fix instead of Fixed.
Quoted 10 lines
b. Ideally you start a new email thread for new versions of a patch (but Cc:
the interested parties).For the patch itself:
Acked-by Randy Dunlap <[email protected]>Thanks.
Signature · 1 line
~Randy
Thank you for the feedback, I will make sure to take that on board.
Mark
Quoted 53 lines · Randy Dunlap
Quoted 52 lines · Mark Railton
Quoted 37 lines · Randy Dunlap
Quoted 1 line · Mark Railton
Fixed issue with multi line comment
Fix [not Fixed]
Quoted 11 lines
Signed-off-by Mark Railton <[email protected]>--- drivers/xen/xlate_mmu.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)drivers/xen/xlate_mmu.c +0
-0drivers/xen/xlate_mmu.c int xen_xlate_remap_gfn_array(struct vm_area_struct *vma, · line 156
Quoted 8 lines
drivers/xen/xlate_mmu.c +3
-2@@ -151,8 +151,9 @@ int xen_xlate_remap_gfn_array(struct vm_area_struct *vma,struct remap_data data;unsigned long range =DIV_ROUND_UP (nr,XEN_PFN_PER_PAGE ) <<PAGE_SHIFT ; -/* Kept here for the purpose of making sure code doesn't break -x86 PVOPS */ +/* Kept here for the purpose of making sure code doesn't +* break x86 PVOPS +*/ That is still not the preferred kernel multi-line comment style.
Documentation/process/coding-style.rstsays:/*
* This is the preferred style for multi-line
* comments in the Linux kernel source code.
* Please use it consistently.
*
* Description: A column of asterisks on the left side,
* with beginning and ending almost-blank lines. */Quoted 11 lines
although Networking code has a slightly different preferred style (as in your patch).
Quoted 4 lines
drivers/xen/xlate_mmu.c +0
-0BUG_ON (!((vma->vm_flags & (VM_PFNMAP |VM_IO )) == (VM_PFNMAP |VM_IO ))); data.fgfn = gfn;Signature · 1 line
~RandyThank's for the feedback, I'll get that updated now.
Quoted 11 lines
Quoted 2 lines
I'm still kinda new to this, I assume I need to send the new patch via git send-email?
That is one option. Use whatever works for you.
There are several email clients that also work well. See
Documentation/process/email-clients.rst.Signature · 1 line
~Randy
From 57c8104d2a30020005be16df2ca69ed66f6c4ae9 Mon Sep 17 00:00:00 2001
From: Mark Railton <[email protected]>
Date: Mon, 23 Jul 2018 22:28:53 +0100
Subject: [PATCH] Drivers: Xen: xlate_mmu.c: Fixed comment layout
Fixed issue with multi line comment
--- drivers/xen/xlate_mmu.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
drivers/xen/xlate_mmu.c +4 -2
@@ -151,8 +151,10 @@ int xen_xlate_remap_gfn_array(struct vm_area_struct *vma,struct remap_data data;unsigned long range =DIV_ROUND_UP (nr,XEN_PFN_PER_PAGE ) <<PAGE_SHIFT ; -/* Kept here for the purpose of making sure code doesn't break -x86 PVOPS */ +/* +* Kept here for the purpose of making sure code doesn't +* break x86 PVOPS +*/ BUG_ON (!((vma->vm_flags & (VM_PFNMAP |VM_IO )) == (VM_PFNMAP |VM_IO ))); data.fgfn = gfn;
--
2.17.1
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel