bios_emulator: remove assignment without effect
PATCH 1/1 bios_emulator: remove assignment without effect
Assigning a parameter which is not used afterwards has not effect.
--- drivers/bios_emulator/atibios.c | 1 - 1 file changed, 1 deletion(-)
drivers/bios_emulator/atibios.c +0 -1
@@ -602,7 +602,6 @@ int biosemu_run(pci_dev_t pcidev, uchar *bios_rom, int bios_len, (ulong)(vga_info->BIOSImage) != 0xc0000)free (vga_info->BIOSImage);free (vga_info); - vga_info =NULL ; }return 0 ;
Signature · 1 line
2.16.2
PATCH 1/1 bios_emulator: remove assignment without effect
Quoted 6 lines · Heinrich Schuchardt
Assigning a parameter which is not used afterwards has not effect.
Signed-off-by Heinrich Schuchardt <[email protected]>--- drivers/bios_emulator/atibios.c | 1 - 1 file changed, 1 deletion(-)
It is probably just trying to indicate that the value is no-longer valid.
PATCH 1/1 bios_emulator: remove assignment without effect
Quoted 12 lines · Simon Glass
Quoted 6 lines · Heinrich Schuchardt
Assigning a parameter which is not used afterwards has not effect.
Signed-off-by Heinrich Schuchardt <[email protected]>--- drivers/bios_emulator/atibios.c | 1 - 1 file changed, 1 deletion(-)Reviewed-by Simon Glass <[email protected]>It is probably just trying to indicate that the value is no-longer valid.
Hello Tom,
https://patchwork.ozlabs.org/patch/887353/
https://lists.denx.de/pipermail/u-boot/2018-March/323086.html
Another patch that fell into oblivion. Could you, please, merge it.
Best regards
Heinrich
PATCH 1/1 bios_emulator: remove assignment without effect
In reply to Heinrich SchuchardtQuoted 4 lines · Heinrich Schuchardt
Assigning a parameter which is not used afterwards has not effect.
Signed-off-by Heinrich Schuchardt <[email protected]>Reviewed-by Simon Glass <[email protected]>
Applied to u-boot/master, thanks!
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: not available URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180724/6be1b1e9/attachment.sig>