Skip to contentSkip to conversation

drm/amdgpu/gmc9: clarify GPUVM fault error message

PATCH In review Alex Deucher 3 participants 3 messages Jul 24, 2018 – Jul 25, 2018 1 message not in the archive

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/amdgpu/gmc9: clarify GPUVM fault error message

The address printed is the actual address, not the page.

---
 drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c +1 -1
index 9df94b45d17d..399a5db27649 100644
@@ -269,7 +269,7 @@ static int gmc_v9_0_process_interrupt(struct amdgpu_device *adev,
 			entry->src_id, entry->ring_id, entry->vmid,
 			entry->pasid, task_info.process_name, task_info.tgid,
 			task_info.task_name, task_info.pid);
-		dev_err(adev->dev, "  at page 0x%016llx from %d\n",
+		dev_err(adev->dev, "  at address 0x%016llx from %d\n",
 			addr, entry->client_id);
 		if (!amdgpu_sriov_vf(adev))
 			dev_err(adev->dev,
Signature · 6 lines
2.13.6

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): 20180724165414.24442-1-alexander.deucher-5C7GfCeVMHo@public.gmane.org

Reviewed-by Junwei Zhang
#2 lore raw
Quoted 3 lines · Alex Deucher

The address printed is the actual address, not the page.

Quoted 10 lines
---
  drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c +0 -0
index 9df94b45d17d..399a5db27649 100644

drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c static int gmc_v9_0_process_interrupt(struct amdgpu_device *adev, · line 275

Quoted 8 lines
drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c +1 -1
@@ -269,7 +269,7 @@ static int gmc_v9_0_process_interrupt(struct amdgpu_device *adev,
  			entry->src_id, entry->ring_id, entry->vmid,
  			entry->pasid, task_info.process_name, task_info.tgid,
  			task_info.task_name, task_info.pid);
-		dev_err(adev->dev, "  at page 0x%016llx from %d\n",
+		dev_err(adev->dev, "  at address 0x%016llx from %d\n",
  			addr, entry->client_id);
  		if (!amdgpu_sriov_vf(adev))
  			dev_err(adev->dev,

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Reviewed-by
#3 lore raw
In reply to a message not in the archive

Am 24.07.2018 um 18:54 schrieb Alex Deucher:

Quoted 3 lines

The address printed is the actual address, not the page.

Quoted 9 lines
---
  drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c +0 -0
index 9df94b45d17d..399a5db27649 100644

drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c static int gmc_v9_0_process_interrupt(struct amdgpu_device *adev, · line 275

Quoted 8 lines
drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c +1 -1
@@ -269,7 +269,7 @@ static int gmc_v9_0_process_interrupt(struct amdgpu_device *adev,
  			entry->src_id, entry->ring_id, entry->vmid,
  			entry->pasid, task_info.process_name, task_info.tgid,
  			task_info.task_name, task_info.pid);
-		dev_err(adev->dev, "  at page 0x%016llx from %d\n",
+		dev_err(adev->dev, "  at address 0x%016llx from %d\n",
  			addr, entry->client_id);
  		if (!amdgpu_sriov_vf(adev))
  			dev_err(adev->dev,

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx