libnvdimm: Use max contiguous area for namespace size
Subsystems (2)
PATCH v4 1/2 libnvdimm: Use max contiguous area for namespace size
This patch will find the max contiguous area to determine the largest pmem namespace size that can be created. If the requested size exceeds the largest available, ENOSPC error will be returned.
This fixes the allocation underrun error and wrong error return code that have otherwise been observed as the following kernel warning:
WARNING: CPU: <CPU> PID: <PID> at drivers/nvdimm/namespace_devs.c:913 size_store
---
v3 -> v4:
Actually constrain the reserved pmem to the region under consideration rather than the mapping's dimm. This is done by directly calling __reserve_free_pmem with the region's device instead of walking the parent devices children. Thanks to Vishal Verma for reporting how to trigger the incorrect reportings.
Fixed a possible NULL deref, from Gustavo A. R. Silva.
drivers/nvdimm/dimm_devs.c | 31 +++++++++++++++++++++++++++++++ drivers/nvdimm/namespace_devs.c | 6 +++--- drivers/nvdimm/nd-core.h | 8 ++++++++ drivers/nvdimm/region_devs.c | 24 ++++++++++++++++++++++++ 4 files changed, 66 insertions(+), 3 deletions(-)
drivers/nvdimm/dimm_devs.c +31 -0
@@ -536,6 +536,37 @@ resource_size_t nd_blk_available_dpa(struct nd_region *nd_region)return info.available; } +/** +* nd_pmem_max_contiguous_dpa - For the given dimm+region, return the max +* contiguous unallocated dpa range. +* @nd_region: constrain available space check to this reference region +* @nd_mapping: container of dpa-resource-root + labels +*/ +resource_size_t nd_pmem_max_contiguous_dpa (struct nd_region *nd_region, +struct nd_mapping *nd_mapping) +{ +struct nvdimm_drvdata *ndd =to_ndd (nd_mapping); +struct nvdimm_bus *nvdimm_bus; +resource_size_t max =0 ; +struct resource *res; + +/* if a dimm is disabled the available capacity is zero */ +if (!ndd) +return 0 ; + + nvdimm_bus =walk_to_nvdimm_bus (ndd->dev); +if (__reserve_free_pmem (&nd_region->dev, nd_mapping->nvdimm)) +return 0 ; +for_each_dpa_resource (ndd, res) { +if (strcmp (res->name,"pmem-reserve" ) !=0 ) +continue ; +if (resource_size (res) > max) + max =resource_size (res); + } +release_free_pmem (nvdimm_bus, nd_mapping); +return max; +} +/** * nd_pmem_available_dpa - for the given dimm+region account unallocated dpa * @nd_mapping: container of dpa-resource-root + labels
drivers/nvdimm/namespace_devs.c +3 -3
@@ -799,7 +799,7 @@ static int merge_dpa(struct nd_region *nd_region,return 0 ; } -static int __reserve_free_pmem (struct device *dev,void *data) +int __reserve_free_pmem (struct device *dev,void *data) {struct nvdimm *nvdimm = data;struct nd_region *nd_region;
@@ -836,7 +836,7 @@ static int __reserve_free_pmem(struct device *dev, void *data)return 0 ; } -static void release_free_pmem (struct nvdimm_bus *nvdimm_bus, +void release_free_pmem (struct nvdimm_bus *nvdimm_bus,struct nd_mapping *nd_mapping) {struct nvdimm_drvdata *ndd =to_ndd (nd_mapping);
@@ -1032,7 +1032,7 @@ static ssize_t __size_store(struct device *dev, unsigned long long val) allocated +=nvdimm_allocated_dpa (ndd, &label_id); } - available =nd_region_available_dpa (nd_region); + available =nd_region_allocatable_dpa (nd_region);if (val > available + allocated)return -ENOSPC ;
drivers/nvdimm/nd-core.h +8 -0
@@ -100,6 +100,14 @@ struct nd_region;struct nvdimm_drvdata ;struct nd_mapping ;void nd_mapping_free_labels (struct nd_mapping *nd_mapping); + +int __reserve_free_pmem (struct device *dev,void *data); +void release_free_pmem (struct nvdimm_bus *nvdimm_bus, +struct nd_mapping *nd_mapping); + +resource_size_t nd_pmem_max_contiguous_dpa (struct nd_region *nd_region, +struct nd_mapping *nd_mapping); +resource_size_t nd_region_allocatable_dpa (struct nd_region *nd_region);resource_size_t nd_pmem_available_dpa (struct nd_region *nd_region,struct nd_mapping *nd_mapping,resource_size_t *overlap);resource_size_t nd_blk_available_dpa (struct nd_region *nd_region);
drivers/nvdimm/region_devs.c +24 -0
@@ -389,6 +389,30 @@ resource_size_t nd_region_available_dpa(struct nd_region *nd_region)return available; } +resource_size_t nd_region_allocatable_dpa (struct nd_region *nd_region) +{ +resource_size_t available =0 ; +int i; + +if (is_memory (&nd_region->dev)) + available =PHYS_ADDR_MAX ; + +WARN_ON (!is_nvdimm_bus_locked (&nd_region->dev)); +for (i =0 ; i < nd_region->ndr_mappings; i++) { +struct nd_mapping *nd_mapping = &nd_region->mapping[i]; + +if (is_memory (&nd_region->dev)) + available =min (available, +nd_pmem_max_contiguous_dpa (nd_region, + nd_mapping)); +else if (is_nd_blk (&nd_region->dev)) + available +=nd_blk_available_dpa (nd_region); + } +if (is_memory (&nd_region->dev)) +return available * nd_region->ndr_mappings; +return available; +} +static ssize_t available_size_show (struct device *dev,struct device_attribute *attr,char *buf) {
Signature · 6 lines
2.14.4 _______________________________________________ Linux-nvdimm mailing list [email protected] https://lists.01.org/mailman/listinfo/linux-nvdimm
PATCH v4 2/2 libnvdimm: Export max available extent
The 'available_size' attribute showing the combined total of all unallocated space isn't always useful to know how large of a namespace a user may be able to allocate if the region is fragmented. This patch will export the largest extent of unallocated space that may be allocated to create a new namespace.
---
No change since previous version
drivers/nvdimm/region_devs.c | 16 ++++++++++++++++ 1 file changed, 16 insertions(+)
drivers/nvdimm/region_devs.c +16 -0
@@ -434,6 +434,21 @@ static ssize_t available_size_show(struct device *dev, }static DEVICE_ATTR_RO (available_size); +static ssize_t max_available_extent_show (struct device *dev, +struct device_attribute *attr,char *buf) +{ +struct nd_region *nd_region =to_nd_region (dev); +unsigned long long available =0 ; + +nvdimm_bus_lock (dev); +wait_nvdimm_bus_probe_idle (dev); + available =nd_region_allocatable_dpa (nd_region); +nvdimm_bus_unlock (dev); + +return sprintf (buf,"%llu\n" , available); +} +static DEVICE_ATTR_RO (max_available_extent); +static ssize_t init_namespaces_show (struct device *dev,struct device_attribute *attr,char *buf) {
@@ -585,6 +600,7 @@ static struct attribute *nd_region_attributes[] = { &dev_attr_read_only.attr, &dev_attr_set_cookie.attr, &dev_attr_available_size.attr, + &dev_attr_max_available_extent.attr, &dev_attr_namespace_seed.attr, &dev_attr_init_namespaces.attr, &dev_attr_badblocks.attr,
Signature · 6 lines
2.14.4 _______________________________________________ Linux-nvdimm mailing list [email protected] https://lists.01.org/mailman/listinfo/linux-nvdimm
Re: [PATCHv4 2/2] libnvdimm: Export max available extent
Quoted 9 lines · Keith Busch
The '
available_size' attribute showing the combined total of all unallocated space isn't always useful to know how large of a namespace
a user may be able to allocate if the region is fragmented. This patch
will export the largest extent of unallocated space that may be allocated
to create a new namespace.
Quoted 6 lines
Signed-off-by Keith Busch <[email protected]>---
No change since previous versiondrivers/nvdimm/region_devs.c | 16 ++++++++++++++++ 1 file changed, 16 insertions(+)
Looks good to me. Feel free to add:
Quoted 37 lines
drivers/nvdimm/region_devs.c +15
-0@@ -434,6 +434,21 @@ static ssize_t available_size_show(struct device *dev, }static DEVICE_ATTR_RO (available_size); +static ssize_t max_available_extent_show (struct device *dev, +struct device_attribute *attr,char *buf) +{ +struct nd_region *nd_region =to_nd_region (dev); +unsigned long long available =0 ; + +nvdimm_bus_lock (dev); +wait_nvdimm_bus_probe_idle (dev); + available =nd_region_allocatable_dpa (nd_region); +nvdimm_bus_unlock (dev); + +return sprintf (buf,"%llu\n" , available); +} +static DEVICE_ATTR_RO (max_available_extent); +static ssize_t init_namespaces_show (struct device *dev,struct device_attribute *attr,char *buf){
drivers/nvdimm/region_devs.c +1
-0@@ -585,6 +600,7 @@ static struct attribute *nd_region_attributes[] = { &dev_attr_read_only.attr, &dev_attr_set_cookie.attr, &dev_attr_available_size.attr, + &dev_attr_max_available_extent.attr, &dev_attr_namespace_seed.attr, &dev_attr_init_namespaces.attr,
Quoted 1 line
&dev_attr_badblocks.attr,
_______________________________________________
Linux-nvdimm mailing list
[email protected]
https://lists.01.org/mailman/listinfo/linux-nvdimm
Quoted 15 lines · Keith Busch
This patch will find the max contiguous area to determine the largest pmem namespace size that can be created. If the requested size exceeds the largest available, ENOSPC error will be returned.
This fixes the allocation underrun error and wrong error return code that have otherwise been observed as the following kernel warning:
WARNING: CPU: <CPU> PID: <PID> at drivers/nvdimm/namespace_devs.c:913 size_storeFixes a1f3e4d6a0c3 ("libnvdimm, region: update nd_region_available_dpa() for multi-pmem support")Cc <[email protected]>Signed-off-by Keith Busch <[email protected]>---
v3 -> v4:
Quoted 7 lines
Actually constrain the reserved pmem to the region under consideration rather than the mapping's dimm. This is done by directly calling
__reserve_free_pmemwith the region's device instead of walking the parent devices children. Thanks to Vishal Verma for reporting how to trigger the incorrect reportings.Fixed a possible NULL deref, from Gustavo A. R. Silva.
Looks good to me. Feel free to add:
Quoted 124 lines
drivers/nvdimm/dimm_devs.c | 31 +++++++++++++++++++++++++++++++ drivers/nvdimm/namespace_devs.c | 6 +++--- drivers/nvdimm/nd-core.h | 8 ++++++++ drivers/nvdimm/region_devs.c | 24 ++++++++++++++++++++++++ 4 files changed, 66 insertions(+), 3 deletions(-)drivers/nvdimm/dimm_devs.c +31
-0@@ -536,6 +536,37 @@ resource_size_t nd_blk_available_dpa(struct nd_region *nd_region)return info.available; } +/** +* nd_pmem_max_contiguous_dpa - For the given dimm+region, return the max +* contiguous unallocated dpa range. +* @nd_region: constrain available space check to this reference region +* @nd_mapping: container of dpa-resource-root + labels +*/ +resource_size_t nd_pmem_max_contiguous_dpa (struct nd_region *nd_region, +struct nd_mapping *nd_mapping) +{ +struct nvdimm_drvdata *ndd =to_ndd (nd_mapping); +struct nvdimm_bus *nvdimm_bus; +resource_size_t max =0 ; +struct resource *res; + +/* if a dimm is disabled the available capacity is zero */ +if (!ndd) +return 0 ; + + nvdimm_bus =walk_to_nvdimm_bus (ndd->dev); +if (__reserve_free_pmem (&nd_region->dev, nd_mapping->nvdimm)) +return 0 ; +for_each_dpa_resource (ndd, res) { +if (strcmp (res->name,"pmem-reserve" ) !=0 ) +continue ; +if (resource_size (res) > max) + max =resource_size (res); + } +release_free_pmem (nvdimm_bus, nd_mapping); +return max; +} +/** * nd_pmem_available_dpa - for the given dimm+region account unallocated dpa * @nd_mapping: container of dpa-resource-root + labels drivers/nvdimm/namespace_devs.c +3
-3@@ -799,7 +799,7 @@ static int merge_dpa(struct nd_region *nd_region,return 0 ; } -static int __reserve_free_pmem (struct device *dev,void *data) +int __reserve_free_pmem (struct device *dev,void *data) {struct nvdimm *nvdimm = data;struct nd_region *nd_region;@@ -836,7 +836,7 @@ static int __reserve_free_pmem(struct device *dev, void *data)return 0 ; } -static void release_free_pmem (struct nvdimm_bus *nvdimm_bus, +void release_free_pmem (struct nvdimm_bus *nvdimm_bus,struct nd_mapping *nd_mapping) {struct nvdimm_drvdata *ndd =to_ndd (nd_mapping);@@ -1032,7 +1032,7 @@ static ssize_t __size_store(struct device *dev, unsigned long long val) allocated +=nvdimm_allocated_dpa (ndd, &label_id); } - available =nd_region_available_dpa (nd_region); + available =nd_region_allocatable_dpa (nd_region);if (val > available + allocated)return -ENOSPC ;drivers/nvdimm/nd-core.h +8
-0@@ -100,6 +100,14 @@ struct nd_region;struct nvdimm_drvdata ;struct nd_mapping ;void nd_mapping_free_labels (struct nd_mapping *nd_mapping); + +int __reserve_free_pmem (struct device *dev,void *data); +void release_free_pmem (struct nvdimm_bus *nvdimm_bus, +struct nd_mapping *nd_mapping); + +resource_size_t nd_pmem_max_contiguous_dpa (struct nd_region *nd_region, +struct nd_mapping *nd_mapping); +resource_size_t nd_region_allocatable_dpa (struct nd_region *nd_region);resource_size_t nd_pmem_available_dpa (struct nd_region *nd_region,struct nd_mapping *nd_mapping,resource_size_t *overlap);resource_size_t nd_blk_available_dpa (struct nd_region *nd_region);drivers/nvdimm/region_devs.c +17
-0@@ -389,6 +389,30 @@ resource_size_t nd_region_available_dpa(struct nd_region *nd_region)return available; } +resource_size_t nd_region_allocatable_dpa (struct nd_region *nd_region) +{ +resource_size_t available =0 ; +int i; + +if (is_memory (&nd_region->dev)) + available =PHYS_ADDR_MAX ; + +WARN_ON (!is_nvdimm_bus_locked (&nd_region->dev)); +for (i =0 ; i < nd_region->ndr_mappings; i++) { +struct nd_mapping *nd_mapping = &nd_region->mapping[i]; + +if (is_memory (&nd_region->dev)) + available =min (available, +nd_pmem_max_contiguous_dpa (nd_region, + nd_mapping)); +else if (is_nd_blk (&nd_region->dev))
drivers/nvdimm/region_devs.c resource_size_t nd_region_available_dpa(struct nd_region *nd_region) · line 418
Quoted 10 lines
drivers/nvdimm/region_devs.c +7
-0+ available +=nd_blk_available_dpa (nd_region); + } +if (is_memory (&nd_region->dev)) +return available * nd_region->ndr_mappings; +return available; +} +static ssize_t available_size_show (struct device *dev,struct device_attribute *attr,char *buf) {
_______________________________________________
Linux-nvdimm mailing list
[email protected]
https://lists.01.org/mailman/listinfo/linux-nvdimm