Skip to contentSkip to conversation

selftests: kselftest: Remove outdated comment

PATCH In review Thiago Jung Bauermann 2 participants 3 messages Jul 25, 2018 – Aug 27, 2018 Kselftest

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 selftests: kselftest: Remove outdated comment

Commit 3c07aaef6598 ("selftests: kselftest: change KSFT_SKIP=4 instead of KSFT_PASS") reverted commit 11867a77eb85 ("selftests: kselftest framework:
change skip exit code to 0") but missed removing the comment which that commit added, so do that now.

Signed-off-by Thiago Jung Bauermann <bauerman at linux.ibm.com>
---
 tools/testing/selftests/kselftest.h | 1 -
 1 file changed, 1 deletion(-)
tools/testing/selftests/kselftest.h +0 -1
index 15e6b75fc3a5..a3edb2c8e43d 100644
@@ -19,7 +19,6 @@
 #define KSFT_FAIL  1
 #define KSFT_XFAIL 2
 #define KSFT_XPASS 3
-/* Treat skip as pass */
 #define KSFT_SKIP  4
 
 /* counters */

--
To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html

maintainer
#1 lore raw
Quoted 17 lines · Thiago Jung Bauermann

Commit 3c07aaef6598 ("selftests: kselftest: change KSFT_SKIP=4 instead of KSFT_PASS") reverted commit 11867a77eb85 ("selftests: kselftest framework:
change skip exit code to 0") but missed removing the comment which that commit added, so do that now.

Signed-off-by Thiago Jung Bauermann <bauerman at linux.ibm.com>
---
 tools/testing/selftests/kselftest.h | 1 -
 1 file changed, 1 deletion(-)
tools/testing/selftests/kselftest.h +0 -0
index 15e6b75fc3a5..a3edb2c8e43d 100644

tools/testing/selftests/kselftest.h line 24

Quoted 7 lines
tools/testing/selftests/kselftest.h +0 -1
@@ -19,7 +19,6 @@
 #define KSFT_FAIL  1
 #define KSFT_XFAIL 2
 #define KSFT_XPASS 3
-/* Treat skip as pass */
 #define KSFT_SKIP  4
 
 /* counters */

Thanks for the patch. Sorry for the delay. It is now in linux-kselfttest next for the next 4.19-rc

thanks,
-- Shuah

#2 lore raw
Quoted 22 lines · Shuah Khan
Quoted 21 lines · Thiago Jung Bauermann

Commit 3c07aaef6598 ("selftests: kselftest: change KSFT_SKIP=4 instead of KSFT_PASS") reverted commit 11867a77eb85 ("selftests: kselftest framework:
change skip exit code to 0") but missed removing the comment which that commit added, so do that now.

Signed-off-by Thiago Jung Bauermann <bauerman at linux.ibm.com>
---
 tools/testing/selftests/kselftest.h | 1 -
 1 file changed, 1 deletion(-)
tools/testing/selftests/kselftest.h +0 -1
index 15e6b75fc3a5..a3edb2c8e43d 100644
@@ -19,7 +19,6 @@
 #define KSFT_FAIL  1
 #define KSFT_XFAIL 2
 #define KSFT_XPASS 3
-/* Treat skip as pass */
 #define KSFT_SKIP  4
 
Quoted 6 lines

tools/testing/selftests/kselftest.h line 24

Quoted 3 lines
tools/testing/selftests/kselftest.h +0 -0
 /* counters */

Thanks for the patch. Sorry for the delay. It is now in linux-kselfttest next for the next 4.19-rc

The delay isn't a problem. Thanks!

Signature · 2 lines
Thiago Jung Bauermann
IBM Linux Technology Center