Skip to contentSkip to conversation

lib/tst_test.sh: Silence getopts

PATCH New Petr Vorel 2 participants 3 messages May 23, 2018 – Jul 26, 2018

lore
Share & tools
lore

Petr Vorel

author
#0 lore raw

PATCH 1/1 lib/tst_test.sh: Silence getopts

We handle the error already there, so there is no point printing one more redundant message that doesn't have LTP format.

---
 testcases/lib/tst_test.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
testcases/lib/tst_test.sh +1 -1
index 464c4c41e..ac315075f 100644
@@ -265,7 +265,7 @@ tst_run()
 
 	OPTIND=1
 
-	while getopts "hi:$TST_OPTS" name $TST_ARGS; do
+	while getopts ":hi:$TST_OPTS" name $TST_ARGS; do
 		case $name in
 		'h') tst_usage; exit 0;;
 		'i') TST_ITERATIONS=$OPTARG;;
Signature · 1 line
2.16.3
#1 lore raw

PATCH 1/1 lib/tst_test.sh: Silence getopts

Hi!
I would says this is obvious enough to be commited without review.

But anyways acked, and sorry for neglecting this for so long.

Signature · 2 lines
Cyril Hrubis
[email protected]
author
#2 lore raw

PATCH 1/1 lib/tst_test.sh: Silence getopts

Hi Cyril,

Quoted 4 lines

Hi!
I would says this is obvious enough to be commited without review.

But anyways acked, and sorry for neglecting this for so long.

Pushed. Thanks for your review!
I consider new lib sources something which needs a review, but in this case I was probably too careful.

Kind regards,
Petr