Skip to contentSkip to conversation

staging: rtl8188eu: remove unused ODM_RASupport_Init()

PATCH New Michael Straube 1 participant 4 messages Jul 25, 2018 Staging

lore
Share & tools
lore

Michael Straube

author
#0 lore raw

PATCH 1/4 staging: rtl8188eu: remove unused ODM_RASupport_Init()

The function ODM_RASupport_Init() is never used, so remove it. Discovered by cppcheck.

Signed-off-by Michael Straube <[email protected]>
---
 drivers/staging/rtl8188eu/hal/hal8188e_rate_adaptive.c | 10 ----------
 .../staging/rtl8188eu/include/hal8188e_rate_adaptive.h |  2 --
 2 files changed, 12 deletions(-)
drivers/staging/rtl8188eu/hal/hal8188e_rate_adaptive.c +0 -10
index bbb981c6bcec..464c11710398 100644
@@ -542,16 +542,6 @@ odm_RATxRPTTimerSetting(
 	ODM_RT_TRACE(dm_odm, ODM_COMP_RATE_ADAPTIVE, ODM_DBG_TRACE, (" <===== odm_RATxRPTTimerSetting()\n"));
 }
 
-void
-ODM_RASupport_Init(
-		struct odm_dm_struct *dm_odm
-	)
-{
-	ODM_RT_TRACE(dm_odm, ODM_COMP_RATE_ADAPTIVE, ODM_DBG_LOUD, ("=====>ODM_RASupport_Init()\n"));
-
-	dm_odm->RaSupport88E = true;
-}
-
 int ODM_RAInfo_Init(struct odm_dm_struct *dm_odm, u8 macid)
 {
 	struct odm_ra_info *pRaInfo = &dm_odm->RAInfo[macid];
drivers/staging/rtl8188eu/include/hal8188e_rate_adaptive.h +0 -2
index 96ebda93b4ee..5b59c25e4c8a 100644
@@ -49,8 +49,6 @@
 
 /*  End rate adaptive define */
 
-void ODM_RASupport_Init(struct odm_dm_struct *dm_odm);
-
 int ODM_RAInfo_Init_all(struct odm_dm_struct *dm_odm);
 
 int ODM_RAInfo_Init(struct odm_dm_struct *dm_odm, u8 MacID);
Signature · 1 line
2.18.0
author
#1 lore raw

PATCH 2/4 staging: rtl8188eu: remove unused CAM_empty_entry()

The function CAM_empty_entry() is never used, so remove it. Discovered by cppcheck.

Signed-off-by Michael Straube <[email protected]>
---
 drivers/staging/rtl8188eu/core/rtw_wlan_util.c   | 5 -----
 drivers/staging/rtl8188eu/include/rtw_mlme_ext.h | 1 -
 2 files changed, 6 deletions(-)
drivers/staging/rtl8188eu/core/rtw_wlan_util.c +0 -5
index 5c4f3f8d013f..474aa9dcf39d 100644
@@ -434,11 +434,6 @@ unsigned int decide_wait_for_beacon_timeout(unsigned int bcn_interval)
 		return bcn_interval << 2;
 }
 
-void CAM_empty_entry(struct adapter *Adapter, u8 ucIndex)
-{
-	rtw_hal_set_hwreg(Adapter, HW_VAR_CAM_EMPTY_ENTRY, (u8 *)(&ucIndex));
-}
-
 void invalidate_cam_all(struct adapter *padapter)
 {
 	rtw_hal_set_hwreg(padapter, HW_VAR_CAM_INVALID_ALL, NULL);
drivers/staging/rtl8188eu/include/rtw_mlme_ext.h +0 -1
index 8ecf43d03278..43a3c5009ad0 100644
@@ -487,7 +487,6 @@ void write_cam(struct adapter *padapter, u8 entry, u16 ctrl, u8 *mac, u8 *key);
 void clear_cam_entry(struct adapter *padapter, u8 entry);
 
 void invalidate_cam_all(struct adapter *padapter);
-void CAM_empty_entry(struct adapter *Adapter, u8 ucIndex);
 
 int allocate_fw_sta_entry(struct adapter *padapter);
 void flush_all_cam_entry(struct adapter *padapter);
Signature · 1 line
2.18.0
author
#2 lore raw

PATCH 3/4 staging: rtl8188eu: remove unused rtw_get_oper_bw()

In reply to Michael Straube

The function rtw_get_oper_bw() is never used, so remove it. Discovered by cppcheck.

Signed-off-by Michael Straube <[email protected]>
---
 drivers/staging/rtl8188eu/core/rtw_wlan_util.c   | 5 -----
 drivers/staging/rtl8188eu/include/rtw_mlme_ext.h | 1 -
 2 files changed, 6 deletions(-)
drivers/staging/rtl8188eu/core/rtw_wlan_util.c +0 -5
index 474aa9dcf39d..ab97fcdd6481 100644
@@ -298,11 +298,6 @@ inline void rtw_set_oper_ch(struct adapter *adapter, u8 ch)
 	adapter->mlmeextpriv.oper_channel = ch;
 }
 
-inline u8 rtw_get_oper_bw(struct adapter *adapter)
-{
-	return adapter->mlmeextpriv.oper_bwmode;
-}
-
 inline void rtw_set_oper_bw(struct adapter *adapter, u8 bw)
 {
 	adapter->mlmeextpriv.oper_bwmode = bw;
drivers/staging/rtl8188eu/include/rtw_mlme_ext.h +0 -1
index 43a3c5009ad0..50051a1b0655 100644
@@ -470,7 +470,6 @@ void Set_MSR(struct adapter *padapter, u8 type);
 
 u8 rtw_get_oper_ch(struct adapter *adapter);
 void rtw_set_oper_ch(struct adapter *adapter, u8 ch);
-u8 rtw_get_oper_bw(struct adapter *adapter);
 void rtw_set_oper_bw(struct adapter *adapter, u8 bw);
 u8 rtw_get_oper_choffset(struct adapter *adapter);
 void rtw_set_oper_choffset(struct adapter *adapter, u8 offset);
Signature · 1 line
2.18.0
author
#3 lore raw

PATCH 4/4 staging: rtl8188eu: remove unused rtw_get_oper_choffset()

In reply to Michael Straube

The function rtw_get_oper_choffset() is never used, so remove it. Discovered by cppcheck.

Signed-off-by Michael Straube <[email protected]>
---
 drivers/staging/rtl8188eu/core/rtw_wlan_util.c   | 5 -----
 drivers/staging/rtl8188eu/include/rtw_mlme_ext.h | 1 -
 2 files changed, 6 deletions(-)
drivers/staging/rtl8188eu/core/rtw_wlan_util.c +0 -5
index ab97fcdd6481..0fe35e141926 100644
@@ -303,11 +303,6 @@ inline void rtw_set_oper_bw(struct adapter *adapter, u8 bw)
 	adapter->mlmeextpriv.oper_bwmode = bw;
 }
 
-inline u8 rtw_get_oper_choffset(struct adapter *adapter)
-{
-	return adapter->mlmeextpriv.oper_ch_offset;
-}
-
 inline void rtw_set_oper_choffset(struct adapter *adapter, u8 offset)
 {
 	adapter->mlmeextpriv.oper_ch_offset = offset;
drivers/staging/rtl8188eu/include/rtw_mlme_ext.h +0 -1
index 50051a1b0655..c072e1e25d61 100644
@@ -471,7 +471,6 @@ void Set_MSR(struct adapter *padapter, u8 type);
 u8 rtw_get_oper_ch(struct adapter *adapter);
 void rtw_set_oper_ch(struct adapter *adapter, u8 ch);
 void rtw_set_oper_bw(struct adapter *adapter, u8 bw);
-u8 rtw_get_oper_choffset(struct adapter *adapter);
 void rtw_set_oper_choffset(struct adapter *adapter, u8 offset);
 
 void set_channel_bwmode(struct adapter *padapter, unsigned char channel,
Signature · 1 line
2.18.0