Skip to contentSkip to conversation

libostree: override path to gpg-error-config

PATCH Superseded Marcus Folkesson 3 participants 5 messages Jul 26, 2018

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore

Marcus Folkesson

author
#0 lore raw

PATCH v2 1/1 libostree: override path to gpg-error-config

libostree has begun to use gpg-error-config in their configuration script.
Point out gpg-error-config in staging dir to avoid using the one installed on the host system.

Fixes:
http://autobuild.buildroot.net/results/447b96e449e881cf1bd9644cda0f386aa4c75724

Signed-off-by Marcus Folkesson <[email protected]>

---

Notes:
v2:
- override ac_cv_path_GPG_ERROR_CONFIG instead of GPG_ERROR_CONFIG

 package/libostree/libostree.mk | 1 +
 1 file changed, 1 insertion(+)
package/libostree/libostree.mk +1 -0
index 24eda0d1db..414cca104a 100644
@@ -12,6 +12,7 @@ LIBOSTREE_LICENSE = LGPL-2.0+
 LIBOSTREE_LICENSE_FILES = COPYING
 LIBOSTREE_DEPENDENCIES = e2fsprogs host-bison host-pkgconf libfuse libglib2 libgpgme xz
 LIBOSTREE_INSTALL_STAGING = YES
+LIBOSTREE_CONF_ENV = GPG_ERROR_CONFIG=$(STAGING_DIR)/usr/bin/gpg-error-config
 
 LIBOSTREE_CONF_OPTS += \
 	--with-gpgme-prefix=$(STAGING_DIR)/usr \
Signature · 1 line
2.18.0
author
#1 lore raw

PATCH v2 1/1 libostree: override path to gpg-error-config

Quoted 8 lines · Marcus Folkesson

libostree has begun to use gpg-error-config in their configuration script.
Point out gpg-error-config in staging dir to avoid using the one installed on the host system.

Fixes:
http://autobuild.buildroot.net/results/447b96e449e881cf1bd9644cda0f386aa4c75724

Quoted 6 lines
Signed-off-by Marcus Folkesson <[email protected]>

---

Notes:
v2:
- override ac_cv_path_GPG_ERROR_CONFIG instead of GPG_ERROR_CONFIG

Eum...

- override GPG_ERROR_CONFIG instead of ac_cv_path_GPG_ERROR_CONFIG

:-)

Quoted 19 lines
 package/libostree/libostree.mk | 1 +
 1 file changed, 1 insertion(+)
package/libostree/libostree.mk +1 -0
index 24eda0d1db..414cca104a 100644
@@ -12,6 +12,7 @@ LIBOSTREE_LICENSE = LGPL-2.0+
 LIBOSTREE_LICENSE_FILES = COPYING
 LIBOSTREE_DEPENDENCIES = e2fsprogs host-bison host-pkgconf libfuse libglib2 libgpgme xz
 LIBOSTREE_INSTALL_STAGING = YES
+LIBOSTREE_CONF_ENV = GPG_ERROR_CONFIG=$(STAGING_DIR)/usr/bin/gpg-error-config
 
 LIBOSTREE_CONF_OPTS += \
 	--with-gpgme-prefix=$(STAGING_DIR)/usr \
Signature · 1 line
2.18.0

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20180726/554dfadc/attachment.asc>

#2 lore raw

PATCH v2 1/1 libostree: override path to gpg-error-config

In reply to Marcus Folkesson
Quoted 9 lines · Marcus Folkesson

libostree has begun to use gpg-error-config in their configuration script.
Point out gpg-error-config in staging dir to avoid using the one installed on the host system.

Fixes:
http://autobuild.buildroot.net/results/447b96e449e881cf1bd9644cda0f386aa4c75724

Signed-off-by Marcus Folkesson <[email protected]>
Reviewed-by Arnout Vandecappelle (Essensium/Mind) <[email protected]>

Regards,
Arnout

Quoted 22 lines

---

Notes:
v2:
- override ac_cv_path_GPG_ERROR_CONFIG instead of GPG_ERROR_CONFIG

 package/libostree/libostree.mk | 1 +
 1 file changed, 1 insertion(+)
package/libostree/libostree.mk +1 -0
index 24eda0d1db..414cca104a 100644
@@ -12,6 +12,7 @@ LIBOSTREE_LICENSE = LGPL-2.0+
 LIBOSTREE_LICENSE_FILES = COPYING
 LIBOSTREE_DEPENDENCIES = e2fsprogs host-bison host-pkgconf libfuse libglib2 libgpgme xz
 LIBOSTREE_INSTALL_STAGING = YES
+LIBOSTREE_CONF_ENV = GPG_ERROR_CONFIG=$(STAGING_DIR)/usr/bin/gpg-error-config
 
 LIBOSTREE_CONF_OPTS += \
 	--with-gpgme-prefix=$(STAGING_DIR)/usr \
Signature · 6 lines
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
#3 lore raw

PATCH v2 1/1 libostree: override path to gpg-error-config

In reply to Marcus Folkesson

Hello,

Quoted 23 lines · Marcus Folkesson

libostree has begun to use gpg-error-config in their configuration script.
Point out gpg-error-config in staging dir to avoid using the one installed on the host system.

Fixes:
http://autobuild.buildroot.net/results/447b96e449e881cf1bd9644cda0f386aa4c75724

Signed-off-by Marcus Folkesson <[email protected]>

---

Notes:
v2:
- override ac_cv_path_GPG_ERROR_CONFIG instead of GPG_ERROR_CONFIG

 package/libostree/libostree.mk | 1 +
 1 file changed, 1 insertion(+)
package/libostree/libostree.mk +0 -0
index 24eda0d1db..414cca104a 100644

package/libostree/libostree.mk LIBOSTREE_LICENSE = LGPL-2.0+ · line 15

Quoted 4 lines
package/libostree/libostree.mk +1 -0
@@ -12,6 +12,7 @@ LIBOSTREE_LICENSE = LGPL-2.0+
 LIBOSTREE_LICENSE_FILES = COPYING
 LIBOSTREE_DEPENDENCIES = e2fsprogs host-bison host-pkgconf libfuse libglib2 libgpgme xz
 LIBOSTREE_INSTALL_STAGING = YES
+LIBOSTREE_CONF_ENV = GPG_ERROR_CONFIG=$(STAGING_DIR)/usr/bin/gpg-error-config

So libostree is using libgpg-error directly, not only indirectly through libgpgme. Should we add libgpg-error in libostree dependencies explicitly to document this direct dependency ?

It is a bit weird to pass GPG_ERROR_CONFIG with this package not depending on libgpg-error.

Best regards,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
author
#4 lore raw

PATCH v2 1/1 libostree: override path to gpg-error-config

Hello,

Quoted 21 lines · Thomas Petazzoni

Hello,

Quoted 18 lines · Marcus Folkesson

libostree has begun to use gpg-error-config in their configuration script.
Point out gpg-error-config in staging dir to avoid using the one installed on the host system.

Fixes:
http://autobuild.buildroot.net/results/447b96e449e881cf1bd9644cda0f386aa4c75724

Signed-off-by Marcus Folkesson <[email protected]>

---

Notes:
v2:
- override ac_cv_path_GPG_ERROR_CONFIG instead of GPG_ERROR_CONFIG

 package/libostree/libostree.mk | 1 +
 1 file changed, 1 insertion(+)
Quoted 13 lines

package/libostree/libostree.mk LIBOSTREE_LICENSE = LGPL-2.0+ · line 15

Quoted 9 lines
package/libostree/libostree.mk +1 -0
index 24eda0d1db..414cca104a 100644
@@ -12,6 +12,7 @@ LIBOSTREE_LICENSE = LGPL-2.0+
 LIBOSTREE_LICENSE_FILES = COPYING
 LIBOSTREE_DEPENDENCIES = e2fsprogs host-bison host-pkgconf libfuse libglib2 libgpgme xz
 LIBOSTREE_INSTALL_STAGING = YES
+LIBOSTREE_CONF_ENV = GPG_ERROR_CONFIG=$(STAGING_DIR)/usr/bin/gpg-error-config

So libostree is using libgpg-error directly, not only indirectly through libgpgme. Should we add libgpg-error in libostree dependencies explicitly to document this direct dependency ?

That would be good. I will add it in v3. Thanks

Quoted 11 lines

It is a bit weird to pass GPG_ERROR_CONFIG with this package not depending on libgpg-error.

Best regards,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com

Best regards
Marcus Folkesson
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20180726/b574b30e/attachment.asc>