postgresql --with-libxml configure option added
A message that is not in the archive (sent off-list or not yet received): [email protected]
A message that is not in the archive (sent off-list or not yet received): F73717A01AEC1F4CB9A3D10E39CBB88F4424CD47@INNO-EX-2010.innovaphone.sifi
A message that is not in the archive (sent off-list or not yet received): F73717A01AEC1F4CB9A3D10E39CBB88F443662EA@INNO-EX-2010.innovaphone.sifi
PATCH 1/1 postgresql --with-libxml configure option added
The postgresql package is now built with --with-libxml if BR2_PACKAGE_LIBXML2 is selected to allow the use of XML functions in postgresql.
--- package/postgresql/postgresql.mk | 8 ++++++++ 1 file changed, 8 insertions(+)
package/postgresql/postgresql.mk +8 -0
@@ -70,6 +70,14 @@ else POSTGRESQL_CONF_OPTS += --without-ldap endif +ifeq ($(BR2_PACKAGE_LIBXML2),y) +POSTGRESQL_DEPENDENCIES += libxml2 +POSTGRESQL_CONF_OPTS += --with-libxml +POSTGRESQL_CONF_ENV += XML2_CONFIG=$(STAGING_DIR)/usr/bin/xml2-config +else +POSTGRESQL_CONF_OPTS += --without-libxml +endif + define POSTGRESQL_USERS postgres -1 postgres -1 * /var/lib/pgsql /bin/sh - PostgreSQL Server endef
--
2.11.0
_______________________________________________________________________________
Thomas Ehrhardt | Development
_______________________________________________________________________________
innovaphone AG
PURE IP COMMUNICATIONS
B?blinger Stra?e 76 | 71065 Sindelfingen | Germany
Tel: +49(7031)73009-648 | Fax: +49(7031)73009-9
E-Mail: tehrhardt at innovaphone.com | http://www.innovaphone.com
[Sitz der Gesellschaft: Sindelfingen | HRB Nr. 245196 Amtsgericht Stuttgart | Vorstand: Dagmar Geer (Vorsitzende), Carsten Bode, Guntram Diehl, Gerd Hornig | Vorsitzender des Aufsichtsrates: Gebhard Michel]
Campaign - https://www.youtube.com/user/innovaphoneTV
[X]
PATCH 1/1 postgresql --with-libxml configure option added
Hello Thomas,
Quoted 3 lines · Thomas Ehrhardt
The postgresql package is now built with --with-libxml if
BR2_PACKAGE_LIBXML2is selected to allow the use of XML functions in postgresql.Signed-off-by Daniel Deterding <[email protected]>
Thanks for your patch, it looks good, but there's one issue: the From doesn't match the Signed-off-by.
If I understand correctly, the patch was done by your colleague Daniel Deterding, and you are sending it on his behalf. If that is correct, then you need to add your own Signed-off-by below the one from Daniel.
While you're at it, could you fix the minor issues below (I had fixed them locally as I was about to apply the patch, but realized the Signed-off-by issue) :
- The commit title should have the format:
<package>: <description>
A better commit title is:
postgresql: add optional dependency on libxml2
- The commit log text should be wrapped at 72 characters.
Except these, it looks good. Could you resend an updated version ?
Thanks a lot for your contribution!
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com
PATCH 1/1 postgresql --with-libxml configure option added
Quoted 5 lines · Thomas Petazzoni
Hello Thomas,
Quoted 2 lines · Thomas Ehrhardt
The postgresql package is now built with --with-libxml if
BR2_PACKAGE_LIBXML2is selected to allow the use of XML functions in postgresql.
Quoted 8 lines
Quoted 1 line
Signed-off-by Daniel Deterding <[email protected]>Thanks for your patch, it looks good, but there's one issue: the From doesn't match the Signed-off-by.
If I understand correctly, the patch was done by your colleague Daniel Deterding, and you are sending it on his behalf. If that is correct, then you need to add your own Signed-off-by below the one from Daniel.
And you should also set the author to Daniel, e.g. with
git commit --amend --author="Daniel Deterding <[email protected]>"
Regards,
Arnout
Quoted 21 lines
While you're at it, could you fix the minor issues below (I had fixed them locally as I was about to apply the patch, but realized the Signed-off-by issue) :
- The commit title should have the format:
<package>: <description>
A better commit title is:
postgresql: add optional dependency on libxml2
- The commit log text should be wrapped at 72 characters.
Except these, it looks good. Could you resend an updated version ?
Thanks a lot for your contribution!
Thomas
Signature · 6 lines
Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286500 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
PATCH 1/1 postgresql --with-libxml configure option added
Hello;
Another nitpick I would have is that there should probably be a Config.in entry for this as well.
Quoted 58 lines · Arnout Vandecappelle
Quoted 5 lines · Thomas Petazzoni
Hello Thomas,
Quoted 2 lines · Thomas Ehrhardt
The postgresql package is now built with --with-libxml if
BR2_PACKAGE_LIBXML2is selected to allow the use of XML functions in postgresql.Quoted 8 lines
Quoted 1 line
Signed-off-by Daniel Deterding <[email protected]>Thanks for your patch, it looks good, but there's one issue: the From doesn't match the Signed-off-by.
If I understand correctly, the patch was done by your colleague Daniel Deterding, and you are sending it on his behalf. If that is correct, then you need to add your own Signed-off-by below the one from Daniel.
And you should also set the author to Daniel, e.g. with
git commit --amend --author="Daniel Deterding <[email protected]>"
Regards,
ArnoutQuoted 13 lines
While you're at it, could you fix the minor issues below (I had fixed them locally as I was about to apply the patch, but realized the Signed-off-by issue) :
- The commit title should have the format:
<package>: <description>
A better commit title is:
postgresql: add optional dependency on libxml2
Quoted 8 lines
- The commit log text should be wrapped at 72 characters.
Except these, it looks good. Could you resend an updated version ?
Thanks a lot for your contribution!
Thomas
--
Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286500 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
PATCH 1/1 postgresql --with-libxml configure option added
Hello,
Quoted 2 lines · Adam Duskett
Another nitpick I would have is that there should probably be a Config.in entry for this as well.
No, probably not. As a general rule in Buildroot, we prefer automatic handling of optional dependencies, in order to avoid a proliferation of gazillion of Config.in options. In addition, postgresql.mk already handles all its optional dependencies this way.
The only reason to not do this in this case would be if the XML2 support in postgresql increases significantly the size of the postgresql binary.
But again, in general, automatic handling of optional dependencies is preferred.
Best regards,
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com