drm/i915: Don't call suspend_late() on GEM error load
Subsystems (2)
PATCH 1/1 drm/i915: Don't call suspend_late() on GEM error load
The primary purpose of i915_gem_suspend_late is to ensure all writes into memory from the GPU are flushed before we relinquish control of the device. However, if we abort GEM initialisation, we ideally want to leave the GPU marked as wedged, but still allow KMS in order to avoid the black screen of doom. In this case, a path through suspend_late causes a redundant and quite noisy reset as we have to then repeat it on wedging.
--- drivers/gpu/drm/i915/i915_gem.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/i915/i915_gem.c +2 -2
@@ -5571,8 +5571,6 @@ int i915_gem_init(struct drm_i915_private *dev_priv)mutex_unlock (&dev_priv->drm.struct_mutex);WARN_ON (i915_gem_suspend (dev_priv)); -i915_gem_suspend_late (dev_priv); -i915_gem_drain_workqueue (dev_priv);mutex_lock (&dev_priv->drm.struct_mutex);
@@ -5619,6 +5617,8 @@ int i915_gem_init(struct drm_i915_private *dev_priv)intel_init_clock_gating (dev_priv);mutex_unlock (&dev_priv->drm.struct_mutex); + }else { +i915_gem_sanitize (dev_priv); }i915_gem_drain_freed_objects (dev_priv);
Signature · 6 lines
2.18.0 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✗ Fi.CI.BAT: failure for drm/i915: Don't call suspend_late() on GEM error load
== Series Details ==
== Series Details ==
Series: drm/i915: Don't call suspend_late() on GEM error load
URL : https://patchwork.freedesktop.org/series/47384/
State : failure
== Summary ==
= CI Bug Log - changes from CI_DRM_4578 -> Patchwork_9802 =
== Summary - FAILURE ==
Serious unknown changes coming with Patchwork_9802 absolutely need to be verified manually.
If you think the reported changes have nothing to do with the changes introduced in Patchwork_9802, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.
External URL: https://patchwork.freedesktop.org/api/1.0/series/47384/revisions/1/mbox/
== Possible new issues ==
Here are the unknown changes that may have been introduced in Patchwork_9802:
=== IGT changes ===
==== Possible regressions ====
igt@drv_module_reload@basic-reload-inject:
fi-skl-6260u: PASS -> DMESG-FAIL
fi-snb-2600: PASS -> DMESG-FAIL
fi-byt-j1900: PASS -> DMESG-FAIL
fi-kbl-7560u: PASS -> DMESG-FAIL
fi-kbl-guc: PASS -> DMESG-FAIL
fi-skl-6770hq: PASS -> DMESG-FAIL
fi-byt-n2820: PASS -> DMESG-FAIL
fi-bxt-j4205: PASS -> DMESG-FAIL
fi-bwr-2160: PASS -> DMESG-FAIL
fi-kbl-r: PASS -> DMESG-FAIL
fi-cfl-s3: PASS -> DMESG-FAIL
{fi-cfl-8109u}: PASS -> DMESG-FAIL
fi-snb-2520m: PASS -> DMESG-FAIL
fi-gdg-551: PASS -> DMESG-FAIL
{fi-bsw-kefka}: PASS -> DMESG-FAIL
fi-bdw-gvtdvm: PASS -> DMESG-FAIL
fi-ilk-650: PASS -> DMESG-FAIL
fi-bsw-n3050: PASS -> DMESG-FAIL
fi-kbl-7567u: PASS -> DMESG-FAIL
fi-glk-j4005: PASS -> DMESG-FAIL
{fi-skl-iommu}: PASS -> DMESG-FAIL
fi-bxt-dsi: PASS -> DMESG-FAIL
fi-ivb-3770: PASS -> DMESG-FAIL
fi-skl-gvtdvm: PASS -> DMESG-FAIL
fi-whl-u: PASS -> DMESG-FAIL
fi-skl-6700hq: PASS -> DMESG-FAIL
fi-kbl-7500u: PASS -> DMESG-FAIL
fi-ivb-3520m: PASS -> DMESG-FAIL
fi-hsw-4770: PASS -> DMESG-FAIL
{fi-bdw-samus}: PASS -> DMESG-FAIL
fi-glk-dsi: PASS -> DMESG-FAIL
fi-bdw-5557u: PASS -> DMESG-FAIL
fi-cfl-8700k: PASS -> DMESG-FAIL
fi-hsw-peppy: PASS -> DMESG-FAIL
fi-kbl-x1275: PASS -> DMESG-FAIL
fi-skl-6600u: PASS -> DMESG-FAIL
fi-pnv-d510: PASS -> DMESG-FAIL
fi-hsw-4770r: PASS -> DMESG-FAIL
fi-skl-guc: PASS -> DMESG-FAIL
fi-cfl-guc: PASS -> DMESG-FAIL
fi-blb-e6850: PASS -> DMESG-FAIL
fi-skl-6700k2: PASS -> DMESG-FAIL
fi-elk-e7500: PASS -> DMESG-FAIL
==== Warnings ====
igt@drv_module_reload@basic-reload-inject:
fi-cnl-psr: DMESG-WARN (fdo#105395) -> DMESG-FAIL
igt@drv_selftest@live_contexts:
fi-cfl-s3: PASS -> SKIP +29
igt@drv_selftest@live_dmabuf:
fi-hsw-4770r: PASS -> SKIP +29
igt@drv_selftest@live_evict:
fi-kbl-x1275: PASS -> SKIP +29
igt@drv_selftest@live_gtt:
fi-kbl-guc: PASS -> SKIP +28
fi-gdg-551: PASS -> SKIP +29
igt@drv_selftest@live_guc:
fi-hsw-peppy: PASS -> SKIP +29
{fi-bdw-samus}: PASS -> SKIP +29
igt@drv_selftest@live_hangcheck:
fi-snb-2520m: PASS -> SKIP +29
igt@drv_selftest@live_hugepages:
{fi-cfl-8109u}: PASS -> SKIP +29
igt@drv_selftest@live_objects:
fi-bwr-2160: PASS -> SKIP +29
fi-bdw-5557u: PASS -> SKIP +29
fi-snb-2600: PASS -> SKIP +29
fi-skl-6770hq: PASS -> SKIP +29
igt@drv_selftest@live_requests:
fi-whl-u: PASS -> SKIP +29
fi-skl-gvtdvm: PASS -> SKIP +29
fi-ivb-3520m: PASS -> SKIP +29
fi-skl-guc: PASS -> SKIP +27
igt@drv_selftest@live_sanitycheck:
fi-bdw-gvtdvm: PASS -> SKIP +29
fi-bsw-n3050: PASS -> SKIP +29
igt@drv_selftest@live_uncore:
fi-kbl-7560u: PASS -> SKIP +29
fi-skl-6600u: PASS -> SKIP +29
fi-pnv-d510: PASS -> SKIP +29
igt@drv_selftest@live_workarounds:
fi-kbl-r: PASS -> SKIP +29
igt@drv_selftest@mock_dmabuf:
fi-cfl-8700k: PASS -> SKIP +29
{fi-skl-iommu}: PASS -> SKIP +29
fi-byt-n2820: PASS -> SKIP +29
igt@drv_selftest@mock_engine:
fi-skl-6260u: PASS -> SKIP +29
igt@drv_selftest@mock_evict:
fi-blb-e6850: PASS -> SKIP +29
fi-byt-j1900: PASS -> SKIP +29
igt@drv_selftest@mock_fence:
fi-skl-6700k2: PASS -> SKIP +29
fi-elk-e7500: PASS -> SKIP +29
igt@drv_selftest@mock_hugepages:
fi-glk-j4005: PASS -> SKIP +29
igt@drv_selftest@mock_objects:
fi-bxt-dsi: PASS -> SKIP +29
igt@drv_selftest@mock_requests:
fi-cnl-psr: PASS -> SKIP +15
igt@drv_selftest@mock_sanitycheck:
fi-skl-6700hq: PASS -> SKIP +29
fi-kbl-7500u: PASS -> SKIP +29
fi-hsw-4770: PASS -> SKIP +29
igt@drv_selftest@mock_timelines:
fi-glk-dsi: PASS -> SKIP +29
fi-bxt-j4205: PASS -> SKIP +29
fi-cfl-guc: PASS -> SKIP +28
fi-ivb-3770: PASS -> SKIP +29
igt@drv_selftest@mock_uncore:
fi-ilk-650: PASS -> SKIP +29
fi-kbl-7567u: PASS -> SKIP +29
igt@drv_selftest@mock_vma:
{fi-bsw-kefka}: PASS -> SKIP +29== Known issues ==
Here are the changes found in Patchwork_9802 that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@kms_frontbuffer_tracking@basic:
fi-hsw-peppy: PASS -> DMESG-FAIL (fdo#106103, fdo#102614)
igt@prime_vgem@basic-fence-flip:
fi-ilk-650: PASS -> FAIL (fdo#104008)
==== Possible fixes ====
igt@drv_selftest@live_evict:
fi-cnl-psr: DMESG-WARN (fdo#105395) -> SKIP +12
igt@drv_selftest@live_guc:
fi-skl-guc: DMESG-WARN (fdo#107258, fdo#107175) -> SKIP
fi-cfl-guc: DMESG-WARN (fdo#107258) -> SKIP
fi-kbl-guc: DMESG-WARN (fdo#107258) -> SKIP
igt@drv_selftest@live_hangcheck:
fi-skl-guc: DMESG-FAIL (fdo#107174) -> SKIP
igt@drv_selftest@live_objects:
fi-cnl-psr: DMESG-FAIL (fdo#107398) -> SKIP
{igt@kms_psr@primary_mmap_gtt}:
fi-cnl-psr: DMESG-WARN (fdo#107372) -> PASS
==== Warnings ====
{igt@kms_psr@primary_page_flip}:
fi-cnl-psr: DMESG-WARN (fdo#107372) -> DMESG-FAIL (fdo#107372) {name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
fdo#102614 https://bugs.freedesktop.org/show_bug.cgi?id=102614
fdo#104008 https://bugs.freedesktop.org/show_bug.cgi?id=104008
fdo#105395 https://bugs.freedesktop.org/show_bug.cgi?id=105395
fdo#106103 https://bugs.freedesktop.org/show_bug.cgi?id=106103
fdo#107174 https://bugs.freedesktop.org/show_bug.cgi?id=107174
fdo#107175 https://bugs.freedesktop.org/show_bug.cgi?id=107175
fdo#107258 https://bugs.freedesktop.org/show_bug.cgi?id=107258
fdo#107372 https://bugs.freedesktop.org/show_bug.cgi?id=107372
fdo#107398 https://bugs.freedesktop.org/show_bug.cgi?id=107398
== Participating hosts (50 -> 45) ==
Missing (5): fi-byt-clapper fi-ilk-m540 fi-byt-squawks fi-bsw-cyan fi-hsw-4200u
== Build changes ==
* Linux: CI_DRM_4578 -> Patchwork_9802
CI_DRM_4578: c8e954e4441f1a2b09f9a655b909f6f4f05ce980 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4580: f1c868dae24056ebc27e4f3c197724ce9b956a8a @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_9802: d22c694470a05fb36a83c9fbe4e1d556247d2c20 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
d22c694470a0 drm/i915: Don't call suspend_late() on GEM error load
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_9802/issues.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: ✗ Fi.CI.BAT: failure for drm/i915: Don't call suspend_late() on GEM error load
Quoting Patchwork (2018-07-28 14:08:35)
Quoted 65 lines
== Series Details ==
Series: drm/i915: Don't call
suspend_late()on GEM error load
URL : https://patchwork.freedesktop.org/series/47384/
State : failure== Summary ==
= CI Bug Log - changes from
CI_DRM_4578->Patchwork_9802=== Summary - FAILURE ==
Serious unknown changes coming with
Patchwork_9802absolutely need to be verified manually.If you think the reported changes have nothing to do with the changes introduced in
Patchwork_9802, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.External URL: https://patchwork.freedesktop.org/api/1.0/series/47384/revisions/1/mbox/
== Possible new issues ==
Here are the unknown changes that may have been introduced in
Patchwork_9802:=== IGT changes ===
==== Possible regressions ==== igt@drv_module_reload@basic-reload-inject: fi-skl-6260u: PASS -> DMESG-FAIL fi-snb-2600: PASS -> DMESG-FAIL fi-byt-j1900: PASS -> DMESG-FAIL fi-kbl-7560u: PASS -> DMESG-FAIL fi-kbl-guc: PASS -> DMESG-FAIL fi-skl-6770hq: PASS -> DMESG-FAIL fi-byt-n2820: PASS -> DMESG-FAIL fi-bxt-j4205: PASS -> DMESG-FAIL fi-bwr-2160: PASS -> DMESG-FAIL fi-kbl-r: PASS -> DMESG-FAIL fi-cfl-s3: PASS -> DMESG-FAIL {fi-cfl-8109u}: PASS -> DMESG-FAIL fi-snb-2520m: PASS -> DMESG-FAIL fi-gdg-551: PASS -> DMESG-FAIL {fi-bsw-kefka}: PASS -> DMESG-FAIL fi-bdw-gvtdvm: PASS -> DMESG-FAIL fi-ilk-650: PASS -> DMESG-FAIL fi-bsw-n3050: PASS -> DMESG-FAIL fi-kbl-7567u: PASS -> DMESG-FAIL fi-glk-j4005: PASS -> DMESG-FAIL {fi-skl-iommu}: PASS -> DMESG-FAIL fi-bxt-dsi: PASS -> DMESG-FAIL fi-ivb-3770: PASS -> DMESG-FAIL fi-skl-gvtdvm: PASS -> DMESG-FAIL fi-whl-u: PASS -> DMESG-FAIL fi-skl-6700hq: PASS -> DMESG-FAIL fi-kbl-7500u: PASS -> DMESG-FAIL fi-ivb-3520m: PASS -> DMESG-FAIL fi-hsw-4770: PASS -> DMESG-FAIL {fi-bdw-samus}: PASS -> DMESG-FAIL fi-glk-dsi: PASS -> DMESG-FAIL fi-bdw-5557u: PASS -> DMESG-FAIL fi-cfl-8700k: PASS -> DMESG-FAIL fi-hsw-peppy: PASS -> DMESG-FAIL fi-kbl-x1275: PASS -> DMESG-FAIL
Quoted 8 lines
fi-skl-6600u: PASS -> DMESG-FAIL
fi-pnv-d510: PASS -> DMESG-FAIL
fi-hsw-4770r: PASS -> DMESG-FAIL
fi-skl-guc: PASS -> DMESG-FAIL
fi-cfl-guc: PASS -> DMESG-FAIL
fi-blb-e6850: PASS -> DMESG-FAIL
fi-skl-6700k2: PASS -> DMESG-FAIL
fi-elk-e7500: PASS -> DMESG-FAILSuper annoying. For the moment, we'll just have to put up with the occasional spam if the GPU dies during boot.
-Chris
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx