Skip to contentSkip to conversation

f2fs: fix to clear PG_checked flag in set_page_dirty()

PATCH New Chao Yu 1 participant 1 message Jul 29, 2018 F2FS file system

lore
Share & tools
lore

Chao Yu

author maintainer
#0 lore raw

PATCH 1/1 f2fs: fix to clear PG_checked flag in set_page_dirty()

From: Chao Yu <[email protected]>

PG_checked flag will be set on data page during GC, later, we can recognize such page by the flag and migrate page to cold segment.

But previously, we don't clear this flag when invalidating data page, after page redirtying, we will write it into wrong log.

Let's clear PG_checked flag in set_page_dirty() to avoid this.

Signed-off-by Weichao Guo <[email protected]>
Signed-off-by Chao Yu <[email protected]>
---
 fs/f2fs/data.c | 4 ++++
 1 file changed, 4 insertions(+)
fs/f2fs/data.c +4 -0
index bac667831052..eb994c66fe66 100644
@@ -2549,6 +2549,10 @@ static int f2fs_set_data_page_dirty(struct page *page)
 	if (!PageUptodate(page))
 		SetPageUptodate(page);
 
+	/* don't remain PG_checked flag which was set during GC */
+	if (is_cold_data(page))
+		clear_cold_data(page);
+
 	if (f2fs_is_atomic_file(inode) && !f2fs_is_commit_atomic_write(inode)) {
 		if (!IS_ATOMIC_WRITTEN_PAGE(page)) {
 			f2fs_register_inmem_page(inode, page);
Signature · 6 lines
2.18.0


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot