ext4: use swap macro in mext_page_double_lock
PATCH v2 1/1 ext4: use swap macro in mext_page_double_lock
Make use of the swap macro and remove unnecessary variable *tmp*. This makes the code easier to read and maintain.
This code was detected with the help of Coccinelle.
Signed-off-by Gustavo A. R. Silva <[email protected]>
---
Changes in v2:
- Update changelog. Remove the line claiming that this patch reduces stack usage.
fs/ext4/move_extent.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
fs/ext4/move_extent.c +1 -3
@@ -134,9 +134,7 @@ mext_page_double_lock(struct inode *inode1, struct inode *inode2, mapping[0 ] = inode1->i_mapping; mapping[1 ] = inode2->i_mapping; }else { -pgoff_t tmp = index1; - index1 = index2; - index2 = tmp; +swap (index1, index2); mapping[0 ] = inode2->i_mapping; mapping[1 ] = inode1->i_mapping; }
Signature · 1 line
2.7.4
Quoted 6 lines · Gustavo A. R. Silva
Make use of the swap macro and remove unnecessary variable *tmp*. This makes the code easier to read and maintain.
This code was detected with the help of Coccinelle.
Signed-off-by Gustavo A. R. Silva <[email protected]>
Thanks, applied.
- Ted