Skip to contentSkip to conversation

SH: statx is missing in the kernel

PATCH Christoph Hellwig 1 participant 1 message Jul 30, 2018 SuperH

lore
Share & tools
lore
#0 lore raw

Dear linux-sh maintainers,

can we make sure to at least wire statx for 4.19? That's not going to immediately solve the glibc problem, but at least it won't be prolonged.

Quoted 29 lines · Florian Weimer
Quoted 4 lines · Romain Naour

__NR_statx is not defined by the kernel headers and __ASSUME_STATX is defined since kernel 4.11.

__ASSUME_STATX must be undefined until SH kernel support statx.

Carlos, I would like to check in the attached patch for 2.28. I compile-tested this with build-many-glibcs.py against a 4.11 kernel tree with --enable-kernel=4.13.

I'm preparing another patch for alpha, which still has to undergo testing on kernel 4.13 sources.

Thanks,
Florian

Subject: [PATCH] sh: Do not define __ASSUME_STATX
To: [email protected]

2018-07-24 Florian Weimer <[email protected]>

* sysdeps/unix/sysv/linux/sh/kernel-features.h (__ASSUME_STATX):
Undefine. Suggested by Romain Naour <[email protected]>.

sysdeps/unix/sysv/linux/sh/kernel-features.h +0 -0
index 05b7dcd037..b8ccb01518 100644

sysdeps/unix/sysv/linux/sh/kernel-features.h line 62

Quoted 7 lines
sysdeps/unix/sysv/linux/sh/kernel-features.h +3 -0
@@ -56,4 +56,7 @@
 # undef __ASSUME_RENAMEAT2
 #endif
 
+/* sh does not support the statx system call.  */
+#undef __ASSUME_STATX
+
 #endif

---end quoted text---