Skip to contentSkip to conversation

ndctl, test/monitor: fix inject-smart field in test_filter_dimmevent

PATCH In review Vishal Verma 2 participants 2 messages Jul 30, 2018 – Jul 31, 2018 libnvdimm: non-volatile memory device

lore
Share & tools
lore

Vishal Verma

author maintainer
#0 lore raw

PATCH 1/1 ndctl, test/monitor: fix inject-smart field in test_filter_dimmevent

Change the inject-smart field from -s to -m when testing the dimm-media-temperature event. The -s seems to have been a copy-paste error.

---
 test/monitor.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
test/monitor.sh +1 -1
index 1bbfd14..29d4ea1 100755
@@ -152,7 +152,7 @@ test_filter_dimmevent()
 	inject_value=$($NDCTL list -H -d $monitor_dimms | jq -r .[]."health"."temperature_threshold")
 	inject_value=$((inject_value + 1))
 	start_monitor "-d $monitor_dimms -D dimm-media-temperature"
-	inject_smart "-s $inject_value"
+	inject_smart "-m $inject_value"
 	check_result "$monitor_dimms"
 	stop_monitor
 }
Signature · 6 lines
2.14.4

_______________________________________________
Linux-nvdimm mailing list
[email protected]
https://lists.01.org/mailman/listinfo/linux-nvdimm
#1 lore raw
Quoted 24 lines

-----Original Message-----
From: Vishal Verma [mailto:[email protected]]
Sent: Tuesday, July 31, 2018 4:35 AM
To: [email protected]
Cc: Vishal Verma <[email protected]>; Qi, Fuli/斉 福利 <[email protected]>
Subject: [ndctl PATCH] ndctl, test/monitor: fix inject-smart field in test_filter_dimmevent

Change the inject-smart field from -s to -m when testing the dimm-media-temperature event. The -s seems to have been a copy-paste error.

---
 test/monitor.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

test/monitor.sh test_filter_dimmevent() · line 158

Quoted 9 lines
test/monitor.sh +1 -2
@@ -152,7 +152,7 @@ test_filter_dimmevent()
 	inject_value=$($NDCTL list -H -d $monitor_dimms | jq
-r .[]."health"."temperature_threshold")
 	inject_value=$((inject_value + 1))
 	start_monitor "-d $monitor_dimms -D dimm-media-temperature"
-	inject_smart "-s $inject_value"
+	inject_smart "-m $inject_value"
 	check_result "$monitor_dimms"
 	stop_monitor
 }

Hi Vishal,

Yes, this is a copy-paste error and I am sorry for this.

Thank you very much.
QI

Quoted 4 lines

--
2.14.4

_______________________________________________
Linux-nvdimm mailing list
[email protected]
https://lists.01.org/mailman/listinfo/linux-nvdimm