drm/vkms: Fix vmap_count increment position
Haneen Mohammed
reviewerPATCH 1/1 drm/vkms: Fix vmap_count increment position
Move vmap_count out of the conditional statement since it needs to be updated for every successful call to vkms_gem_vmap.
--- drivers/gpu/drm/vkms/vkms_gem.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/gpu/drm/vkms/vkms_gem.c +1 -2
@@ -240,10 +240,9 @@ int vkms_gem_vmap(struct drm_gem_object *obj) vkms_obj->vaddr =vmap (pages, n_pages,VM_MAP ,PAGE_KERNEL );if (!vkms_obj->vaddr) goto err_vmap; - - vkms_obj->vmap_count++; } + vkms_obj->vmap_count++; goto out; err_vmap:
Signature · 6 lines
2.17.1 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Haneen Mohammed
reviewerQuoted 27 lines · Haneen Mohammed
Move
vmap_countout of the conditional statement since it needs to be updated for every successful call tovkms_gem_vmap.Signed-off-by Haneen Mohammed <[email protected]>--- drivers/gpu/drm/vkms/vkms_gem.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)drivers/gpu/drm/vkms/vkms_gem.c +1
-2@@ -240,10 +240,9 @@ int vkms_gem_vmap(struct drm_gem_object *obj) vkms_obj->vaddr =vmap (pages, n_pages,VM_MAP ,PAGE_KERNEL );if (!vkms_obj->vaddr) goto err_vmap; - - vkms_obj->vmap_count++; } + vkms_obj->vmap_count++; goto out; err_vmap:Signature · 1 line
2.17.1
Hi Sean,
This is a fix to bb112b14af8d ("drm/vkms: Add functions to map/unmap GEM backing storage"), should I add this to the commit message?
Thank you,
Haneen
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Quoted 31 lines · Haneen Mohammed
Quoted 27 lines · Haneen Mohammed
Move
vmap_countout of the conditional statement since it needs to be updated for every successful call tovkms_gem_vmap.Signed-off-by Haneen Mohammed <[email protected]>--- drivers/gpu/drm/vkms/vkms_gem.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)drivers/gpu/drm/vkms/vkms_gem.c +1
-2@@ -240,10 +240,9 @@ int vkms_gem_vmap(struct drm_gem_object *obj) vkms_obj->vaddr =vmap (pages, n_pages,VM_MAP ,PAGE_KERNEL );if (!vkms_obj->vaddr) goto err_vmap; - - vkms_obj->vmap_count++; } + vkms_obj->vmap_count++; goto out; err_vmap:Signature · 1 line
2.17.1Hi Sean,
Quoted 2 lines
This is a fix to
bb112b14af8d("drm/vkms: Add functions to map/unmap GEM backing storage"), should I add this to the commit message?
Yup, usually we include that in a Fixes: tag at the bottom. I've done that while applying, thanks for your patch.
Cheers, Daniel
Signature · 7 lines
Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel