Skip to contentSkip to conversation

package/cutelyst: Fix build dependencies

PATCH New Daniel Nicoletti 2 participants 6 messages Aug 1, 2018

lore
Share & tools
lore

Daniel Nicoletti

author
#0 lore raw

PATCH 1/1 package/cutelyst: Fix build dependencies

Add missing optional dependencies need when
the dependency was available, disabling Grantlee
plugin for now as it failed to build.

Signed-off-by Daniel Nicoletti <[email protected]>
---
 package/cutelyst/cutelyst.mk | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)
package/cutelyst/cutelyst.mk +2 -6
index 438ac091c6..2d1c9b1532 100644
@@ -15,20 +15,16 @@ CUTELYST_DEPENDENCIES = qt5base
 CUTELYST_CONF_OPTS += \
 	-DPLUGIN_CSRFPROTECTION=ON
 
-ifeq ($(BR2_PACKAGE_GRANTLEE),y)
-CUTELYST_CONF_OPTS += -DPLUGIN_VIEW_GRANTLEE=ON
-else
-CUTELYST_CONF_OPTS += -DPLUGIN_VIEW_GRANTLEE=OFF
-endif
-
 ifeq ($(BR2_PACKAGE_LIBPWQUALITY),y)
 CUTELYST_CONF_OPTS += -DPLUGIN_VALIDATOR_PWQUALITY=ON
+CUTELYST_DEPENDENCIES += libpwquality
 else
 CUTELYST_CONF_OPTS += -DPLUGIN_VALIDATOR_PWQUALITY=OFF
 endif
 
 ifeq ($(BR2_PACKAGE_JEMALLOC),y)
 CUTELYST_CONF_OPTS += -DUSE_JEMALLOC=ON
+CUTELYST_DEPENDENCIES += jemalloc
 else
 CUTELYST_CONF_OPTS += -DUSE_JEMALLOC=OFF
 endif
Signature · 1 line
2.17.1
#1 lore raw

PATCH 1/1 package/cutelyst: Fix build dependencies

Hello Daniel,

Thanks for providing this fix!

Quoted 5 lines · Daniel Nicoletti

Add missing optional dependencies need when
the dependency was available, disabling Grantlee
plugin for now as it failed to build.

Signed-off-by Daniel Nicoletti <[email protected]>

I've applied, but after changing one thing:

Quoted 9 lines
---
 package/cutelyst/cutelyst.mk | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)
package/cutelyst/cutelyst.mk +0 -0
index 438ac091c6..2d1c9b1532 100644

package/cutelyst/cutelyst.mk CUTELYST_DEPENDENCIES = qt5base · line 22

Quoted 8 lines
package/cutelyst/cutelyst.mk +0 -5
@@ -15,20 +15,16 @@ CUTELYST_DEPENDENCIES = qt5base
 CUTELYST_CONF_OPTS += \
 	-DPLUGIN_CSRFPROTECTION=ON
 
-ifeq ($(BR2_PACKAGE_GRANTLEE),y)
-CUTELYST_CONF_OPTS += -DPLUGIN_VIEW_GRANTLEE=ON
-else
-CUTELYST_CONF_OPTS += -DPLUGIN_VIEW_GRANTLEE=OFF
-endif

I've kept an unconditional -DPLUGIN_VIEW_GRANTLEE=OFF to make sure that grantlee support is always disabled, even if grantlee gets built/installed before cutelyst.

However, there are other build issues of the cutelyst package which don't seem to be related:

- http://autobuild.buildroot.net/results/b4b/b4bd0807fed721d8f553f1392e7d1fa51545d046/build-end.log

Lots of Qt/C++ errors.

- http://autobuild.buildroot.net/results/555/555cf0cd59c9c832b15c604dae5bad3640f8b450/build-end.log

Doxygen missing. We have a host-doxygen package in Buildroot, but it would be a lot nicer of Cutelyst would not require Doxygen. Any chance to make this optional ? We don't really care about building documentation in the context of Buildroot.

- http://autobuild.buildroot.net/results/771/7716878c3a26b93417188ad7eac91ace172815bb/build-end.log

lrelease not found

Could you have a look at those remaining build issues ?

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
author
#2 lore raw

PATCH 1/1 package/cutelyst: Fix build dependencies

Em qua, 1 de ago de 2018 ?s 09:27, Thomas Petazzoni <[email protected]> escreveu:

Quoted 4 lines

Hello Daniel,

Thanks for providing this fix!

You welcome

Quoted 22 lines · Daniel Nicoletti
Quoted 5 lines

Add missing optional dependencies need when
the dependency was available, disabling Grantlee
plugin for now as it failed to build.

Signed-off-by Daniel Nicoletti <[email protected]>

I've applied, but after changing one thing:

Quoted 12 lines
---
 package/cutelyst/cutelyst.mk | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)
package/cutelyst/cutelyst.mk +0 -0
index 438ac091c6..2d1c9b1532 100644
@@ -15,20 +15,16 @@ CUTELYST_DEPENDENCIES = qt5base
 CUTELYST_CONF_OPTS += \
      -DPLUGIN_CSRFPROTECTION=ON
Quoted 9 lines

package/cutelyst/cutelyst.mk CUTELYST_DEPENDENCIES = qt5base · line 22

Quoted 5 lines
package/cutelyst/cutelyst.mk +0 -5
-ifeq ($(BR2_PACKAGE_GRANTLEE),y)
-CUTELYST_CONF_OPTS += -DPLUGIN_VIEW_GRANTLEE=ON
-else
-CUTELYST_CONF_OPTS += -DPLUGIN_VIEW_GRANTLEE=OFF
-endif

I've kept an unconditional -DPLUGIN_VIEW_GRANTLEE=OFF to make sure that grantlee support is always disabled, even if grantlee gets built/installed before cutelyst.

By default all plugins that require external deps are disabled, but it's harmless anyway

Quoted 7 lines

However, there are other build issues of the cutelyst package which don't seem to be related:

- http://autobuild.buildroot.net/results/b4b/b4bd0807fed721d8f553f1392e7d1fa51545d046/build-end.log

Lots of Qt/C++ errors.

Yeah, I have fixed a few right after the release, as they usually build fine when warnings are not enabled...

Quoted 7 lines

- http://autobuild.buildroot.net/results/555/555cf0cd59c9c832b15c604dae5bad3640f8b450/build-end.log

Doxygen missing. We have a host-doxygen package in Buildroot, but it would be a lot nicer of Cutelyst would not require Doxygen. Any chance to make this optional ? We don't really care about building documentation in the context of Buildroot.

It does not require, it only uses if found and if make docs, I could add a BUILD_DOCS option but it's not very important IMO.

Quoted 14 lines

- http://autobuild.buildroot.net/results/771/7716878c3a26b93417188ad7eac91ace172815bb/build-end.log

lrelease not found

Could you have a look at those remaining build issues ?

Thanks!

Thomas
--
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering
https://bootlin.com

Signature · 3 lines
Daniel Nicoletti

KDE Developer - http://dantti.wordpress.com
author
#3 lore raw

PATCH 1/1 package/cutelyst: Fix build dependencies

Oh, and in this build:
http://autobuild.buildroot.net/results/555/555cf0cd59c9c832b15c604dae5bad3640f8b450/build-end.log

it failed not because of doxygen, but because it could not find libpwquality, I guess it's an old build.
Em qua, 1 de ago de 2018 ?s 09:55, Daniel Nicoletti <[email protected]> escreveu:

Quoted 84 lines

Em qua, 1 de ago de 2018 ?s 09:27, Thomas Petazzoni <[email protected]> escreveu:

Quoted 4 lines

Hello Daniel,

Thanks for providing this fix!

You welcome

Quoted 22 lines · Daniel Nicoletti
Quoted 5 lines

Add missing optional dependencies need when
the dependency was available, disabling Grantlee
plugin for now as it failed to build.

Signed-off-by Daniel Nicoletti <[email protected]>

I've applied, but after changing one thing:

Quoted 12 lines
---
 package/cutelyst/cutelyst.mk | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)
package/cutelyst/cutelyst.mk +0 -0
index 438ac091c6..2d1c9b1532 100644
@@ -15,20 +15,16 @@ CUTELYST_DEPENDENCIES = qt5base
 CUTELYST_CONF_OPTS += \
      -DPLUGIN_CSRFPROTECTION=ON
Quoted 9 lines

package/cutelyst/cutelyst.mk CUTELYST_DEPENDENCIES = qt5base · line 22

Quoted 5 lines
package/cutelyst/cutelyst.mk +0 -5
-ifeq ($(BR2_PACKAGE_GRANTLEE),y)
-CUTELYST_CONF_OPTS += -DPLUGIN_VIEW_GRANTLEE=ON
-else
-CUTELYST_CONF_OPTS += -DPLUGIN_VIEW_GRANTLEE=OFF
-endif

I've kept an unconditional -DPLUGIN_VIEW_GRANTLEE=OFF to make sure that grantlee support is always disabled, even if grantlee gets built/installed before cutelyst.

By default all plugins that require external deps are disabled, but it's harmless anyway

Quoted 7 lines

However, there are other build issues of the cutelyst package which don't seem to be related:

- http://autobuild.buildroot.net/results/b4b/b4bd0807fed721d8f553f1392e7d1fa51545d046/build-end.log

Lots of Qt/C++ errors.

Yeah, I have fixed a few right after the release, as they usually build fine when warnings are not enabled...

Quoted 7 lines

- http://autobuild.buildroot.net/results/555/555cf0cd59c9c832b15c604dae5bad3640f8b450/build-end.log

Doxygen missing. We have a host-doxygen package in Buildroot, but it would be a lot nicer of Cutelyst would not require Doxygen. Any chance to make this optional ? We don't really care about building documentation in the context of Buildroot.

It does not require, it only uses if found and if make docs, I could add a BUILD_DOCS option but it's not very important IMO.

Quoted 7 lines

- http://autobuild.buildroot.net/results/771/7716878c3a26b93417188ad7eac91ace172815bb/build-end.log

lrelease not found

Could you have a look at those remaining build issues ?

Quoted 7 lines

Thanks!

Thomas
--
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering
https://bootlin.com

--
Daniel Nicoletti

KDE Developer - http://dantti.wordpress.com

Signature · 3 lines
Daniel Nicoletti

KDE Developer - http://dantti.wordpress.com
#4 lore raw

PATCH 1/1 package/cutelyst: Fix build dependencies

In reply to Daniel Nicoletti

Hello,

Quoted 8 lines · Daniel Nicoletti
Quoted 6 lines

However, there are other build issues of the cutelyst package which don't seem to be related:

- http://autobuild.buildroot.net/results/b4b/b4bd0807fed721d8f553f1392e7d1fa51545d046/build-end.log

Lots of Qt/C++ errors.

Yeah, I have fixed a few right after the release, as they usually build fine when warnings are not enabled...

I'm not sure what you mean here. These errors still occur in the autobuilders. Do we need to bump the cutelyst version ?

Quoted 8 lines
Quoted 6 lines

- http://autobuild.buildroot.net/results/555/555cf0cd59c9c832b15c604dae5bad3640f8b450/build-end.log

Doxygen missing. We have a host-doxygen package in Buildroot, but it would be a lot nicer of Cutelyst would not require Doxygen. Any chance to make this optional ? We don't really care about building documentation in the context of Buildroot.

It does not require, it only uses if found and if make docs, I could add a BUILD_DOCS option but it's not very important IMO.

So according to your next e-mail, this failure is not due to lrelease/doxygen missing, but only because libpwquality could not be found ?

Best regards,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
author
#5 lore raw

PATCH 1/1 package/cutelyst: Fix build dependencies

Em qua, 1 de ago de 2018 ?s 10:06, Thomas Petazzoni <[email protected]> escreveu:

Quoted 8 lines

Hello,

Quoted 3 lines · Daniel Nicoletti
Quoted 3 lines

However, there are other build issues of the cutelyst package which don't seem to be related:

Quoted 8 lines
Quoted 5 lines
Quoted 3 lines

- http://autobuild.buildroot.net/results/b4b/b4bd0807fed721d8f553f1392e7d1fa51545d046/build-end.log

Lots of Qt/C++ errors.

Yeah, I have fixed a few right after the release, as they usually build fine when warnings are not enabled...

I'm not sure what you mean here. These errors still occur in the autobuilders. Do we need to bump the cutelyst version ?

Yes, I'll probably do a point release due that error, it's just one besides the huge g++ output...

Quoted 7 lines
Quoted 7 lines
Quoted 7 lines

- http://autobuild.buildroot.net/results/555/555cf0cd59c9c832b15c604dae5bad3640f8b450/build-end.log

Doxygen missing. We have a host-doxygen package in Buildroot, but it would be a lot nicer of Cutelyst would not require Doxygen. Any chance to make this optional ? We don't really care about building documentation in the context of Buildroot.

Quoted 6 lines
Quoted 2 lines

It does not require, it only uses if found and if make docs, I could add a BUILD_DOCS option but it's not very important IMO.

So according to your next e-mail, this failure is not due to lrelease/doxygen missing, but only because libpwquality could not be found ?

yes, otherwise the other link wouldn't had issues at compilation time.

Quoted 8 lines

Best regards,

Thomas
--
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering
https://bootlin.com

Signature · 3 lines
Daniel Nicoletti

KDE Developer - http://dantti.wordpress.com