Skip to contentSkip to conversation

ethdev: ownership change log message priority change

PATCH In review Stephen Hemminger 3 participants 3 messages Aug 1, 2018 – Aug 2, 2018

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ethdev: ownership change log message priority change

Changing ownership of a port is a normal event, and should not be logged at ERR priority. Downgrade to a DEBUG message.

---
 lib/librte_ethdev/rte_ethdev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
lib/librte_ethdev/rte_ethdev.c +1 -1
index 2e40c3fba99a..c7ab15722f98 100644
@@ -463,7 +463,7 @@ _rte_eth_dev_owner_set(const uint16_t port_id, const uint64_t old_owner_id,
 
 	port_owner->id = new_owner->id;
 
-	RTE_ETHDEV_LOG(ERR, "Port %u owner is %s_%016"PRIx64"\n",
+	RTE_ETHDEV_LOG(DEBUG, "Port %u owner is %s_%016"PRIx64"\n",
 		port_id, new_owner->name, new_owner->id);
 
 	return 0;
Signature · 1 line
2.18.0
Acked-by on v1 1/1
#1 lore raw

From: Stephen Hemminger

Quoted 4 lines

Changing ownership of a port is a normal event, and should not be logged at ERR priority. Downgrade to a DEBUG message.

Quoted 20 lines
---
 lib/librte_ethdev/rte_ethdev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
lib/librte_ethdev/rte_ethdev.c +1 -1
index 2e40c3fba99a..c7ab15722f98 100644
@@ -463,7 +463,7 @@ _rte_eth_dev_owner_set(const uint16_t port_id, const
 uint64_t old_owner_id,
 
 	port_owner->id = new_owner->id;
 
-	RTE_ETHDEV_LOG(ERR, "Port %u owner is %s_%016"PRIx64"\n",
+	RTE_ETHDEV_LOG(DEBUG, "Port %u owner is %s_%016"PRIx64"\n",
 		port_id, new_owner->name, new_owner->id);
 

return 0;
--
2.18.0

#2 lore raw

02/08/2018 08:40, Matan Azrad:

Quoted 7 lines

From: Stephen Hemminger

Quoted 4 lines

Changing ownership of a port is a normal event, and should not be logged at ERR priority. Downgrade to a DEBUG message.

Fixes bea1e0c70cfc ("ethdev: convert static log type usage to dynamic")

Applied with this title:
ethdev: decrease log level of ownership change