Skip to contentSkip to conversation

Convert CONFIG_USB_ULPI_TIMEOUT to Kconfig

PATCH New Adam Ford 2 participants 3 messages Aug 2, 2018 USB

lore
Share & tools
lore

Adam Ford

author
#0 lore raw

PATCH 1/1 Convert CONFIG_USB_ULPI_TIMEOUT to Kconfig

This converts the following to Kconfig:
CONFIG_USB_ULPI_TIMEOUT

Signed-off-by Adam Ford <[email protected]>
drivers/usb/ulpi/Kconfig +6 -0
index 001564d40c..d0eff66e1c 100644
@@ -30,3 +30,9 @@ config USB_ULPI
 	  PHY Transreceiver for USB controllers.
 
 	  This driver uses ULPI viewports that are specific for each SoC.
+
+config USB_ULPI_TIMEOUT
+	int "ULPI Timeout (us)"
+	default 1000 if USB_ULPI
+	help
+	  Select the UPLI timeout in microseconds
include/usb/ulpi.h +0 -4
index 71642d257b..00cc60190b 100644
@@ -20,10 +20,6 @@
 
 #define ULPI_ERROR	(1 << 8) /* overflow from any register value */
 
-#ifndef CONFIG_USB_ULPI_TIMEOUT
-#define CONFIG_USB_ULPI_TIMEOUT 1000	/* timeout in us */
-#endif
-
 /*
  * ulpi view port address and
  * Port_number that can be passed.
scripts/config_whitelist.txt +0 -1
index 7ced4099f2..8f6a1e3f7f 100644
@@ -4666,7 +4666,6 @@ CONFIG_USB_SS_BASE
 CONFIG_USB_TI_CPPI_DMA
 CONFIG_USB_TTY
 CONFIG_USB_TUSB_OMAP_DMA
-CONFIG_USB_ULPI_TIMEOUT
 CONFIG_USB_XHCI_EXYNOS
 CONFIG_USB_XHCI_KEYSTONE
 CONFIG_USB_XHCI_OMAP
Signature · 1 line
2.17.1
#1 lore raw

PATCH 1/1 Convert CONFIG_USB_ULPI_TIMEOUT to Kconfig

Quoted 10 lines · Adam Ford

This converts the following to Kconfig:
CONFIG_USB_ULPI_TIMEOUT

Signed-off-by Adam Ford <[email protected]>
drivers/usb/ulpi/Kconfig +0 -0
index 001564d40c..d0eff66e1c 100644

drivers/usb/ulpi/Kconfig config USB_ULPI · line 36

Quoted 7 lines
drivers/usb/ulpi/Kconfig +4 -0
@@ -30,3 +30,9 @@ config USB_ULPI
 	  PHY Transreceiver for USB controllers.
 
 	  This driver uses ULPI viewports that are specific for each SoC.
+
+config USB_ULPI_TIMEOUT
+	int "ULPI Timeout (us)"
+	default 1000 if USB_ULPI

Shouldn't this depend on USB_ULPI ?

Quoted 30 lines
drivers/usb/ulpi/Kconfig +2 -0
+	help
+	  Select the UPLI timeout in microseconds
include/usb/ulpi.h +0 -4
index 71642d257b..00cc60190b 100644
@@ -20,10 +20,6 @@
 
 #define ULPI_ERROR	(1 << 8) /* overflow from any register value */
 
-#ifndef CONFIG_USB_ULPI_TIMEOUT
-#define CONFIG_USB_ULPI_TIMEOUT 1000	/* timeout in us */
-#endif
-
 /*
  * ulpi view port address and
  * Port_number that can be passed.
scripts/config_whitelist.txt +0 -1
index 7ced4099f2..8f6a1e3f7f 100644
@@ -4666,7 +4666,6 @@ CONFIG_USB_SS_BASE
 CONFIG_USB_TI_CPPI_DMA
 CONFIG_USB_TTY
 CONFIG_USB_TUSB_OMAP_DMA
-CONFIG_USB_ULPI_TIMEOUT
 CONFIG_USB_XHCI_EXYNOS
 CONFIG_USB_XHCI_KEYSTONE
 CONFIG_USB_XHCI_OMAP
Signature · 2 lines
Best regards,
Marek Vasut
author
#2 lore raw

PATCH 1/1 Convert CONFIG_USB_ULPI_TIMEOUT to Kconfig

Quoted 14 lines · Marek Vasut
Quoted 12 lines · Adam Ford

This converts the following to Kconfig:
CONFIG_USB_ULPI_TIMEOUT

Signed-off-by Adam Ford <[email protected]>
drivers/usb/ulpi/Kconfig +0 -0
index 001564d40c..d0eff66e1c 100644
@@ -30,3 +30,9 @@ config USB_ULPI
        PHY Transreceiver for USB controllers.
Quoted 7 lines

drivers/usb/ulpi/Kconfig config USB_ULPI · line 36

Quoted 5 lines
drivers/usb/ulpi/Kconfig +4 -0
        This driver uses ULPI viewports that are specific for each SoC.
+
+config USB_ULPI_TIMEOUT
+     int "ULPI Timeout (us)"
+     default 1000 if USB_ULPI

Shouldn't this depend on USB_ULPI ?

Oops, my bad.

V2 coming now.

adam

Quoted 36 lines
Quoted 24 lines
drivers/usb/ulpi/Kconfig +2 -0
+     help
+       Select the UPLI timeout in microseconds
include/usb/ulpi.h +0 -4
index 71642d257b..00cc60190b 100644
@@ -20,10 +20,6 @@
 
 #define ULPI_ERROR   (1 << 8) /* overflow from any register value */
 
-#ifndef CONFIG_USB_ULPI_TIMEOUT
-#define CONFIG_USB_ULPI_TIMEOUT 1000 /* timeout in us */
-#endif
-
 /*
  * ulpi view port address and
  * Port_number that can be passed.
scripts/config_whitelist.txt +0 -0
index 7ced4099f2..8f6a1e3f7f 100644

scripts/config_whitelist.txt CONFIG_USB_SS_BASE · line 4671

Quoted 7 lines
scripts/config_whitelist.txt +0 -1
@@ -4666,7 +4666,6 @@ CONFIG_USB_SS_BASE
 CONFIG_USB_TI_CPPI_DMA
 CONFIG_USB_TTY
 CONFIG_USB_TUSB_OMAP_DMA
-CONFIG_USB_ULPI_TIMEOUT
 CONFIG_USB_XHCI_EXYNOS
 CONFIG_USB_XHCI_KEYSTONE
 CONFIG_USB_XHCI_OMAP

--
Best regards,
Marek Vasut