drm/amd/display: Only require EDID read for HDMI and DVI
Subsystems (3)
PATCH 1/1 drm/amd/display: Only require EDID read for HDMI and DVI
[Why]
VGA sometimes has trouble retrieving the EDID on very long cables, KVM switches, or old displays.
[How]
Only require EDID read for HDMI and DVI and exempt other types (DP, VGA). We currently don't support VGA but if anyone adds support in the future this might get overlooked.
--- drivers/gpu/drm/amd/display/dc/core/dc_link.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/gpu/drm/amd/display/dc/core/dc_link.c +2 -1
@@ -753,7 +753,8 @@ bool dc_link_detect(struct dc_link *link, enum dc_detect_reason reason)* even if we have no EDID in order to go to * fail-safe mode */ -if (!dc_is_dp_signal (link->connector_signal)) +if (dc_is_hdmi_signal (link->connector_signal) || +dc_is_dvi_signal (link->connector_signal))return false;default :break ;
Signature · 6 lines
2.17.1 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
A message that is not in the archive (sent off-list or not yet received): 20180802193839.4339-1-harry.wentland-5C7GfCeVMHo@public.gmane.org
Alex Deucher
Acked-byQuoted 11 lines · Harry Wentland
[Why]
VGA sometimes has trouble retrieving the EDID on very long cables, KVM switches, or old displays.[How]
Only require EDID read for HDMI and DVI and exempt other types (DP, VGA). We currently don't support VGA but if anyone adds support in the future this might get overlooked.Signed-off-by Harry Wentland <[email protected]>Suggested-by Michel Dänzer <[email protected]>
Quoted 21 lines
--- drivers/gpu/drm/amd/display/dc/core/dc_link.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)drivers/gpu/drm/amd/display/dc/core/dc_link.c +2
-2@@ -753,7 +753,8 @@ bool dc_link_detect(struct dc_link *link, enum dc_detect_reason reason)* even if we have no EDID in order to go to * fail-safe mode */ -if (!dc_is_dp_signal (link->connector_signal)) +if (dc_is_hdmi_signal (link->connector_signal) || +dc_is_dvi_signal (link->connector_signal))return false;default :break ; --2.17.1
Quoted 4 lines
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Nicholas Kazlauskas
Reviewed-byQuoted 21 lines · Harry Wentland
[Why]
VGA sometimes has trouble retrieving the EDID on very long cables, KVM switches, or old displays.[How]
Only require EDID read for HDMI and DVI and exempt other types (DP, VGA). We currently don't support VGA but if anyone adds support in the future this might get overlooked.Signed-off-by Harry Wentland <[email protected]>Suggested-by Michel Dänzer <[email protected]>--- drivers/gpu/drm/amd/display/dc/core/dc_link.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)drivers/gpu/drm/amd/display/dc/core/dc_link.c +0
-0
drivers/gpu/drm/amd/display/dc/core/dc_link.c bool dc_link_detect(struct dc_link *link, enum dc_detect_reason reason) · line 760
Quoted 9 lines
drivers/gpu/drm/amd/display/dc/core/dc_link.c +2
-1@@ -753,7 +753,8 @@ bool dc_link_detect(struct dc_link *link, enum dc_detect_reason reason)* even if we have no EDID in order to go to * fail-safe mode */ -if (!dc_is_dp_signal (link->connector_signal)) +if (dc_is_hdmi_signal (link->connector_signal) || +dc_is_dvi_signal (link->connector_signal))return false;default :break ;
Looks good. Fixing the indenting or merging the conditions would be a good idea, however.
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx