mlx5: spelling fixes
PATCH 1/1 mlx5: spelling fixes
Fix spelling errors in messages and comments.
Signed-off-by Stephen Hemminger <[email protected]>
--- drivers/net/mlx5/mlx5_ethdev.c | 2 +- drivers/net/mlx5/mlx5_flow.c | 4 ++-- drivers/net/mlx5/mlx5_mr.c | 8 ++++---- drivers/net/mlx5/mlx5_rxq.c | 20 ++++++++++---------- drivers/net/mlx5/mlx5_rxtx.c | 2 +- 5 files changed, 18 insertions(+), 18 deletions(-)
drivers/net/mlx5/mlx5_ethdev.c +1 -1
@@ -1138,7 +1138,7 @@ mlx5_dev_interrupt_handler_install(struct rte_eth_dev *dev) } ret =mlx5_socket_init (dev);if (ret) -DRV_LOG (ERR ,"port %u cannot initialise socket: %s" , +DRV_LOG (ERR ,"port %u cannot initialize socket: %s" , dev->data->port_id,strerror (rte_errno));else if (priv->primary_socket) { priv->intr_handle_socket.fd = priv->primary_socket;
drivers/net/mlx5/mlx5_flow.c +2 -2
@@ -1090,7 +1090,7 @@ mlx5_flow_item_ipv6(const struct rte_flow_item *item, struct rte_flow *flow, item, "L3 cannot follow an L4 layer.");/* -* IPv6 is not recognised by the NIC inside a GRE tunnel. +* IPv6 is not recognized by the NIC inside a GRE tunnel. * Such support has to be disabled as the rule will be * accepted. Issue reproduced with Mellanox OFED 4.3-3.0.2.1 and * Mellanox OFED 4.4-1.0.0.0.
@@ -1100,7 +1100,7 @@ mlx5_flow_item_ipv6(const struct rte_flow_item *item, struct rte_flow *flow,RTE_FLOW_ERROR_TYPE_ITEM , item,"IPv6 inside a GRE tunnel is" - " not recognised."); + " not recognized.");if (!mask) mask = &rte_flow_item_ipv6_mask; ret = mlx5_flow_item_acceptable
drivers/net/mlx5/mlx5_mr.c +4 -4
@@ -446,7 +446,7 @@ mr_free(struct mlx5_mr *mr) }/** -* Releass resources of detached MR having no online entry. +* Release resources of detached MR having no online entry. * * @param dev * Pointer to Ethernet device.
@@ -496,7 +496,7 @@ mr_find_contig_memsegs_cb(const struct rte_memseg_list *msl, }/** -* Create a new global Memroy Region (MR) for a missing virtual address. +* Create a new global Memory Region (MR) for a missing virtual address. * Register entire virtually contiguous memory chunk around the address. * * @param dev
@@ -553,7 +553,7 @@ mlx5_mr_create(struct rte_eth_dev *dev, struct mlx5_mr_cache *entry,* Find out a contiguous virtual address chunk in use, to which the * given address belongs, in order to register maximum range. In the * best case where mempools are not dynamically recreated and -* '--socket-mem' is speicified as an EAL option, it is very likely to +* '--socket-mem' is specified as an EAL option, it is very likely to * have only one MR(LKey) per a socket and per a hugepage-size even * though the system memory is highly fragmented. */
@@ -604,7 +604,7 @@ mlx5_mr_create(struct rte_eth_dev *dev, struct mlx5_mr_cache *entry, bmp_mem =RTE_PTR_ALIGN_CEIL (mr +1 ,RTE_CACHE_LINE_SIZE ); mr->ms_bmp =rte_bitmap_init (ms_n, bmp_mem, bmp_size);if (mr->ms_bmp ==NULL ) { -DEBUG ("port %u unable to initialize bitamp for a new MR of" +DEBUG ("port %u unable to initialize bitmap for a new MR of" " address (%p)." , dev->data->port_id, (void *)addr); rte_errno =EINVAL ;
drivers/net/mlx5/mlx5_rxq.c +10 -10
@@ -751,7 +751,7 @@ mlx5_rx_intr_disable(struct rte_eth_dev *dev, uint16_t rx_queue_id)* Queue index in DPDK Rx queue array * * @return -* The Verbs object initialised, NULL otherwise and rte_errno is set. +* The Verbs object initialized, NULL otherwise and rte_errno is set. */ struct mlx5_rxq_ibv *mlx5_rxq_ibv_new (struct rte_eth_dev *dev,uint16_t idx)
@@ -1179,7 +1179,7 @@ mlx5_mprq_free_mp(struct rte_eth_dev *dev)/** * Allocate a mempool for Multi-Packet RQ. All configured Rx queues share the -* mempool. If already allocated, reuse it if there're enough elements. +* mempool. If already allocated, reuse it if there are enough elements. * Otherwise, resize it. * * @param dev
@@ -1234,7 +1234,7 @@ mlx5_mprq_alloc_mp(struct rte_eth_dev *dev)*/ desc *=4 ; obj_num = desc +MLX5_MPRQ_MP_CACHE_SZ * priv->rxqs_n; -/* Check a mempool is already allocated and if it can be resued. */ +/* Check a mempool is already allocated and if it can be reused. */ if (mp !=NULL && mp->elt_size >= obj_size && mp->size >= obj_num) {DRV_LOG (DEBUG ,"port %u mempool %s is being reused" , dev->data->port_id, mp->name);
@@ -1583,7 +1583,7 @@ mlx5_rxq_verify(struct rte_eth_dev *dev)* Number of queues in the array. * * @return -* The Verbs object initialised, NULL otherwise and rte_errno is set. +* The Verbs object initialized, NULL otherwise and rte_errno is set. */ struct mlx5_ind_table_ibv * mlx5_ind_table_ibv_new(struct rte_eth_dev *dev, const uint16_t *queues,
@@ -1613,7 +1613,7 @@ mlx5_ind_table_ibv_new(struct rte_eth_dev *dev, const uint16_t *queues, ind_tbl->queues[i] = queues[i]; } ind_tbl->queues_n = queues_n; -/* Finalise indirection table. */ +/* Finalize indirection table. */ for (j =0 ; i != (unsigned int )(1 << wq_n); ++i, ++j) wq[i] = wq[j]; ind_tbl->ind_table = mlx5_glue->create_rwq_ind_table
@@ -1746,7 +1746,7 @@ mlx5_ind_table_ibv_verify(struct rte_eth_dev *dev)* Number of queues. * * @return -* The Verbs object initialised, NULL otherwise and rte_errno is set. +* The Verbs object initialized, NULL otherwise and rte_errno is set. */ struct mlx5_hrxq * mlx5_hrxq_new(struct rte_eth_dev *dev,
@@ -1950,7 +1950,7 @@ mlx5_hrxq_ibv_verify(struct rte_eth_dev *dev)* Pointer to Ethernet device. * * @return -* The Verbs object initialised, NULL otherwise and rte_errno is set. +* The Verbs object initialized, NULL otherwise and rte_errno is set. */ struct mlx5_rxq_ibv *mlx5_rxq_ibv_drop_new (struct rte_eth_dev *dev)
@@ -2009,7 +2009,7 @@ mlx5_rxq_ibv_drop_new(struct rte_eth_dev *dev)* Pointer to Ethernet device. * * @return -* The Verbs object initialised, NULL otherwise and rte_errno is set. +* The Verbs object initialized, NULL otherwise and rte_errno is set. */ void mlx5_rxq_ibv_drop_release (struct rte_eth_dev *dev)
@@ -2032,7 +2032,7 @@ mlx5_rxq_ibv_drop_release(struct rte_eth_dev *dev)* Pointer to Ethernet device. * * @return -* The Verbs object initialised, NULL otherwise and rte_errno is set. +* The Verbs object initialized, NULL otherwise and rte_errno is set. */ struct mlx5_ind_table_ibv *mlx5_ind_table_ibv_drop_new (struct rte_eth_dev *dev)
@@ -2096,7 +2096,7 @@ mlx5_ind_table_ibv_drop_release(struct rte_eth_dev *dev)* Pointer to Ethernet device. * * @return -* The Verbs object initialised, NULL otherwise and rte_errno is set. +* The Verbs object initialized, NULL otherwise and rte_errno is set. */ struct mlx5_hrxq *mlx5_hrxq_drop_new (struct rte_eth_dev *dev)
drivers/net/mlx5/mlx5_rxtx.c +1 -1
@@ -1507,7 +1507,7 @@ txq_burst_empw(struct mlx5_txq_data *txq, struct rte_mbuf **pkts, mpw.wqe->eseg.cs_flags = cs_flags; }else {/* Evaluate whether the next packet can be inlined. -* Inlininig is possible when: +* Inlining is possible when: * - length is less than configured value * - length fits for remaining space * - not required to fill the title WQEBB with dsegs
Signature · 1 line
2.18.0
Quoted 4 lines · Stephen Hemminger
Fix spelling errors in messages and comments.
Signed-off-by Stephen Hemminger <[email protected]>---
Hi Stephen,
'initialise' is accepted, not a typo. AFAIK, it is 'British' way. Same for 'recognised' and 'finalise'. I don't want to enforce people to use 'non-Britain' English for mlx5 PMD. :-)
Other than those, thanks for correcting typos.
Please send out v2.
Thanks,
Yongseok
Quoted 192 lines
drivers/net/mlx5/mlx5_ethdev.c | 2 +- drivers/net/mlx5/mlx5_flow.c | 4 ++-- drivers/net/mlx5/mlx5_mr.c | 8 ++++---- drivers/net/mlx5/mlx5_rxq.c | 20 ++++++++++---------- drivers/net/mlx5/mlx5_rxtx.c | 2 +- 5 files changed, 18 insertions(+), 18 deletions(-)drivers/net/mlx5/mlx5_ethdev.c +1
-1@@ -1138,7 +1138,7 @@ mlx5_dev_interrupt_handler_install(struct rte_eth_dev *dev) } ret =mlx5_socket_init (dev);if (ret) -DRV_LOG (ERR ,"port %u cannot initialise socket: %s" , +DRV_LOG (ERR ,"port %u cannot initialize socket: %s" , dev->data->port_id,strerror (rte_errno));else if (priv->primary_socket) { priv->intr_handle_socket.fd = priv->primary_socket;drivers/net/mlx5/mlx5_flow.c +2
-2@@ -1090,7 +1090,7 @@ mlx5_flow_item_ipv6(const struct rte_flow_item *item, struct rte_flow *flow, item, "L3 cannot follow an L4 layer.");/* -* IPv6 is not recognised by the NIC inside a GRE tunnel. +* IPv6 is not recognized by the NIC inside a GRE tunnel. * Such support has to be disabled as the rule will be * accepted. Issue reproduced with Mellanox OFED 4.3-3.0.2.1 and * Mellanox OFED 4.4-1.0.0.0. @@ -1100,7 +1100,7 @@ mlx5_flow_item_ipv6(const struct rte_flow_item *item, struct rte_flow *flow,RTE_FLOW_ERROR_TYPE_ITEM , item,"IPv6 inside a GRE tunnel is" - " not recognised."); + " not recognized.");if (!mask) mask = &rte_flow_item_ipv6_mask; ret = mlx5_flow_item_acceptabledrivers/net/mlx5/mlx5_mr.c +4
-4@@ -446,7 +446,7 @@ mr_free(struct mlx5_mr *mr) }/** -* Releass resources of detached MR having no online entry. +* Release resources of detached MR having no online entry. * * @param dev * Pointer to Ethernet device. @@ -496,7 +496,7 @@ mr_find_contig_memsegs_cb(const struct rte_memseg_list *msl, }/** -* Create a new global Memroy Region (MR) for a missing virtual address. +* Create a new global Memory Region (MR) for a missing virtual address. * Register entire virtually contiguous memory chunk around the address. * * @param dev @@ -553,7 +553,7 @@ mlx5_mr_create(struct rte_eth_dev *dev, struct mlx5_mr_cache *entry,* Find out a contiguous virtual address chunk in use, to which the * given address belongs, in order to register maximum range. In the * best case where mempools are not dynamically recreated and -* '--socket-mem' is speicified as an EAL option, it is very likely to +* '--socket-mem' is specified as an EAL option, it is very likely to * have only one MR(LKey) per a socket and per a hugepage-size even * though the system memory is highly fragmented. */ @@ -604,7 +604,7 @@ mlx5_mr_create(struct rte_eth_dev *dev, struct mlx5_mr_cache *entry, bmp_mem =RTE_PTR_ALIGN_CEIL (mr +1 ,RTE_CACHE_LINE_SIZE ); mr->ms_bmp =rte_bitmap_init (ms_n, bmp_mem, bmp_size);if (mr->ms_bmp ==NULL ) { -DEBUG ("port %u unable to initialize bitamp for a new MR of" +DEBUG ("port %u unable to initialize bitmap for a new MR of" " address (%p)." , dev->data->port_id, (void *)addr); rte_errno =EINVAL ;drivers/net/mlx5/mlx5_rxq.c +10
-10@@ -751,7 +751,7 @@ mlx5_rx_intr_disable(struct rte_eth_dev *dev, uint16_t rx_queue_id)* Queue index in DPDK Rx queue array * * @return -* The Verbs object initialised, NULL otherwise and rte_errno is set. +* The Verbs object initialized, NULL otherwise and rte_errno is set. */ struct mlx5_rxq_ibv *mlx5_rxq_ibv_new (struct rte_eth_dev *dev,uint16_t idx)@@ -1179,7 +1179,7 @@ mlx5_mprq_free_mp(struct rte_eth_dev *dev)/** * Allocate a mempool for Multi-Packet RQ. All configured Rx queues share the -* mempool. If already allocated, reuse it if there're enough elements. +* mempool. If already allocated, reuse it if there are enough elements. * Otherwise, resize it. * * @param dev @@ -1234,7 +1234,7 @@ mlx5_mprq_alloc_mp(struct rte_eth_dev *dev)*/ desc *=4 ; obj_num = desc +MLX5_MPRQ_MP_CACHE_SZ * priv->rxqs_n; -/* Check a mempool is already allocated and if it can be resued. */ +/* Check a mempool is already allocated and if it can be reused. */ if (mp !=NULL && mp->elt_size >= obj_size && mp->size >= obj_num) {DRV_LOG (DEBUG ,"port %u mempool %s is being reused" , dev->data->port_id, mp->name);@@ -1583,7 +1583,7 @@ mlx5_rxq_verify(struct rte_eth_dev *dev)* Number of queues in the array. * * @return -* The Verbs object initialised, NULL otherwise and rte_errno is set. +* The Verbs object initialized, NULL otherwise and rte_errno is set. */ struct mlx5_ind_table_ibv * mlx5_ind_table_ibv_new(struct rte_eth_dev *dev, const uint16_t *queues,@@ -1613,7 +1613,7 @@ mlx5_ind_table_ibv_new(struct rte_eth_dev *dev, const uint16_t *queues, ind_tbl->queues[i] = queues[i]; } ind_tbl->queues_n = queues_n; -/* Finalise indirection table. */ +/* Finalize indirection table. */ for (j =0 ; i != (unsigned int )(1 << wq_n); ++i, ++j) wq[i] = wq[j]; ind_tbl->ind_table = mlx5_glue->create_rwq_ind_table@@ -1746,7 +1746,7 @@ mlx5_ind_table_ibv_verify(struct rte_eth_dev *dev)* Number of queues. * * @return -* The Verbs object initialised, NULL otherwise and rte_errno is set. +* The Verbs object initialized, NULL otherwise and rte_errno is set. */ struct mlx5_hrxq * mlx5_hrxq_new(struct rte_eth_dev *dev,@@ -1950,7 +1950,7 @@ mlx5_hrxq_ibv_verify(struct rte_eth_dev *dev)* Pointer to Ethernet device. * * @return -* The Verbs object initialised, NULL otherwise and rte_errno is set. +* The Verbs object initialized, NULL otherwise and rte_errno is set. */ struct mlx5_rxq_ibv *mlx5_rxq_ibv_drop_new (struct rte_eth_dev *dev)@@ -2009,7 +2009,7 @@ mlx5_rxq_ibv_drop_new(struct rte_eth_dev *dev)* Pointer to Ethernet device. * * @return -* The Verbs object initialised, NULL otherwise and rte_errno is set. +* The Verbs object initialized, NULL otherwise and rte_errno is set. */ void mlx5_rxq_ibv_drop_release (struct rte_eth_dev *dev)@@ -2032,7 +2032,7 @@ mlx5_rxq_ibv_drop_release(struct rte_eth_dev *dev)* Pointer to Ethernet device. * * @return -* The Verbs object initialised, NULL otherwise and rte_errno is set. +* The Verbs object initialized, NULL otherwise and rte_errno is set. */ struct mlx5_ind_table_ibv *mlx5_ind_table_ibv_drop_new (struct rte_eth_dev *dev)@@ -2096,7 +2096,7 @@ mlx5_ind_table_ibv_drop_release(struct rte_eth_dev *dev)* Pointer to Ethernet device. * * @return -* The Verbs object initialised, NULL otherwise and rte_errno is set. +* The Verbs object initialized, NULL otherwise and rte_errno is set. */ struct mlx5_hrxq *mlx5_hrxq_drop_new (struct rte_eth_dev *dev)drivers/net/mlx5/mlx5_rxtx.c +1
-1@@ -1507,7 +1507,7 @@ txq_burst_empw(struct mlx5_txq_data *txq, struct rte_mbuf **pkts, mpw.wqe->eseg.cs_flags = cs_flags; }else {/* Evaluate whether the next packet can be inlined. -* Inlininig is possible when: +* Inlining is possible when: * - length is less than configured value * - length fits for remaining space * - not required to fill the title WQEBB with dsegs Signature · 1 line
2.18.0