virtio-net: mark expected switch fall-throughs

PATCH Applied Gustavo A. R. Silva 2 participants 3 messages Aug 5, 2018 – Aug 6, 2018

Subsystems (4)

Networking Network drivers virtio core virtio net driver

lore

Share & tools

lore

Gustavo A. R. Silva

author

2018-08-05 02:42 UTC #0 lore raw

PATCH 1/1 virtio-net: mark expected switch fall-throughs

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.

Addresses-Coverity-ID: 1402059 ("Missing break in switch")
Addresses-Coverity-ID: 1402060 ("Missing break in switch")
Addresses-Coverity-ID: 1402061 ("Missing break in switch")

Signed-off-by Gustavo A. R. Silva <[email protected]>

---
 drivers/net/virtio_net.c | 3 +++
 1 file changed, 3 insertions(+)

drivers/net/virtio_net.c +3 -0

index 14f661c..62311dd 100644
@@ -697,6 +697,7 @@ static struct sk_buff *receive_small(struct net_device *dev,
 			goto xdp_xmit;
 		default:
 			bpf_warn_invalid_xdp_action(act);
+			/* fall through */
 		case XDP_ABORTED:
 			trace_xdp_exception(vi->dev, xdp_prog, act);
 		case XDP_DROP:

@@ -876,8 +877,10 @@ static struct sk_buff *receive_mergeable(struct net_device *dev,
 			goto xdp_xmit;
 		default:
 			bpf_warn_invalid_xdp_action(act);
+			/* fall through */
 		case XDP_ABORTED:
 			trace_xdp_exception(vi->dev, xdp_prog, act);
+			/* fall through */
 		case XDP_DROP:
 			if (unlikely(xdp_page != page))
 				__free_pages(xdp_page, 0);

Signature · 1 line

2.7.4

David Miller

maintainer Applied

2018-08-06 00:27 UTC #1 lore raw

From: "Gustavo A. R. Silva" <[email protected]>
Date: Sat, 4 Aug 2018 21:42:05 -0500

Quoted 7 lines

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.
Addresses-Coverity-ID: 1402059 ("Missing break in switch")
Addresses-Coverity-ID: 1402060 ("Missing break in switch")
Addresses-Coverity-ID: 1402061 ("Missing break in switch")
Signed-off-by Gustavo A. R. Silva <[email protected]>

Applied, thank you.