RDS is not Radio Data System
Subsystems (3)
PATCH 1/1 RDS is not Radio Data System
Hi!
Getting prompt "The RDS Protocol" (RDS) is not too helpful, and it is easily confused with Radio Data System (which we may want to support in kernel, too).
I wonder if option should be named NET_RDS, instead?
And this sounds like a good idea:
(Plus, we normally have "module will be called foobar" and if unsure say X. What happened to those?)
net/rds/Kconfig +1 -1
@@ -1,6 +1,6 @@ config RDS - tristate "The RDS Protocol" + tristate "The Reliable Datagram Sockets (RDS) Protocol" depends on INET ---help--- The RDS (Reliable Datagram Sockets) protocol provides reliable,
Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Quoted 5 lines · Pavel Machek
Getting prompt "The RDS Protocol" (RDS) is not too helpful, and it is easily confused with Radio Data System (which we may want to support in kernel, too).
I wonder if option should be named
NET_RDS, instead?
RDS has been around for a while now (since 2.6). How will you rename proposal manage backward compatibility? Why can't you call your new option CONFIG_RADIO or similar instead?
Are we going to rename NFS* to NET_NFS* because someone decided to reuse the NFS acronym?
net/rds/Kconfig line 3
Quoted 3 lines
And this sounds like a good idea:
net/rds/Kconfig +1
-1- tristate "The RDS Protocol" + tristate "The Reliable Datagram Sockets (RDS) Protocol"
surn that sounds fine.
--Sowmini
Quoted 5 lines · Sowmini Varadhan
Quoted 4 lines · Pavel Machek
Getting prompt "The RDS Protocol" (RDS) is not too helpful, and it is easily confused with Radio Data System (which we may want to support in kernel, too).
Quoted 8 lines
Quoted 1 line
I wonder if option should be named
NET_RDS, instead?RDS has been around for a while now (since 2.6). How will you rename proposal manage backward compatibility? Why can't you call your new option
CONFIG_RADIOor similar instead?Are we going to rename NFS* to NET_NFS* because someone decided to reuse the NFS acronym?
Was it?
Because this was first time kernel asked that question... when I was testing -next. Is this related?
commit 533d1daea8d8a389b37207ad7b50c4e750969231
IB: Revert "remove redundant INFINIBAND kconfig dependencies"
Quoted 5 lines
net/rds/Kconfig line 3
Quoted 3 lines
And this sounds like a good idea:
net/rds/Kconfig +1
-1- tristate "The RDS Protocol" + tristate "The Reliable Datagram Sockets (RDS) Protocol"surn that sounds fine.
Can you apply the patch, or do you want me to send it to davem?
Thanks,
Pavel
Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Sowmini Varadhan
Acked-byQuoted 2 lines · Pavel Machek
Was it?
RDS was added in 2.6.30: see https://kernelnewbies.org/Linux_2_6_30
Recent RDS commits may have triggered the observation you note below (you may have had it disabled by default until now)
Quoted 5 lines
Because this was first time kernel asked that question... when I was testing -next. Is this related?
Can you apply the patch, or do you want me to send it to davem?
Signed-off-by Pavel Machek <[email protected]>
please feel free to send the patch and add me as
--Sowmini
Quoted 6 lines · Pavel Machek
Hi!
Getting prompt "The RDS Protocol" (RDS) is not too helpful, and it is easily confused with Radio Data System (which we may want to support in kernel, too).
Fair enough. Prompt change is fine Pavel.
Quoted 7 lines
I wonder if option should be named
NET_RDS, instead?And this sounds like a good idea:
(Plus, we normally have "module will be called foobar" and if unsure say X. What happened to those?)
Module name is there for a while so please use different one if you have a conflict with it.
net/rds/Kconfig line 6
Quoted 13 lines
net/rds/Kconfig +1
-1@@ -1,6 +1,6 @@ config RDS - tristate "The RDS Protocol" + tristate "The Reliable Datagram Sockets (RDS) Protocol" depends on INET ---help--- The RDS (Reliable Datagram Sockets) protocol provides reliable,
Please git format this patch with your SOB and send it to netdev. Feel free to add my ack with it.