package/pure-ftpd: add optional support for linux-pam
PATCH 1/1 package/pure-ftpd: add optional support for linux-pam
--- package/pure-ftpd/pure-ftpd.mk | 5 +++++ 1 file changed, 5 insertions(+)
package/pure-ftpd/pure-ftpd.mk +5 -0
@@ -57,4 +57,9 @@ ifeq ($(BR2_PACKAGE_PURE_FTPD_UPLOADSCRIPT),y) PURE_FTPD_CONF_OPTS += --with-uploadscript endif +ifeq ($(BR2_PACKAGE_LINUX_PAM),y) +PURE_FTPD_CONF_OPTS += --with-pam +PURE_FTPD_DEPENDENCIES += linux-pam +endif + $(eval $(autotools-package))
Signature · 1 line
2.17.1
PATCH 1/1 package/pure-ftpd: add optional support for linux-pam
Am Wed, 01 Aug 2018 16:21:14 +0300 schrieb Artem Panfilov:
package/pure-ftpd/pure-ftpd.mk ifeq ($(BR2_PACKAGE_PURE_FTPD_UPLOADSCRIPT),y) · line 63
Quoted 4 lines
package/pure-ftpd/pure-ftpd.mk +4
-0+ifeq ($(BR2_PACKAGE_LINUX_PAM),y) +PURE_FTPD_CONF_OPTS += --with-pam +PURE_FTPD_DEPENDENCIES += linux-pam +endif
Hi Artem,
could you please add
else PURE_FTPD_CONF_OPTS += --without-pam
to make sure the outcome of the configure step takes our config into account and not defaults chosen by upstream?
Thanks!
Regards, Bernd
PATCH 1/1 package/pure-ftpd: add optional support for linux-pam
Hi Bernd,
Quoted 4 lines
could you please add
??? else
???PURE_FTPD_CONF_OPTS+= --without-pam
I added your change, thanks.
Best Regards,
Artyom
From fd70cdf2634e279eb604bbf3381ce70eefd9a7b2 Mon Sep 17 00:00:00 2001
From: Artem Panfilov <[email protected]>
Date: Wed, 1 Aug 2018 16:05:59 +0300
Subject: [PATCH 1/1] package/pure-ftpd: add optional support for linux-pam
--- ?package/pure-ftpd/pure-ftpd.mk | 7 +++++++
?1 file changed, 7 insertions(+)
package/pure-ftpd/pure-ftpd.mk +7 -0
@@ -57,4 +57,11 @@ ifeq ($(BR2_PACKAGE_PURE_FTPD_UPLOADSCRIPT),y) ?PURE_FTPD_CONF_OPTS += --with-uploadscript ?endif +ifeq ($(BR2_PACKAGE_LINUX_PAM),y) +PURE_FTPD_CONF_OPTS += --with-pam +PURE_FTPD_DEPENDENCIES += linux-pam +else +PURE_FTPD_CONF_OPTS += --without-pam +endif + ?$(eval $(autotools-package))
Signature · 1 line
2.17.1
Quoted 24 lines · Bernd Kuhls
Am Wed, 01 Aug 2018 16:21:14 +0300 schrieb Artem Panfilov:
Review
Quoted 4 lines
(quoted diff) +4
-0+ifeq ($(BR2_PACKAGE_LINUX_PAM),y) +PURE_FTPD_CONF_OPTS += --with-pam +PURE_FTPD_DEPENDENCIES += linux-pam +endifHi Artem,
could you please add
else PURE_FTPD_CONF_OPTS += --without-pamto make sure the outcome of the configure step takes our config into account and not defaults chosen by upstream?
Thanks!
Regards, Bernd
_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Thomas Petazzoni
AppliedPATCH 1/1 package/pure-ftpd: add optional support for linux-pam
In reply to Artem PanfilovHello,
Quoted 4 lines · Artem Panfilov
Signed-off-by Artem Panfilov <[email protected]>--- package/pure-ftpd/pure-ftpd.mk | 5 +++++ 1 file changed, 5 insertions(+)
Applied to master after adding an explicit --without-pam, as suggested by Bernd.
Thanks,
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com