Skip to contentSkip to conversation

sandbox: Move BSS after EFI sections

PATCH New Alexander Graf 2 participants 2 messages Aug 6, 2018 – Aug 17, 2018

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 sandbox: Move BSS after EFI sections

Something went wrong when writing the sandbox linker scripts and so we ended up with a .bss section marker right before the efi runtime sections.

That obviously is a terrible idea, as it may result in overwriting efi runtime code and data. So let's move the .bss identifier behind the efi sections.

---
 arch/sandbox/cpu/u-boot.lds | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
arch/sandbox/cpu/u-boot.lds +2 -3
index 727bcc3598..40c2214301 100644
@@ -17,9 +17,7 @@ SECTIONS
 	_u_boot_sandbox_getopt : { *(.u_boot_sandbox_getopt) }
 	__u_boot_sandbox_option_end = .;
 
-	__bss_start = .;
-
-		.__efi_runtime_start : {
+	.__efi_runtime_start : {
 		*(.__efi_runtime_start)
 	}
 
@@ -48,6 +46,7 @@ SECTIONS
 		*(.__efi_runtime_rel_stop)
 	}
 
+	__bss_start = .;
 }
 
 INSERT BEFORE .data;
Signature · 1 line
2.12.3
#1 lore raw

PATCH 1/1 sandbox: Move BSS after EFI sections

Hi,

Quoted 11 lines · Alexander Graf

Something went wrong when writing the sandbox linker scripts and so we ended up with a .bss section marker right before the efi runtime sections.

That obviously is a terrible idea, as it may result in overwriting efi runtime code and data. So let's move the .bss identifier behind the efi sections.

---
 arch/sandbox/cpu/u-boot.lds | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

I think we should revert the patch that changed this, and deal with each of its changes one by one. As of now, sandbox is broken.

I already sent a patch for this.

Regards,
Simon