clk: max77686: Add SPDX license identifiers
Subsystems (7)
Krzysztof Kozlowski
maintainerPATCH 1/3 clk: max77686: Add SPDX license identifiers
Replace GPL v2.0 and v2.0+ license statements with SPDX license identifiers.
--- drivers/clk/clk-max77686.c | 27 ++++++--------------------- include/dt-bindings/clock/maxim,max77686.h | 5 +---- include/dt-bindings/clock/maxim,max77802.h | 5 +---- 3 files changed, 8 insertions(+), 29 deletions(-)
drivers/clk/clk-max77686.c +6 -21
@@ -1,24 +1,9 @@ -/* -* clk-max77686.c - Clock driver for Maxim 77686/MAX77802 -* -* Copyright (C) 2012 Samsung Electornics -* Jonghwa Lee <[email protected]> -* -* This program is free software; you can redistribute it and/or modify it -* under the terms of the GNU General Public License as published by the -* Free Software Foundation; either version 2 of the License, or (at your -* option) any later version. -* -* This program is distributed in the hope that it will be useful, -* but WITHOUT ANY WARRANTY; without even the implied warranty of -* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the -* GNU General Public License for more details. -* -* You should have received a copy of the GNU General Public License -* along with this program; if not, write to the Free Software -* Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA -* -*/ +// SPDX-License-Identifier: GPL-2.0+ +// +// clk-max77686.c - Clock driver for Maxim 77686/MAX77802 +// +// Copyright (C) 2012 Samsung Electornics +// Jonghwa Lee <[email protected]> #include <linux/kernel.h> #include <linux/slab.h>
include/dt-bindings/clock/maxim,max77686.h +1 -4
@@ -1,10 +1,7 @@ +/* SPDX-License-Identifier: GPL-2.0 */ /* * Copyright (C) 2014 Google, Inc * -* This program is free software; you can redistribute it and/or modify -* it under the terms of the GNU General Public License version 2 as -* published by the Free Software Foundation. -* * Device Tree binding constants clocks for the Maxim 77686 PMIC. */
include/dt-bindings/clock/maxim,max77802.h +1 -4
@@ -1,10 +1,7 @@ +/* SPDX-License-Identifier: GPL-2.0 */ /* * Copyright (C) 2014 Google, Inc * -* This program is free software; you can redistribute it and/or modify -* it under the terms of the GNU General Public License version 2 as -* published by the Free Software Foundation. -* * Device Tree binding constants clocks for the Maxim 77802 PMIC. */
Signature · 1 line
2.14.1
Krzysztof Kozlowski
maintainerPATCH 2/3 clk: s2mps11,s3c64xx: Add SPDX license identifiers
Replace GPL v2.0 and v2.0+ license statements with SPDX license identifiers.
--- drivers/clk/clk-s2mps11.c | 21 +++++---------------- include/dt-bindings/clock/samsung,s2mps11.h | 5 +---- include/dt-bindings/clock/samsung,s3c64xx-clock.h | 7 ++----- 3 files changed, 8 insertions(+), 25 deletions(-)
drivers/clk/clk-s2mps11.c +5 -16
@@ -1,19 +1,8 @@ -/* -* clk-s2mps11.c - Clock driver for S2MPS11. -* -* Copyright (C) 2013,2014 Samsung Electornics -* -* This program is free software; you can redistribute it and/or modify it -* under the terms of the GNU General Public License as published by the -* Free Software Foundation; either version 2 of the License, or (at your -* option) any later version. -* -* This program is distributed in the hope that it will be useful, -* but WITHOUT ANY WARRANTY; without even the implied warranty of -* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the -* GNU General Public License for more details. -* -*/ +// SPDX-License-Identifier: GPL-2.0+ +// +// clk-s2mps11.c - Clock driver for S2MPS11. +// +// Copyright (C) 2013,2014 Samsung Electornics #include <linux/module.h> #include <linux/err.h>
include/dt-bindings/clock/samsung,s2mps11.h +1 -4
@@ -1,10 +1,7 @@ +/* SPDX-License-Identifier: GPL-2.0 */ /* * Copyright (C) 2015 Markus Reichl * -* This program is free software; you can redistribute it and/or modify -* it under the terms of the GNU General Public License version 2 as -* published by the Free Software Foundation. -* * Device Tree binding constants clocks for the Samsung S2MPS11 PMIC. */
include/dt-bindings/clock/samsung,s3c64xx-clock.h +2 -5
@@ -1,12 +1,9 @@ +/* SPDX-License-Identifier: GPL-2.0 */ /* * Copyright (c) 2013 Tomasz Figa <tomasz.figa at gmail.com> * -* This program is free software; you can redistribute it and/or modify -* it under the terms of the GNU General Public License version 2 as -* published by the Free Software Foundation. -* * Device Tree binding constants for Samsung S3C64xx clock controller. -*/ +*/ #ifndef _DT_BINDINGS_CLOCK_SAMSUNG_S3C64XX_CLOCK_H#define _DT_BINDINGS_CLOCK_SAMSUNG_S3C64XX_CLOCK_H
Signature · 1 line
2.14.1
Rob Herring
maintainerRe: [PATCH 2/3] clk: s2mps11,s3c64xx: Add SPDX license identifiers
Hi, this is an automated email from Rob's (experimental) review bot. I found a couple of common problems with your patch. Please see below.
Quoted 4 lines · Krzysztof Kozlowski
Replace GPL v2.0 and v2.0+ license statements with SPDX license identifiers.
Signed-off-by Krzysztof Kozlowski <[email protected]>
The preferred subject prefix is "dt-bindings: <binding dir>: ...".
Quoted 6 lines
--- drivers/clk/clk-s2mps11.c | 21 +++++---------------- include/dt-bindings/clock/samsung,s2mps11.h | 5 +---- include/dt-bindings/clock/samsung,s3c64xx-clock.h | 7 ++----- 3 files changed, 8 insertions(+), 25 deletions(-)
DT bindings (including binding headers) should be a separate patch. See Documentation/devicetree/bindings/submitting-patches.txt.
Re: [PATCH 2/3] clk: s2mps11,s3c64xx: Add SPDX license identifiers
In reply to Krzysztof KozlowskiQuoted 10 lines · Krzysztof Kozlowski
Replace GPL v2.0 and v2.0+ license statements with SPDX license identifiers.
Signed-off-by Krzysztof Kozlowski <[email protected]>--- drivers/clk/clk-s2mps11.c | 21 +++++---------------- include/dt-bindings/clock/samsung,s2mps11.h | 5 +---- include/dt-bindings/clock/samsung,s3c64xx-clock.h | 7 ++----- 3 files changed, 8 insertions(+), 25 deletions(-)
Re: [PATCH 2/3] clk: s2mps11,s3c64xx: Add SPDX license identifiers
In reply to Krzysztof KozlowskiQuoting Krzysztof Kozlowski (2018-08-07 09:17:12)
Quoted 6 lines
Replace GPL v2.0 and v2.0+ license statements with SPDX license identifiers.
=Signed-off-by Krzysztof Kozlowski <[email protected]>---
Applied to clk-next
Krzysztof Kozlowski
maintainerPATCH 3/3 clk: s2mps11: Use existing defines from bindings for clock IDs
In reply to Krzysztof KozlowskiThe clock IDs must match between DeviceTree bindings and the driver. There is already a header file used by DeviceTree sources so include it in the driver to remove duplicated symbols.
--- drivers/clk/clk-s2mps11.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-)
drivers/clk/clk-s2mps11.c +1 -6
@@ -17,12 +17,7 @@#include <linux/mfd/samsung/s5m8767.h> #include <linux/mfd/samsung/core.h> -enum { -S2MPS11_CLK_AP =0 , -S2MPS11_CLK_CP , -S2MPS11_CLK_BT , -S2MPS11_CLKS_NUM , -}; +#include <dt-bindings/clock/samsung,s2mps11.h> struct s2mps11_clk {struct sec_pmic_dev *iodev;
Signature · 1 line
2.14.1
Re: [PATCH 3/3] clk: s2mps11: Use existing defines from bindings for clock IDs
Quoted 9 lines · Krzysztof Kozlowski
The clock IDs must match between DeviceTree bindings and the driver. There is already a header file used by DeviceTree sources so include it in the driver to remove duplicated symbols.
Signed-off-by Krzysztof Kozlowski <[email protected]>--- drivers/clk/clk-s2mps11.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-)
Re: [PATCH 3/3] clk: s2mps11: Use existing defines from bindings for clock IDs
In reply to Krzysztof KozlowskiQuoting Krzysztof Kozlowski (2018-08-07 09:17:13)
Quoted 7 lines
The clock IDs must match between DeviceTree bindings and the driver. There is already a header file used by DeviceTree sources so include it in the driver to remove duplicated symbols.
=Signed-off-by Krzysztof Kozlowski <[email protected]>---
Applied to clk-next
Quoting Krzysztof Kozlowski (2018-08-07 09:17:11)
Quoted 6 lines
Replace GPL v2.0 and v2.0+ license statements with SPDX license identifiers.
=Signed-off-by Krzysztof Kozlowski <[email protected]>---
Applied to clk-next