Skip to contentSkip to conversation

regulator: maxim: Add SPDX license identifiers

PATCH In review Krzysztof Kozlowski 2 participants 4 messages Aug 7, 2018 – Aug 14, 2018

Subsystems (6)
lore
Share & tools
lore

Krzysztof Kozlowski

author maintainer
#0 lore raw

PATCH 1/2 regulator: maxim: Add SPDX license identifiers

Replace GPL v2.0 and v2.0+ license statements with SPDX license identifiers.

---
 drivers/regulator/max14577-regulator.c         | 22 +++++------------
 drivers/regulator/max77686-regulator.c         | 32 +++++++-----------------
 drivers/regulator/max77693-regulator.c         | 32 +++++++-----------------
 drivers/regulator/max77802-regulator.c         | 34 +++++++++-----------------
 drivers/regulator/max8997-regulator.c          | 30 ++++++-----------------
 drivers/regulator/max8998.c                    | 28 ++++++---------------
 include/dt-bindings/regulator/maxim,max77802.h |  5 +---
 7 files changed, 52 insertions(+), 131 deletions(-)
drivers/regulator/max14577-regulator.c +6 -16
index 0db288ce319c..bc7f4751bf9c 100644
@@ -1,19 +1,9 @@
-/*
- * max14577.c - Regulator driver for the Maxim 14577/77836
- *
- * Copyright (C) 2013,2014 Samsung Electronics
- * Krzysztof Kozlowski <[email protected]>
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- */
+// SPDX-License-Identifier: GPL-2.0+
+//
+// max14577.c - Regulator driver for the Maxim 14577/77836
+//
+// Copyright (C) 2013,2014 Samsung Electronics
+// Krzysztof Kozlowski <[email protected]>
 
 #include <linux/module.h>
 #include <linux/platform_device.h>
drivers/regulator/max77686-regulator.c +9 -23
index c301f3733475..bee060937f56 100644
@@ -1,26 +1,12 @@
-/*
- * max77686.c - Regulator driver for the Maxim 77686
- *
- * Copyright (C) 2012 Samsung Electronics
- * Chiwoong Byun <[email protected]>
- * Jonghwa Lee <[email protected]>
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
- *
- * This driver is based on max8997.c
- */
+// SPDX-License-Identifier: GPL-2.0+
+//
+// max77686.c - Regulator driver for the Maxim 77686
+//
+// Copyright (C) 2012 Samsung Electronics
+// Chiwoong Byun <[email protected]>
+// Jonghwa Lee <[email protected]>
+//
+// This driver is based on max8997.c
 
 #include <linux/kernel.h>
 #include <linux/bug.h>
drivers/regulator/max77693-regulator.c +9 -23
index e7000e777292..077ecbbfdf76 100644
@@ -1,26 +1,12 @@
-/*
- * max77693.c - Regulator driver for the Maxim 77693 and 77843
- *
- * Copyright (C) 2013-2015 Samsung Electronics
- * Jonghwa Lee <[email protected]>
- * Krzysztof Kozlowski <[email protected]>
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
- *
- * This driver is based on max77686.c
- */
+// SPDX-License-Identifier: GPL-2.0+
+//
+// max77693.c - Regulator driver for the Maxim 77693 and 77843
+//
+// Copyright (C) 2013-2015 Samsung Electronics
+// Jonghwa Lee <[email protected]>
+// Krzysztof Kozlowski <[email protected]>
+//
+// This driver is based on max77686.c
 
 #include <linux/err.h>
 #include <linux/slab.h>
drivers/regulator/max77802-regulator.c +12 -22
index b6261903818c..c30cf5c9f2de 100644
@@ -1,25 +1,15 @@
-/*
- * max77802.c - Regulator driver for the Maxim 77802
- *
- * Copyright (C) 2013-2014 Google, Inc
- * Simon Glass <[email protected]>
- *
- * Copyright (C) 2012 Samsung Electronics
- * Chiwoong Byun <[email protected]>
- * Jonghwa Lee <[email protected]>
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- *
- * This driver is based on max8997.c
- */
+// SPDX-License-Identifier: GPL-2.0+
+//
+// max77802.c - Regulator driver for the Maxim 77802
+//
+// Copyright (C) 2013-2014 Google, Inc
+// Simon Glass <[email protected]>
+//
+// Copyright (C) 2012 Samsung Electronics
+// Chiwoong Byun <[email protected]>
+// Jonghwa Lee <[email protected]>
+//
+// This driver is based on max8997.c
 
 #include <linux/kernel.h>
 #include <linux/bug.h>
drivers/regulator/max8997-regulator.c +8 -22
index 029a6ee426ab..ad0c806b0737 100644
@@ -1,25 +1,11 @@
-/*
- * max8997.c - Regulator driver for the Maxim 8997/8966
- *
- * Copyright (C) 2011 Samsung Electronics
- * MyungJoo Ham <[email protected]>
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
- *
- * This driver is based on max8998.c
- */
+// SPDX-License-Identifier: GPL-2.0+
+//
+// max8997.c - Regulator driver for the Maxim 8997/8966
+//
+// Copyright (C) 2011 Samsung Electronics
+// MyungJoo Ham <[email protected]>
+//
+// This driver is based on max8998.c
 
 #include <linux/bug.h>
 #include <linux/err.h>
drivers/regulator/max8998.c +7 -21
index 6b9f262ebbb0..271bb736f3f5 100644
@@ -1,24 +1,10 @@
-/*
- * max8998.c - Voltage regulator driver for the Maxim 8998
- *
- *  Copyright (C) 2009-2010 Samsung Electronics
- *  Kyungmin Park <[email protected]>
- *  Marek Szyprowski <[email protected]>
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
- */
+// SPDX-License-Identifier: GPL-2.0+
+//
+// max8998.c - Voltage regulator driver for the Maxim 8998
+//
+//  Copyright (C) 2009-2010 Samsung Electronics
+//  Kyungmin Park <[email protected]>
+//  Marek Szyprowski <[email protected]>
 
 #include <linux/module.h>
 #include <linux/init.h>
include/dt-bindings/regulator/maxim,max77802.h +1 -4
index cf28631d7109..d0baba1973d4 100644
@@ -1,10 +1,7 @@
+/* SPDX-License-Identifier: GPL-2.0 */
 /*
  * Copyright (C) 2014 Google, Inc
  *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License version 2 as
- * published by the Free Software Foundation.
- *
  * Device Tree binding constants for the Maxim 77802 PMIC regulators
  */
 
Signature · 1 line
2.14.1
author maintainer
#1 lore raw

PATCH 2/2 regulator: samsung: Add SPDX license identifiers

Replace GPL v2.0+ license statements with SPDX license identifiers.

---
 drivers/regulator/s2mpa01.c | 14 ++++----------
 drivers/regulator/s2mps11.c | 21 ++++-----------------
 drivers/regulator/s5m8767.c | 16 ++++------------
 3 files changed, 12 insertions(+), 39 deletions(-)
drivers/regulator/s2mpa01.c +4 -10
index 48f0ca90743c..095d25f3d2ea 100644
@@ -1,13 +1,7 @@
-/*
- * Copyright (c) 2013 Samsung Electronics Co., Ltd
- *		http://www.samsung.com
- *
- *  This program is free software; you can redistribute  it and/or modify it
- *  under  the terms of  the GNU General  Public License as published by the
- *  Free Software Foundation;  either version 2 of the  License, or (at your
- *  option) any later version.
- *
- */
+// SPDX-License-Identifier: GPL-2.0+
+//
+// Copyright (c) 2013 Samsung Electronics Co., Ltd
+//		http://www.samsung.com
 
 #include <linux/bug.h>
 #include <linux/err.h>
drivers/regulator/s2mps11.c +4 -17
index d1207ec683db..5bb6f4ca48db 100644
@@ -1,20 +1,7 @@
-/*
- * s2mps11.c
- *
- * Copyright (c) 2012-2014 Samsung Electronics Co., Ltd
- *              http://www.samsung.com
- *
- * This program is free software; you can redistribute  it and/or modify it
- * under  the terms of  the GNU General  Public License as published by the
- * Free Software Foundation;  either version 2 of the  License, or (at your
- * option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- *
- */
+// SPDX-License-Identifier: GPL-2.0+
+//
+// Copyright (c) 2012-2014 Samsung Electronics Co., Ltd
+//              http://www.samsung.com
 
 #include <linux/bug.h>
 #include <linux/err.h>
drivers/regulator/s5m8767.c +4 -12
index 0cbc980753c2..667d16dc83ce 100644
@@ -1,15 +1,7 @@
-/*
- * s5m8767.c
- *
- * Copyright (c) 2011 Samsung Electronics Co., Ltd
- *              http://www.samsung.com
- *
- *  This program is free software; you can redistribute  it and/or modify it
- *  under  the terms of  the GNU General  Public License as published by the
- *  Free Software Foundation;  either version 2 of the  License, or (at your
- *  option) any later version.
- *
- */
+// SPDX-License-Identifier: GPL-2.0+
+//
+// Copyright (c) 2011 Samsung Electronics Co., Ltd
+//              http://www.samsung.com
 
 #include <linux/err.h>
 #include <linux/of_gpio.h>
Signature · 1 line
2.14.1
maintainer
#2 lore raw
In reply to Krzysztof Kozlowski

Hi, this is an automated email from Rob's (experimental) review bot. I found a couple of common problems with your patch. Please see below.

Quoted 4 lines · Krzysztof Kozlowski

Replace GPL v2.0 and v2.0+ license statements with SPDX license identifiers.

The preferred subject prefix is "dt-bindings: <binding dir>: ...".

Quoted 10 lines
---
 drivers/regulator/max14577-regulator.c         | 22 +++++------------
 drivers/regulator/max77686-regulator.c         | 32 +++++++-----------------
 drivers/regulator/max77693-regulator.c         | 32 +++++++-----------------
 drivers/regulator/max77802-regulator.c         | 34 +++++++++-----------------
 drivers/regulator/max8997-regulator.c          | 30 ++++++-----------------
 drivers/regulator/max8998.c                    | 28 ++++++---------------
 include/dt-bindings/regulator/maxim,max77802.h |  5 +---
 7 files changed, 52 insertions(+), 131 deletions(-)

DT bindings (including binding headers) should be a separate patch. See Documentation/devicetree/bindings/submitting-patches.txt.

maintainer Reviewed-by on v1 1/2
#3 lore raw
In reply to Krzysztof Kozlowski
Quoted 4 lines · Krzysztof Kozlowski

Replace GPL v2.0 and v2.0+ license statements with SPDX license identifiers.

Quoted 10 lines
---
 drivers/regulator/max14577-regulator.c         | 22 +++++------------
 drivers/regulator/max77686-regulator.c         | 32 +++++++-----------------
 drivers/regulator/max77693-regulator.c         | 32 +++++++-----------------
 drivers/regulator/max77802-regulator.c         | 34 +++++++++-----------------
 drivers/regulator/max8997-regulator.c          | 30 ++++++-----------------
 drivers/regulator/max8998.c                    | 28 ++++++---------------
 include/dt-bindings/regulator/maxim,max77802.h |  5 +---
 7 files changed, 52 insertions(+), 131 deletions(-)