Skip to contentSkip to conversation

drm/i915: remove the unnecessary restriction for NV12 in intel_framebuffer_init

PATCH New Dongseong Hwang 2 participants 4 messages Aug 8, 2018 – Aug 9, 2018

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/i915: remove the unnecessary restriction for NV12 in intel_framebuffer_init

framebuffer for NV12 requires the pitch to the multiplier of 4, instead of the width. This patch corrects it.

For instance, a 480p video, whose width and pitch are 854 and 896 respectively, is excluded for NV12 plane so far.

Cc Chandra Konduru <[email protected]>
Cc Vidya Srinivas <[email protected]>
Cc Ville Syrjälä <[email protected]>
Cc Juha-Pekka Heikkila <[email protected]>
---
 drivers/gpu/drm/i915/intel_display.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/i915/intel_display.c +1 -1
index 53e7a7e..87c9a53 100644
@@ -14566,7 +14566,7 @@ static int intel_framebuffer_init(struct intel_framebuffer *intel_fb,
 	if (fb->format->format == DRM_FORMAT_NV12 &&
 	    (fb->width < SKL_MIN_YUV_420_SRC_W ||
 	     fb->height < SKL_MIN_YUV_420_SRC_H ||
-	     (fb->width % 4) != 0 || (fb->height % 4) != 0)) {
+	     (fb->pitches[0] % 4) != 0 || (fb->height % 4) != 0)) {
 		DRM_DEBUG_KMS("src dimensions not correct for NV12\n");
 		return -EINVAL;
 	}
Signature · 6 lines
2.7.4

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#1 lore raw

✗ Fi.CI.CHECKPATCH: warning for drm/i915: remove the unnecessary restriction for NV12 in intel_framebuffer_init

== Series Details ==

== Series Details ==

Series: drm/i915: remove the unnecessary restriction for NV12 in intel_framebuffer_init
URL : https://patchwork.freedesktop.org/series/47909/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
b513210d0543 drm/i915: remove the unnecessary restriction for NV12 in intel_framebuffer_init
-:10: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#10: 
framebuffer for NV12 requires the pitch to the multiplier of 4, instead of the

total: 0 errors, 1 warnings, 0 checks, 8 lines checked

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#2 lore raw

✓ Fi.CI.BAT: success for drm/i915: remove the unnecessary restriction for NV12 in intel_framebuffer_init

In reply to Dongseong Hwang
== Series Details ==

== Series Details ==

Series: drm/i915: remove the unnecessary restriction for NV12 in intel_framebuffer_init
URL : https://patchwork.freedesktop.org/series/47909/
State : success

== Summary ==

= CI Bug Log - changes from CI_DRM_4635 -> Patchwork_9893 =

== Summary - SUCCESS ==

No regressions found.

External URL: https://patchwork.freedesktop.org/api/1.0/series/47909/revisions/1/mbox/

== Known issues ==

Here are the changes found in Patchwork_9893 that come from known issues:

=== IGT changes ===

    ==== Issues hit ====

    {igt@amdgpu/amd_prime@amd-to-i915}:
      {fi-kbl-8809g}:     NOTRUN -> FAIL (fdo#107341)

    igt@drv_selftest@live_coherency:
      fi-gdg-551:         PASS -> DMESG-FAIL (fdo#107164)

    igt@drv_selftest@live_hangcheck:
      {fi-cfl-8109u}:     PASS -> DMESG-FAIL (fdo#106560)

    igt@drv_selftest@live_workarounds:
      fi-skl-6700hq:      PASS -> DMESG-FAIL (fdo#107292)

    
    ==== Possible fixes ====

    {igt@amdgpu/amd_basic@userptr}:
      {fi-kbl-8809g}:     INCOMPLETE (fdo#107402) -> PASS

    igt@drv_selftest@live_hangcheck:
      fi-cnl-psr:         DMESG-FAIL (fdo#106560) -> PASS
      fi-skl-guc:         DMESG-FAIL (fdo#107174) -> PASS

    igt@kms_pipe_crc_basic@read-crc-pipe-b:
      {fi-byt-clapper}:   FAIL (fdo#107362) -> PASS

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

fdo#106560 https://bugs.freedesktop.org/show_bug.cgi?id=106560
fdo#107164 https://bugs.freedesktop.org/show_bug.cgi?id=107164
fdo#107174 https://bugs.freedesktop.org/show_bug.cgi?id=107174
fdo#107292 https://bugs.freedesktop.org/show_bug.cgi?id=107292
fdo#107341 https://bugs.freedesktop.org/show_bug.cgi?id=107341
fdo#107362 https://bugs.freedesktop.org/show_bug.cgi?id=107362
fdo#107402 https://bugs.freedesktop.org/show_bug.cgi?id=107402

== Participating hosts (50 -> 46) ==

Additional (1): fi-hsw-peppy
Missing (5): fi-byt-squawks fi-ilk-m540 fi-bxt-dsi fi-bsw-cyan fi-hsw-4200u

== Build changes ==

* Linux: CI_DRM_4635 -> Patchwork_9893

CI_DRM_4635: a9f34f7e3bab765e2b1320a1b154a76be38602a7 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4589: 779d2d42f9db6a2797d1ef50036af6fac4e62e73 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_9893: b513210d05436fa3906e4d9258ceca693b6fe7ca @ git://anongit.freedesktop.org/gfx-ci/linux

== Linux commits ==

b513210d0543 drm/i915: remove the unnecessary restriction for NV12 in intel_framebuffer_init

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_9893/issues.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#3 lore raw

✓ Fi.CI.IGT: success for drm/i915: remove the unnecessary restriction for NV12 in intel_framebuffer_init

In reply to Dongseong Hwang
== Series Details ==

== Series Details ==

Series: drm/i915: remove the unnecessary restriction for NV12 in intel_framebuffer_init
URL : https://patchwork.freedesktop.org/series/47909/
State : success

== Summary ==

= CI Bug Log - changes from CI_DRM_4635_full -> Patchwork_9893_full =

== Summary - WARNING ==

Minor unknown changes coming with Patchwork_9893_full need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in Patchwork_9893_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

== Possible new issues ==

Here are the unknown changes that may have been introduced in Patchwork_9893_full:

=== IGT changes ===

    ==== Warnings ====

    igt@kms_cursor_crc@cursor-256x256-rapid-movement:
      shard-snb:          PASS -> SKIP +2

    igt@pm_rc6_residency@rc6-accuracy:
      shard-snb:          SKIP -> PASS

== Known issues ==

Here are the changes found in Patchwork_9893_full that come from known issues:

=== IGT changes ===

    ==== Issues hit ====

    igt@kms_setmode@basic:
      shard-apl:          PASS -> FAIL (fdo#99912)

    igt@perf@polling:
      shard-hsw:          PASS -> FAIL (fdo#102252)

    igt@perf_pmu@rc6-runtime-pm:
      shard-glk:          PASS -> FAIL (fdo#105010)

    
    ==== Possible fixes ====

    igt@gem_exec_await@wide-contexts:
      shard-apl:          FAIL (fdo#106680, fdo#105900) -> PASS

    igt@kms_setmode@basic:
      shard-kbl:          FAIL (fdo#99912) -> PASS

fdo#102252 https://bugs.freedesktop.org/show_bug.cgi?id=102252
fdo#105010 https://bugs.freedesktop.org/show_bug.cgi?id=105010
fdo#105900 https://bugs.freedesktop.org/show_bug.cgi?id=105900
fdo#106680 https://bugs.freedesktop.org/show_bug.cgi?id=106680
fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912

== Participating hosts (5 -> 5) ==

No changes in participating hosts

== Build changes ==

* Linux: CI_DRM_4635 -> Patchwork_9893

CI_DRM_4635: a9f34f7e3bab765e2b1320a1b154a76be38602a7 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4589: 779d2d42f9db6a2797d1ef50036af6fac4e62e73 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_9893: b513210d05436fa3906e4d9258ceca693b6fe7ca @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_9893/shards.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx