platform/x86: acer-wmi: refactor function has_cap

Refactor function has_cap in order to avoid returning integer values, when instead it should return booleans.

This code was detected with the help of Coccinelle.

Signed-off-by Gustavo A. R. Silva <[email protected]>

---
Changes in v2:
Remove parentheses and unnecessary code. Thank you all for the feedback!

 drivers/platform/x86/acer-wmi.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

drivers/platform/x86/acer-wmi.c +1 -4

index 8952173..3294bb2 100644
@@ -672,10 +672,7 @@ static void __init find_quirks(void)
 
 static bool has_cap(u32 cap)
 {
-	if ((interface->capability & cap) != 0)
-		return 1;
-
-	return 0;
+	return interface->capability & cap;
 }
 
 /*

Signature · 1 line

2.7.4

Hi Gustavo,

Sorry for my delay!

Quoted 5 lines · Gustavo A. R. Silva

Refactor function has_cap in order to avoid returning integer values, when instead it should return booleans.

This code was detected with the help of Coccinelle.

Quoted 1 line

Signed-off-by Gustavo A. R. Silva <[email protected]>

Thanks for your patch and also thank Andy and Joe's help.

Please feel free to add:

Reviewed-by "Lee, Chun-Yi" <[email protected]>

Joey Lee

Quoted 27 lines

---
Changes in v2:
Remove parentheses and unnecessary code. Thank you all for the feedback!

 drivers/platform/x86/acer-wmi.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

drivers/platform/x86/acer-wmi.c +1 -5

index 8952173..3294bb2 100644
@@ -672,10 +672,7 @@ static void __init find_quirks(void)
 
 static bool has_cap(u32 cap)
 {
-     if ((interface->capability & cap) != 0)
-             return 1;
-
-     return 0;
+     return interface->capability & cap;
 }
 
 /*
--

2.7.4