Skip to contentSkip to conversation

execve: rewrite to newlib

PATCH New Li Wang 2 participants 2 messages Aug 9, 2018 – Aug 14, 2018

lore
Share & tools
lore

Li Wang

author
#0 lore raw

PATCH v2 1/1 execve: rewrite to newlib

execve01: Put IPC_ENV_VAR in envp[] to propagate environment vairiable
to child in execve().

execve02/3/4: Just rewrite tests in new API.

execve05: Verify execve(2) system call by spawning a few(nchild) children,
each of which would execute "execve_child" simultaneously.

execve_child: Modify to be used by more testcase.

---

Notes:
v1 --> v2:

* remove SAFE_WAITPID() in parent process
* remove .needs_root
* use the resource_files[] array
* remove the USAGE and RESTRICTIONS
* remove getpid() part
* remove UCLINUX part
* remove separate function for option parsing
* take use of TST_CHECKPOINT_WAKE2(0, nchild)

 runtest/syscalls                                  |   2 +-
 testcases/kernel/syscalls/execve/execve01.c       |  88 ++++-----
 testcases/kernel/syscalls/execve/execve01_child.c |  58 +++---
 testcases/kernel/syscalls/execve/execve02.c       | 106 +++++------
 testcases/kernel/syscalls/execve/execve03.c       | 217 ++++++++--------------
 testcases/kernel/syscalls/execve/execve04.c       | 121 ++++--------
 testcases/kernel/syscalls/execve/execve05.c       | 216 ++++++---------------
 testcases/kernel/syscalls/execve/execve_child.c   |  45 +++--
 8 files changed, 309 insertions(+), 544 deletions(-)
runtest/syscalls +1 -1
index dc72484..d3dfde5 100644
@@ -145,7 +145,7 @@ execve01 execve01
 execve02 execve02
 execve03 execve03
 execve04 execve04
-execve05 execve05 20 $LTPROOT/testcases/bin/execve05 $LTPROOT/testcases/bin/execve05 4
+execve05 execve05 -i 5 -n 32
 execvp01 execvp01
 
 exit01 exit01
testcases/kernel/syscalls/execve/execve01.c +31 -57

117 lines not on this page · raw message

testcases/kernel/syscalls/execve/execve01_child.c +26 -32

81 lines not on this page · raw message

testcases/kernel/syscalls/execve/execve02.c +42 -64

159 lines not on this page · raw message

testcases/kernel/syscalls/execve/execve03.c +82 -135

265 lines not on this page · raw message

testcases/kernel/syscalls/execve/execve04.c +40 -81

161 lines not on this page · raw message

testcases/kernel/syscalls/execve/execve05.c +60 -156

254 lines not on this page · raw message

testcases/kernel/syscalls/execve/execve_child.c +27 -18

59 lines not on this page · raw message

Signature · 1 line
2.9.5
#1 lore raw

PATCH v2 1/1 execve: rewrite to newlib

Hi!
Pushed with minor adjustments, thanks.

Apart from simple formatting fixed (removed trailing whitespace) I've removed needs_root from execve04 and changed exeve_child.c to check for argc > 1 in case that we do strcmp() othewise the child will segfault when executed without parameters.

Signature · 2 lines
Cyril Hrubis
[email protected]