wimax: usb-tx: mark expected switch fall-through
Subsystems (2)
PATCH 1/1 wimax: usb-tx: mark expected switch fall-through
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.
Notice that in this particular case, I placed the "fall through" annotation at the bottom of the case, which is what GCC is expecting to find.
Addresses-Coverity-ID: 115075 ("Missing break in switch")
--- drivers/net/wimax/i2400m/usb-tx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/wimax/i2400m/usb-tx.c +1 -1
@@ -131,12 +131,12 @@ int i2400mu_tx(struct i2400mu *i2400mu, struct i2400m_msg_hdr *tx_msg,dev_err (dev,"BM-CMD: too many stalls in " "URB; resetting device\n" );usb_queue_reset_device (i2400mu->usb_iface); -/* fallthrough */ }else {usb_clear_halt (i2400mu->usb_dev, usb_pipe);msleep (10 );/* give the device some time */ goto retry; } +/* fall through */ case -EINVAL :/* while removing driver */ case -ENODEV :/* dev disconnect ... */ case -ENOENT :/* just ignore it */
Signature · 1 line
2.7.4
From: "Gustavo A. R. Silva" <[email protected]>
Date: Thu, 9 Aug 2018 10:47:20 -0500
Quoted 9 lines
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.
Notice that in this particular case, I placed the "fall through" annotation at the bottom of the case, which is what GCC is expecting to find.
Addresses-Coverity-ID: 115075 ("Missing break in switch")
Signed-off-by Gustavo A. R. Silva <[email protected]>
Applied.