Skip to contentSkip to conversation

Fix for a minor typo in nvme host/target fc.c

PATCH New Milan P. Gandhi 3 participants 3 messages Aug 10, 2018 – Sep 11, 2018

Subsystems (3)
NVMe NVMe target NVMe FC transport
lore
Share & tools
lore

Milan P. Gandhi

author
#0 lore raw

PATCH 1/1 Fix for a minor typo in nvme host/target fc.c

This is a minor fix for a typo in drivers/nvme/host/fc.c and drivers/nvme/target/fc.c:

Signed-off-by Milan P. Gandhi <mgandhi at redhat.com>
---
 drivers/nvme/host/fc.c   | 4 ++--
 drivers/nvme/target/fc.c | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)
drivers/nvme/host/fc.c +2 -2
index 9bac912173ba..320b5f3f9794 100644
@@ -1385,7 +1385,7 @@ nvme_fc_disconnect_assoc_done(struct nvmefc_ls_req *lsreq, int status)
 
 	__nvme_fc_finish_ls_req(lsop);
 
-	/* fc-nvme iniator doesn't care about success or failure of cmd */
+	/* fc-nvme initiator doesn't care about success or failure of cmd */
 
 	kfree(lsop);
 }

@@ -3158,7 +3158,7 @@ nvme_fc_parse_traddr(struct nvmet_fc_traddr *traddr, char *buf, size_t blen)
 	substring_t wwn = { name, &name[sizeof(name)-1] };
 	int nnoffset, pnoffset;
 
-	/* validate it string one of the 2 allowed formats */
+	/* validate if string is one of the 2 allowed formats */
 	if (strnlen(buf, blen) == NVME_FC_TRADDR_MAXLENGTH &&
 			!strncmp(buf, "nn-0x", NVME_FC_TRADDR_OXNNLEN) &&
 			!strncmp(&buf[NVME_FC_TRADDR_MAX_PN_OFFSET],
drivers/nvme/target/fc.c +1 -1
index 29b4b236afd8..a3905673e17f 100644
@@ -2468,7 +2468,7 @@ nvme_fc_parse_traddr(struct nvmet_fc_traddr *traddr, char *buf, size_t blen)
 	substring_t wwn = { name, &name[sizeof(name)-1] };
 	int nnoffset, pnoffset;
 
-	/* validate it string one of the 2 allowed formats */
+	/* validate if string is one of the 2 allowed formats */
 	if (strnlen(buf, blen) == NVME_FC_TRADDR_MAXLENGTH &&
 			!strncmp(buf, "nn-0x", NVME_FC_TRADDR_OXNNLEN) &&
 			!strncmp(&buf[NVME_FC_TRADDR_MAX_PN_OFFSET],
Signature · 1 line
2.14.3
#1 lore raw

PATCH 1/1 Fix for a minor typo in nvme host/target fc.c

Quoted 36 lines · Milan P. Gandhi

This is a minor fix for a typo in drivers/nvme/host/fc.c and drivers/nvme/target/fc.c:

Signed-off-by Milan P. Gandhi <mgandhi at redhat.com>
---
  drivers/nvme/host/fc.c   | 4 ++--
  drivers/nvme/target/fc.c | 2 +-
  2 files changed, 3 insertions(+), 3 deletions(-)
drivers/nvme/host/fc.c +2 -2
index 9bac912173ba..320b5f3f9794 100644
@@ -1385,7 +1385,7 @@ nvme_fc_disconnect_assoc_done(struct nvmefc_ls_req *lsreq, int status)
 
  	__nvme_fc_finish_ls_req(lsop);
 
-	/* fc-nvme iniator doesn't care about success or failure of cmd */
+	/* fc-nvme initiator doesn't care about success or failure of cmd */
 
  	kfree(lsop);
  }

@@ -3158,7 +3158,7 @@ nvme_fc_parse_traddr(struct nvmet_fc_traddr *traddr, char *buf, size_t blen)
  	substring_t wwn = { name, &name[sizeof(name)-1] };
  	int nnoffset, pnoffset;
 
-	/* validate it string one of the 2 allowed formats */
+	/* validate if string is one of the 2 allowed formats */
  	if (strnlen(buf, blen) == NVME_FC_TRADDR_MAXLENGTH &&
  			!strncmp(buf, "nn-0x", NVME_FC_TRADDR_OXNNLEN) &&
  			!strncmp(&buf[NVME_FC_TRADDR_MAX_PN_OFFSET],
drivers/nvme/target/fc.c +0 -0
index 29b4b236afd8..a3905673e17f 100644

drivers/nvme/target/fc.c nvme_fc_parse_traddr(struct nvmet_fc_traddr *traddr, char *buf, size_t blen) · line 2474

Quoted 8 lines
drivers/nvme/target/fc.c +1 -1
@@ -2468,7 +2468,7 @@ nvme_fc_parse_traddr(struct nvmet_fc_traddr *traddr, char *buf, size_t blen)
  	substring_t wwn = { name, &name[sizeof(name)-1] };
  	int nnoffset, pnoffset;
 
-	/* validate it string one of the 2 allowed formats */
+	/* validate if string is one of the 2 allowed formats */
  	if (strnlen(buf, blen) == NVME_FC_TRADDR_MAXLENGTH &&
  			!strncmp(buf, "nn-0x", NVME_FC_TRADDR_OXNNLEN) &&
  			!strncmp(&buf[NVME_FC_TRADDR_MAX_PN_OFFSET],
Reviewed-by ? James Smart <james.smart at broadcom.com>

-- james