libjwt: new package.

PATCH New Mikael 3 participants 8 messages Aug 11, 2018 – Aug 21, 2018

lore

Share & tools

lore

Mikael

author

2018-08-11 20:29 UTC #0 lore raw

PATCH 1/1 libjwt: new package.

Signed-off-by Mikael <[email protected]>

---
 package/libjwt/Config.in   | 13 +++++++++++++
 package/libjwt/libjwt.hash |  2 ++
 package/libjwt/libjwt.mk   | 14 ++++++++++++++
 3 files changed, 29 insertions(+)
 create mode 100644 package/libjwt/Config.in
 create mode 100644 package/libjwt/libjwt.hash
 create mode 100644 package/libjwt/libjwt.mk

package/libjwt/Config.in new file +13 -0

new file mode 100644
index 0000000000..81e33e6d93
@@ -0,0 +1,13 @@
+config BR2_PACKAGE_LIBJWT
+	bool "libjwt"
+	depends on BR2_INSTALL_LIBSTDCPP
+	select BR2_PACKAGE_JANSSON
+	select BR2_PACKAGE_OPENSSL
+	help
+	  JSON Web Tokens are an open, industry standard RFC 7519
+	  method for representing claims securely between two parties.
+
+	  https://github.com/benmcollins/libjwt
+
+comment "libjwt needs a toolchain w/ C++"
+	depends on !BR2_INSTALL_LIBSTDCPP

package/libjwt/libjwt.hash new file +2 -0

new file mode 100644
index 0000000000..c8b7ed168a
@@ -0,0 +1,2 @@
+#Locally computed
+sha256 cc694dfc3abe17d1f5cde4bf6714e39dc17f7cbad352a85ffb0fe6418c584076 libjwt-v1.9.0.tar.gz

package/libjwt/libjwt.mk new file +14 -0

new file mode 100644
index 0000000000..2007d6c541
@@ -0,0 +1,14 @@
+################################################################################
+#
+# libjwt
+#
+################################################################################
+
+LIBJWT_VERSION = v1.9.0
+LIBJWT_SITE = $(call github,benmcollins,libjwt,$(LIBJWT_VERSION))
+LIBJWT_INSTALL_STAGING = YES
+LIBJWT_DEPENDENCIES = jansson openssl
+LIBJWT_LICENSE = LGPL-3.0-only
+LIBJWT_LICENSE_FILES = COPYING.LIB
+
+$(eval $(cmake-package))

Signature · 1 line

2.17.1

Thomas Petazzoni

2018-08-12 12:39 UTC #1 lore raw

PATCH 1/1 libjwt: new package.

Hello Mikael,

First of all, thanks for your contribution!

Quoted 1 line · Mikael

Signed-off-by Mikael <[email protected]>

Could you use your full first name + last name when contributing? This is important for legal reasons.

package/libjwt/Config.in line 3

Quoted 9 lines

package/libjwt/Config.in new file +3 -0

new file mode 100644
index 0000000000..81e33e6d93
@@ -0,0 +1,13 @@
+config BR2_PACKAGE_LIBJWT
+	bool "libjwt"
+	depends on BR2_INSTALL_LIBSTDCPP

There is no C++ anywhere in this package, and none of the dependencies require C++. To me, it seems like the CMakeLists.txt should be changed from:

project (jwt)

project (jwt C)

which tells CMake that the project is using C only, and no C++.

package/libjwt/Config.in line 5

Quoted 2 lines

package/libjwt/Config.in new file +2 -0
+	select BR2_PACKAGE_JANSSON
+	select BR2_PACKAGE_OPENSSL

Are you sure OpenSSL is mandatory ? I see a possibility to use GnuTLS as well:

if (WITHOUT_OPENSSL)

	find_package (GnuTLS REQUIRED)
	set (FILES_TO_REMOVE ${CMAKE_CURRENT_SOURCE_DIR}/jwt-openssl.c)
	set (SSL_LIBRARY_INCLUDE_DIR ${GNUTLS_INCLUDE_DIR})
	set (SSL_LIBRARIES_DEBUG ${GNUTLS_LIBRARY})
	set (SSL_LIBRARIES_OPTIMIZED ${GNUTLS_LIBRARY})
else ()
	if (MSVC AND STATIC_RUNTIME)
		set (OPENSSL_MSVC_STATIC_RT TRUE)
	endif ()
	find_package (OpenSSL REQUIRED)
	set (FILES_TO_REMOVE ${CMAKE_CURRENT_SOURCE_DIR}/jwt-gnutls.c)
	set (SSL_LIBRARY_INCLUDE_DIR ${OPENSSL_INCLUDE_DIR})
	if (MSVC)
		set (SSL_LIBRARIES_DEBUG ${LIB_EAY_DEBUG} ${SSL_EAY_DEBUG})
		set (SSL_LIBRARIES_OPTIMIZED ${LIB_EAY_RELEASE} ${SSL_EAY_RELEASE})
	else ()
		set (SSL_LIBRARIES_DEBUG ${OPENSSL_CRYPTO_LIBRARY})
		set (SSL_LIBRARIES_OPTIMIZED ${OPENSSL_CRYPTO_LIBRARY})
	endif ()

endif ()

So perhaps, you could do:

select BR2_PACKAGE_OPENSSL if !BR2_PACKAGE_GNUTLS

And the in the .mk file, pass -DWITHOUT_OPENSSL= if GnuTLS is available, but not OpenSSL:

ifeq ($(BR2_PACKAGE_OPENSSL),y)
LIBJWT_DEPENDENCIES += openssl
else
LIBJWT_DEPENDENCIES += gnutls
LIBJWT_CONF_OPTS += -DWITHOUT_OPENSSL=1
endif

Quoted 14 lines

package/libjwt/Config.in new file +8 -0

+	help
+	  JSON Web Tokens are an open, industry standard RFC 7519
+	  method for representing claims securely between two parties.
+
+	  https://github.com/benmcollins/libjwt
+
+comment "libjwt needs a toolchain w/ C++"
+	depends on !BR2_INSTALL_LIBSTDCPP

package/libjwt/libjwt.hash new file +0 -0

new file mode 100644
index 0000000000..c8b7ed168a

package/libjwt/libjwt.hash line 2

Quoted 2 lines

package/libjwt/libjwt.hash new file +2 -0

@@ -0,0 +1,2 @@
+#Locally computed
+sha256 cc694dfc3abe17d1f5cde4bf6714e39dc17f7cbad352a85ffb0fe6418c584076 libjwt-v1.9.0.tar.gz

Could you add the hash of the COPYING.LIB license file ?

Quoted 7 lines

package/libjwt/libjwt.mk new file +1 -0

new file mode 100644
index 0000000000..2007d6c541
@@ -0,0 +1,14 @@
+################################################################################

package/libjwt/libjwt.mk line 11

Quoted 10 lines

package/libjwt/libjwt.mk new file +10 -0

+#
+# libjwt
+#
+################################################################################
+
+LIBJWT_VERSION = v1.9.0
+LIBJWT_SITE = $(call github,benmcollins,libjwt,$(LIBJWT_VERSION))
+LIBJWT_INSTALL_STAGING = YES
+LIBJWT_DEPENDENCIES = jansson openssl
+LIBJWT_LICENSE = LGPL-3.0-only

We use LGPL-3.0 in this case (i.e we don't obey strictly to SPDX, we probably should, but we don't yet, and we should have a single package deviates from what we do in the rest of Buildroot).

package/libjwt/libjwt.mk line 14

Quoted 3 lines

package/libjwt/libjwt.mk new file +3 -0
+LIBJWT_LICENSE_FILES = COPYING.LIB
+
+$(eval $(cmake-package))

Finally, could you test this package with "utils/test-pkg" ? I am wondering if it builds properly in a static-only configuration. utils/test-pkg will test this for you.

Could you take into account those comments, and send an updated version ?

Thanks a lot!

Thomas Petazzoni

Signature · 3 lines

Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com

Mikael Eliasson

author

2018-08-12 16:08 UTC #2 lore raw

PATCH 1/1 libjwt: new package.

Hi Thomas,
Not used to using mailing lists so this may not be the correct way to send a follow up patch. It is attached.

I think I have made all the changes you requested. I had also missed including package/Config.in.

Tested with test-pkg -a:
47 builds, 0 skipped, 0 build failed, 0 legal-info failed

/Regards
Mikael

2018-08-12 14:39 GMT+02:00 Thomas Petazzoni <[email protected]>:

Quoted 138 lines

Hello Mikael,
First of all, thanks for your contribution!
Quoted 1 line · Mikael
Signed-off-by Mikael <[email protected]>
Could you use your full first name + last name when contributing? This is important for legal reasons.
package/libjwt/Config.in line 3
Quoted 9 lines
package/libjwt/Config.in new file +3 -0
new file mode 100644
index 0000000000..81e33e6d93
@@ -0,0 +1,13 @@
+config BR2_PACKAGE_LIBJWT
+     bool "libjwt"
+     depends on BR2_INSTALL_LIBSTDCPP
There is no C++ anywhere in this package, and none of the dependencies require C++. To me, it seems like the CMakeLists.txt should be changed from:
project (jwt)
to
project (jwt C)
which tells CMake that the project is using C only, and no C++.
package/libjwt/Config.in line 5
Quoted 2 lines
package/libjwt/Config.in new file +2 -0
+     select BR2_PACKAGE_JANSSON
+     select BR2_PACKAGE_OPENSSL
Are you sure OpenSSL is mandatory ? I see a possibility to use GnuTLS as well:
if (WITHOUT_OPENSSL)
        find_package (GnuTLS REQUIRED)
        set (FILES_TO_REMOVE ${CMAKE_CURRENT_SOURCE_DIR}/jwt-openssl.c)
        set (SSL_LIBRARY_INCLUDE_DIR ${GNUTLS_INCLUDE_DIR})
        set (SSL_LIBRARIES_DEBUG ${GNUTLS_LIBRARY})
        set (SSL_LIBRARIES_OPTIMIZED ${GNUTLS_LIBRARY})
else ()
        if (MSVC AND STATIC_RUNTIME)
                set (OPENSSL_MSVC_STATIC_RT TRUE)
        endif ()
        find_package (OpenSSL REQUIRED)
        set (FILES_TO_REMOVE ${CMAKE_CURRENT_SOURCE_DIR}/jwt-gnutls.c)
        set (SSL_LIBRARY_INCLUDE_DIR ${OPENSSL_INCLUDE_DIR})
        if (MSVC)
                set (SSL_LIBRARIES_DEBUG ${LIB_EAY_DEBUG} ${SSL_EAY_DEBUG})
                set (SSL_LIBRARIES_OPTIMIZED ${LIB_EAY_RELEASE}
${SSL_EAY_RELEASE})
        else ()
                set (SSL_LIBRARIES_DEBUG ${OPENSSL_CRYPTO_LIBRARY})
                set (SSL_LIBRARIES_OPTIMIZED ${OPENSSL_CRYPTO_LIBRARY})
        endif ()
endif ()
So perhaps, you could do:
select BR2_PACKAGE_OPENSSL if !BR2_PACKAGE_GNUTLS
And the in the .mk file, pass -DWITHOUT_OPENSSL= if GnuTLS is available, but not OpenSSL:
ifeq ($(BR2_PACKAGE_OPENSSL),y)
LIBJWT_DEPENDENCIES += openssl
else
LIBJWT_DEPENDENCIES += gnutls
LIBJWT_CONF_OPTS += -DWITHOUT_OPENSSL=1
endif
Quoted 14 lines
package/libjwt/Config.in new file +8 -0
+     help
+       JSON Web Tokens are an open, industry standard RFC 7519
+       method for representing claims securely between two parties.
+
+       https://github.com/benmcollins/libjwt
+
+comment "libjwt needs a toolchain w/ C++"
+     depends on !BR2_INSTALL_LIBSTDCPP
package/libjwt/libjwt.hash new file +0 -0
new file mode 100644
index 0000000000..c8b7ed168a
package/libjwt/libjwt.hash line 2
Quoted 2 lines
package/libjwt/libjwt.hash new file +2 -0
@@ -0,0 +1,2 @@
+#Locally computed
+sha256 cc694dfc3abe17d1f5cde4bf6714e39dc17f7cbad352a85ffb0fe6418c584076
libjwt-v1.9.0.tar.gz
Could you add the hash of the COPYING.LIB license file ?
package/libjwt/libjwt.mk line 1
Quoted 7 lines
package/libjwt/libjwt.mk new file +1 -0
new file mode 100644
index 0000000000..2007d6c541
@@ -0,0 +1,14 @@
+###########################################################
#####################
package/libjwt/libjwt.mk
Quoted 4 lines
package/libjwt/libjwt.mk new file +4 -0
+#
+# libjwt
+#
+###########################################################
#####################
package/libjwt/libjwt.mk line 11
Quoted 6 lines
package/libjwt/libjwt.mk new file +6 -0
+
+LIBJWT_VERSION = v1.9.0
+LIBJWT_SITE = $(call github,benmcollins,libjwt,$(LIBJWT_VERSION))
+LIBJWT_INSTALL_STAGING = YES
+LIBJWT_DEPENDENCIES = jansson openssl
+LIBJWT_LICENSE = LGPL-3.0-only
We use LGPL-3.0 in this case (i.e we don't obey strictly to SPDX, we probably should, but we don't yet, and we should have a single package deviates from what we do in the rest of Buildroot).
package/libjwt/libjwt.mk line 14
Quoted 3 lines
package/libjwt/libjwt.mk new file +3 -0
+LIBJWT_LICENSE_FILES = COPYING.LIB
+
+$(eval $(cmake-package))
Finally, could you test this package with "utils/test-pkg" ? I am wondering if it builds properly in a static-only configuration. utils/test-pkg will test this for you.
Could you take into account those comments, and send an updated version ?
Thanks a lot!
Thomas Petazzoni
--
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering
https://bootlin.com

Signature · 18 lines

Mikael Eliasson
Telefon:
+46703900837
Email:
mikael at robomagi.com
Adress:
Robomagi AB
T?ngringsgatan 26A 78430 Borl?nge
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20180812/1060078a/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-libjwt-new-package.patch
Type: text/x-patch
Size: 3520 bytes
Desc: not available
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20180812/1060078a/attachment.bin>

Yann E. MORIN

2018-08-12 19:25 UTC #3 lore raw

PATCH 1/1 libjwt: new package.

Mickael, All,

On 2018-08-12 18:08 +0200, Mikael Eliasson spake thusly:

Quoted 2 lines

Hi Thomas,
Not used to using mailing lists so this may not be the correct way to send a follow up patch. It is attached.

Just send it again with git send-email.

Also, it is customary to not top-post like you did, but to reply in-line (like I'm doing).

Quoted 3 lines

I think I have made all the changes you requested. I had also missed including?package/Config.in. Tested with test-pkg -a:
47 builds, 0 skipped, 0 build failed, 0 legal-info failed

Great! :-)

Yet, I have a very small comment, see below...

[--SNIP--]

Quoted 9 lines

package/libjwt/0001-Declare-project-C-only.patch new file +3 -0

new file mode 100644
index 0000000000..cfb3cc8425
@@ -0,0 +1,16 @@
+Declares project C only.
+
+Signed-off-by: Mikael Eliasson <[email protected]>

package/libjwt/0001-Declare-project-C-only.patch line 13

Quoted 10 lines

package/libjwt/0001-Declare-project-C-only.patch new file +10 -0

+diff --git a/CMakeLists.txt b/CMakeLists.txt
+index 5cd1910..aefb87d 100644
+--- a/CMakeLists.txt
++++ b/CMakeLists.txt
+@@ -4,7 +4,7 @@ if (MSVC)
+ 	set (CMAKE_SYSTEM_VERSION 8.1 CACHE TYPE INTERNAL FORCE)
+ endif ()
+ 
+-project (jwt)
++project (jwt C)

It would be great if you were to send this change upstream, so that we can drop this patch next time we update the package.

package/libjwt/0001-Declare-project-C-only.patch line 15

Quoted 2 lines

package/libjwt/0001-Declare-project-C-only.patch new file +2 -0
+ list (APPEND CMAKE_MODULE_PATH "${CMAKE_CURRENT_SOURCE_DIR}/cmake")
+ 

[--SNIP--]

Quoted 8 lines

package/libjwt/libjwt.mk new file +2 -0

new file mode 100644
index 0000000000..8863fb436a
@@ -0,0 +1,21 @@
+################################################################################
+#

package/libjwt/libjwt.mk line 12

Quoted 10 lines

package/libjwt/libjwt.mk new file +10 -0

+# libjwt
+#
+################################################################################
+
+LIBJWT_VERSION = v1.9.0
+LIBJWT_SITE = $(call github,benmcollins,libjwt,$(LIBJWT_VERSION))
+LIBJWT_INSTALL_STAGING = YES
+LIBJWT_DEPENDENCIES = jansson
+LIBJWT_LICENSE = LGPL-3.0
+LIBJWT_LICENSE_FILES = COPYING.LIB

I know there is no strongly documented ordering, but I like that the descriptive metadata goes first, while the building metadata goes last, with adequate spacing to separate the types of data, like so:

LIBJWT_VERSION = v1.9.0
LIBJWT_SITE = $(call github,benmcollins,libjwt,$(LIBJWT_VERSION)) LIBJWT_LICENSE = LGPL-3.0
LIBJWT_LICENSE_FILES = COPYING.LIB

LIBJWT_DEPENDENCIES = jansson

LIBJWT_INSTALL_STAGING = YES

It kind of follows some "logic": where to get it, what itslicensing is, what it needs, what it provides, how we build it.

No need to re-send. If a maintainer agrees, he can re-reorder when applying, or he can just apply it as-is if he believes that is OK as-is.

Regards,
Yann E. MORIN.

Quoted 16 lines

package/libjwt/libjwt.mk new file +8 -0

+ifeq ($(BR2_PACKAGE_OPENSSL),y)
+LIBJWT_DEPENDENCIES += openssl
+else
+LIBJWT_DEPENDENCIES += gnutls
+LIBJWT_CONF_OPTS += -DWITHOUT_OPENSSL=1
+endif
+
+$(eval $(cmake-package))

Signature · 7 lines

2.17.1


_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

Signature · 6 lines

.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

Mikael Eliasson

author

2018-08-21 18:34 UTC #4 lore raw

PATCH 1/1 libjwt: new package.

Hi,
2018-08-12 21:25 GMT+02:00 Yann E. MORIN <[email protected]>:

Quoted 81 lines

Mickael, All,
On 2018-08-12 18:08 +0200, Mikael Eliasson spake thusly:
Quoted 2 lines
Hi Thomas,
Not used to using mailing lists so this may not be the correct way to
send a follow up patch. It is attached.
Just send it again with git send-email.
Also, it is customary to not top-post like you did, but to reply in-line (like I'm doing).
Quoted 1 line
I think I have made all the changes you requested. I had also missed
including package/Config.in.
Quoted 2 lines
Tested with test-pkg -a:
47 builds, 0 skipped, 0 build failed, 0 legal-info failed
Great! :-)
Yet, I have a very small comment, see below...
[--SNIP--]
Review
Quoted 1 line
(quoted diff) +0 -0
b/package/libjwt/0001-Declare-project-C-only.patch
Quoted 8 lines
new file mode 100644
index 0000000000..cfb3cc8425
package/libjwt/0001-Declare-project-C-only.patch new file +3 -0
@@ -0,0 +1,16 @@
+Declares project C only.
+
+Signed-off-by: Mikael Eliasson <[email protected]>
package/libjwt/0001-Declare-project-C-only.patch line 13
Quoted 10 lines
package/libjwt/0001-Declare-project-C-only.patch new file +10 -0
+diff --git a/CMakeLists.txt b/CMakeLists.txt
+index 5cd1910..aefb87d 100644
+--- a/CMakeLists.txt
++++ b/CMakeLists.txt
+@@ -4,7 +4,7 @@ if (MSVC)
+     set (CMAKE_SYSTEM_VERSION 8.1 CACHE TYPE INTERNAL FORCE)
+ endif ()
+
+-project (jwt)
++project (jwt C)
It would be great if you were to send this change upstream, so that we can drop this patch next time we update the package.
package/libjwt/0001-Declare-project-C-only.patch line 15
Quoted 2 lines
package/libjwt/0001-Declare-project-C-only.patch new file +2 -0
+ list (APPEND CMAKE_MODULE_PATH "${CMAKE_CURRENT_SOURCE_DIR}/cmake")
+
[--SNIP--]
package/libjwt/libjwt.mk line 1
Quoted 7 lines
package/libjwt/libjwt.mk new file +1 -0
new file mode 100644
index 0000000000..8863fb436a
@@ -0,0 +1,21 @@
+###########################################################
#####################
package/libjwt/libjwt.mk
Quoted 4 lines
package/libjwt/libjwt.mk new file +4 -0
+#
+# libjwt
+#
+###########################################################
#####################
package/libjwt/libjwt.mk line 12
Quoted 7 lines
package/libjwt/libjwt.mk new file +7 -0
+
+LIBJWT_VERSION = v1.9.0
+LIBJWT_SITE = $(call github,benmcollins,libjwt,$(LIBJWT_VERSION))
+LIBJWT_INSTALL_STAGING = YES
+LIBJWT_DEPENDENCIES = jansson
+LIBJWT_LICENSE = LGPL-3.0
+LIBJWT_LICENSE_FILES = COPYING.LIB
I know there is no strongly documented ordering, but I like that the descriptive metadata goes first, while the building metadata goes last, with adequate spacing to separate the types of data, like so:
LIBJWT_VERSION = v1.9.0
LIBJWT_SITE = $(call github,benmcollins,libjwt,$(LIBJWT_VERSION)) LIBJWT_LICENSE = LGPL-3.0
LIBJWT_LICENSE_FILES = COPYING.LIB
LIBJWT_DEPENDENCIES = jansson

Quoted 8 lines

LIBJWT_INSTALL_STAGING = YES
It kind of follows some "logic": where to get it, what itslicensing is, what it needs, what it provides, how we build it.
No need to re-send. If a maintainer agrees, he can re-reorder when applying, or he can just apply it as-is if he believes that is OK as-is.

Is there anything else you need me to do to include this package? I cannot see that it has been added in github yet.

Quoted 36 lines

Regards,
Yann E. MORIN.
Quoted 12 lines
package/libjwt/libjwt.mk new file +8 -1
+ifeq ($(BR2_PACKAGE_OPENSSL),y)
+LIBJWT_DEPENDENCIES += openssl
+else
+LIBJWT_DEPENDENCIES += gnutls
+LIBJWT_CONF_OPTS += -DWITHOUT_OPENSSL=1
+endif
+
+$(eval $(cmake-package))
--
2.17.1
Quoted 4 lines
_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.-
-------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics'
conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___
     |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is
no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v
 conspiracy.  |
'------------------------------^-------^------------------^- -------------------'

Signature · 11 lines

Mikael Eliasson
Telefon:
+46703900837
Email:
mikael at robomagi.com
Adress:
Robomagi AB
T?ngringsgatan 26A 78430 Borl?nge
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20180821/92ed0ce2/attachment.html>

Yann E. MORIN

2018-08-21 19:54 UTC #5 lore raw

PATCH 1/1 libjwt: new package.

Mikael, All,

On 2018-08-21 20:34 +0200, Mikael Eliasson spake thusly:

Quoted 2 lines

Is there anything else you need me to do to include this package? I cannot see that it has been added in github yet.

Don;t worry, it is not lost, but:

1. There are currently 197 patches pending:
https://patchwork.ozlabs.org/project/buildroot/list/

2. We are in feature-freeze for the release scheduled by the end of the month.

3. The Github repository is not the official tree; it is only a mirror. The official tree is: https://git.buildroot.org/buildroot/

Regards,
Yann E. MORIN.

Signature · 6 lines

.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

Mikael Eliasson

author

2018-08-21 20:20 UTC #6 lore raw

PATCH 1/1 libjwt: new package.

Hi,

2018-08-21 21:54 GMT+02:00 Yann E. MORIN <[email protected]>:

Quoted 8 lines

Mikael, All,
On 2018-08-21 20:34 +0200, Mikael Eliasson spake thusly:
Quoted 2 lines
Is there anything else you need me to do to include this package? I cannot see that it has been added in github yet.
Don;t worry, it is not lost, but:

Quoted 8 lines

1. There are currently 197 patches pending:
https://patchwork.ozlabs.org/project/buildroot/list/
2. We are in feature-freeze for the release scheduled by the end of the month.
3. The Github repository is not the official tree; it is only a mirror. The official tree is: https://git.buildroot.org/buildroot/

OK. Just wanted to know if it was worth putting in the effort on the next patch I'm working on.

Quoted 16 lines

Regards,
Yann E. MORIN.

--
.-----------------.--------------------.------------------.-
-------------------.

|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics'
conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___
     |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is
no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v
 conspiracy.  |

Quoted 3 lines

'------------------------------^-------^------------------^- -------------------'

/Thanks
Mikael

Signature · 11 lines

Mikael Eliasson
Telefon:
+46703900837
Email:
mikael at robomagi.com
Adress:
Robomagi AB
T?ngringsgatan 26A 78430 Borl?nge
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20180821/8d00b3cb/attachment.html>

Thomas Petazzoni

2018-08-21 20:25 UTC #7 lore raw

PATCH 1/1 libjwt: new package.

Hello,

Quoted 5 lines · Mikael Eliasson

Quoted 5 lines
Don;t worry, it is not lost, but:
1. There are currently 197 patches pending:
https://patchwork.ozlabs.org/project/buildroot/list/

Quoted 8 lines

Quoted 5 lines
2. We are in feature-freeze for the release scheduled by the end of the month.
3. The Github repository is not the official tree; it is only a mirror. The official tree is: https://git.buildroot.org/buildroot/
OK. Just wanted to know if it was worth putting in the effort on the next patch I'm working on.

Yes, it is definitely worth the effort. The latency to get patches merged can be pretty high, but no patches gets forgotten, thanks to our patch tracking system.

New packages are rarely controversial (unless they have some significant complexity or strange things) and are very likely to be merged. But it does take some time.

Thanks for your contributions!

Thomas

Signature · 3 lines

Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com