Skip to contentSkip to conversation

drm/amdgpu/sriov: sriov won't support gfx off

PATCH In review Tiecheng Zhou 2 participants 2 messages Aug 13, 2018 1 message not in the archive

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/amdgpu/sriov: sriov won't support gfx off

---
 drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c +2 -0
index 790fd54..e67ab25 100644
@@ -389,6 +389,8 @@ void amdgpu_gfx_compute_mqd_sw_fini(struct amdgpu_device *adev)
 
 void amdgpu_gfx_off_ctrl(struct amdgpu_device *adev, bool enable)
 {
+	if (amdgpu_sriov_vf(adev))
+		return;
 	if (!(adev->powerplay.pp_feature & PP_GFXOFF_MASK))
 		return;
 
Signature · 6 lines
2.7.4

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): 1534140202-1939-1-git-send-email-Tiecheng.Zhou-5C7GfCeVMHo@public.gmane.org

#2 lore raw
Quoted 1 line · Tiecheng Zhou

gfxoff feature is only able to be enabled after configure PP_GFXOFF_MASK to ppfeaturemask. In other words, it isn't enabled by default. It doesn't need this checking and just bypass amdgpu_gfx_off_ctrl is not correct to set gfxoff disabled.

Thanks,
Ray

Quoted 24 lines
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c +2 -0
index 790fd54..e67ab25 100644
@@ -389,6 +389,8 @@ void amdgpu_gfx_compute_mqd_sw_fini(struct amdgpu_device *adev)
 
 void amdgpu_gfx_off_ctrl(struct amdgpu_device *adev, bool enable)
 {
+	if (amdgpu_sriov_vf(adev))
+		return;
 	if (!(adev->powerplay.pp_feature & PP_GFXOFF_MASK))
 		return;
 
Signature · 6 lines
2.7.4

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx