ARM: s3c24xx: Remove empty gta02_pmu children probe
Subsystems (3)
Krzysztof Kozlowski
maintainerPATCH 1/1 ARM: s3c24xx: Remove empty gta02_pmu children probe
Since commit 67e67df8da72 ("gta02: Use pcf50633 backlight driver instead of platform backlight driver.") the list of gta02 pmu children is empty therefore looping through it and adding devices is a no-op.
This also fixes the GCC v8.1 W=1 warning:
arch/arm/mach-s3c24xx/mach-gta02.c: In function 'gta02_pmu_attach_child_devices':
arch/arm/mach-s3c24xx/mach-gta02.c:538:16: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]
for (n = 0; n < ARRAY_SIZE(gta02_devices_pmu_children); n++)
^Signed-off-by Krzysztof Kozlowski <[email protected]>
--- arch/arm/mach-s3c24xx/mach-gta02.c | 42 -------------------------------------- 1 file changed, 42 deletions(-)
arch/arm/mach-s3c24xx/mach-gta02.c +0 -42
@@ -219,17 +219,6 @@ static void gta02_udc_vbus_draw(unsigned int ma)#define gta02_udc_vbus_draw NULL#endif -/* -* This is called when pc50633 is probed, unfortunately quite late in the -* day since it is an I2C bus device. Here we can belatedly define some -* platform devices with the advantage that we can mark the pcf50633 as the -* parent. This makes them get suspended and resumed with their parent -* the pcf50633 still around. -*/ - -static void gta02_pmu_attach_child_devices (struct pcf50633 *pcf); - -static char *gta02_batteries[] = {"battery" , };
@@ -355,7 +344,6 @@ static struct pcf50633_platform_data gta02_pcf_pdata = { }, }, - .probe_done = gta02_pmu_attach_child_devices, .mbc_event_callback = gta02_pmu_event_callback, };
@@ -512,36 +500,6 @@ static struct platform_device *gta02_devices[] __initdata = { &s3c_device_ts, }; -/* These guys DO need to be children of PMU. */ - -static struct platform_device *gta02_devices_pmu_children[] = { -}; - - -/* -* This is called when pc50633 is probed, quite late in the day since it is an -* I2C bus device. Here we can define platform devices with the advantage that -* we can mark the pcf50633 as the parent. This makes them get suspended and -* resumed with their parent the pcf50633 still around. All devices whose -* operation depends on something from pcf50633 must have this relationship -* made explicit like this, or suspend and resume will become an unreliable -* hellworld. -*/ - -static void gta02_pmu_attach_child_devices (struct pcf50633 *pcf) -{ -int n; - -/* Grab a copy of the now probed PMU pointer. */ - gta02_pcf = pcf; - -for (n =0 ; n <ARRAY_SIZE (gta02_devices_pmu_children); n++) - gta02_devices_pmu_children[n]->dev.parent = pcf->dev; - -platform_add_devices (gta02_devices_pmu_children, -ARRAY_SIZE (gta02_devices_pmu_children)); -} -static void gta02_poweroff (void ) {pcf50633_reg_set_bit_mask (gta02_pcf,PCF50633_REG_OOCSHDWN ,1 ,1 );
Signature · 1 line
2.14.1