Skip to contentSkip to conversation

Hack for perl module subdirectories

RFC PATCH New Christopher McCrory 3 participants 10 messages Aug 13, 2018 – Aug 15, 2018

lore
Share & tools
lore

Christopher McCrory

author
#0 lore raw

cover Hack for perl module subdirectories

When perl modules have Makefiles in subdirectories, not all of the arguments to Makefile.PL get propagated to subdirectory/Makefile.PL. This causes compile failures. Two examples are template-toolkit and xml-parser. A hack is to fix them after the usual configure step. Something like this:

$(SED) "s:^AR = .*:AR = $(TARGET_AR):g" $(@D)/Expat/Makefile

for AR, CC, xFLAGS, etc. This "works", but there should be a better way. Hence the RFC.

Also there is a package, libxml-parser-perl, that is a host only perl xml-parser package needed by host-intltool and metacity. Should they stay seprate or be merged?

Christopher McCrory (2):
perl-template-toolkit: new package
perl-xml-parser: new package

 DEVELOPERS                                         |  2 ++
 package/Config.in                                  |  2 ++
 package/perl-template-toolkit/Config.in            | 11 ++++++++
 .../perl-template-toolkit.hash                     |  6 ++++
 .../perl-template-toolkit/perl-template-toolkit.mk | 32 ++++++++++++++++++++++
 5 files changed, 53 insertions(+)
 create mode 100644 package/perl-template-toolkit/Config.in
 create mode 100644 package/perl-template-toolkit/perl-template-toolkit.hash
 create mode 100644 package/perl-template-toolkit/perl-template-toolkit.mk
Signature · 1 line
2.14.4
author
#1 lore raw

RFC PATCH 1/2 perl-template-toolkit: new package

Signed-off-by Christopher McCrory <[email protected]>
---
 DEVELOPERS                                         |  1 +
 package/Config.in                                  |  1 +
 package/perl-template-toolkit/Config.in            | 11 ++++++++
 .../perl-template-toolkit.hash                     |  6 ++++
 .../perl-template-toolkit/perl-template-toolkit.mk | 32 ++++++++++++++++++++++
 5 files changed, 51 insertions(+)
 create mode 100644 package/perl-template-toolkit/Config.in
 create mode 100644 package/perl-template-toolkit/perl-template-toolkit.hash
 create mode 100644 package/perl-template-toolkit/perl-template-toolkit.mk
DEVELOPERS +1 -0
index 6d0e3ecceb..d35cf3fb72 100644
@@ -501,6 +501,7 @@ F:	package/perl-params-util/
 F:	package/perl-sub-install/
 F:	package/perl-sys-meminfo/
 F:	package/perl-sys-mmap/
+F:	package/perl-template-toolkit/
 
 N:	Clayton Shotwell <[email protected]>
 F:	package/audit/
package/Config.in +1 -0
index 85046ae56e..6437cc0451 100644
@@ -728,6 +728,7 @@ menu "Perl libraries/modules"
 	source "package/perl-sub-install/Config.in"
 	source "package/perl-sys-meminfo/Config.in"
 	source "package/perl-sys-mmap/Config.in"
+	source "package/perl-template-toolkit/Config.in"
 	source "package/perl-time-hires/Config.in"
 	source "package/perl-timedate/Config.in"
 	source "package/perl-try-tiny/Config.in"
package/perl-template-toolkit/Config.in new file +11 -0
new file mode 100644
index 0000000000..1caca074aa
@@ -0,0 +1,11 @@
+config BR2_PACKAGE_PERL_TEMPLATE_TOOLKIT
+	bool "perl-template-toolkit"
+	depends on !BR2_STATIC_LIBS
+	select BR2_PACKAGE_PERL_APPCONFIG
+	help
+	  comprehensive template processing system
+
+	  https://metacpan.org/release/Template-Toolkit
+
+comment "perl-template-toolkit needs a toolchain w/ dynamic library"
+	depends on BR2_STATIC_LIBS
package/perl-template-toolkit/perl-template-toolkit.hash new file +6 -0
new file mode 100644
index 0000000000..54d4553695
@@ -0,0 +1,6 @@
+# retrieved by scancpan from http://cpan.metacpan.org/
+md5    a7fae5d4fe5918f33105d92a62134067 Template-Toolkit-2.27.tar.gz
+sha256 1311a403264d0134c585af0309ff2a9d5074b8ece23ece5660d31ec96bf2c6dc Template-Toolkit-2.27.tar.gz
+
+# computed by scancpan
+sha256 d897b2d98affd4f0489340e54ceb542383101e3d21408dfad025df71d770d842 README
package/perl-template-toolkit/perl-template-toolkit.mk new file +32 -0
new file mode 100644
index 0000000000..875437dead
@@ -0,0 +1,32 @@
+################################################################################
+#
+# perl-template-toolkit
+#
+################################################################################
+
+PERL_TEMPLATE_TOOLKIT_VERSION = 2.27
+PERL_TEMPLATE_TOOLKIT_SOURCE = Template-Toolkit-$(PERL_TEMPLATE_TOOLKIT_VERSION).tar.gz
+PERL_TEMPLATE_TOOLKIT_SITE = $(BR2_CPAN_MIRROR)/authors/id/A/AB/ABW
+PERL_TEMPLATE_TOOLKIT_DEPENDENCIES = perl-appconfig
+PERL_TEMPLATE_TOOLKIT_LICENSE = Artistic or GPL-1.0+
+PERL_TEMPLATE_TOOLKIT_LICENSE_FILES = README
+
+# There has got to be a better way... :(
+# Some arguments to Makefile.PL do not get propagated to subdirectories
+# similar to:
+# https://rt.cpan.org/Public/Bug/Display.html?id=28632
+define PERL_TEMPLATE_TOOLKIT_POST_CONFIGURE_SED
+        $(SED) "s:^AR = .*:AR = $(TARGET_AR):g" $(@D)/xs/Makefile
+        $(SED) "s:^FULL_AR = .*:FULL_AR = $(TARGET_AR):g" $(@D)/xs/Makefile
+        $(SED) "s:^CC = .*:CC = $(TARGET_CC):g" $(@D)/xs/Makefile
+        $(SED) "s:^CCFLAGS = .*:CCFLAGS = $(TARGET_CFLAGS):g" $(@D)/xs/Makefile
+        $(SED) "s:^LD = .*:LD = $(TARGET_CC):g" $(@D)/xs/Makefile
+        $(SED) "s:^LDDLFLAGS = .*:LDDLFLAGS = -shared $(TARGET_LDFLAGS):g" $(@D)/xs/Makefile
+        $(SED) "s:^LDLFLAGS = .*:LDLFLAGS = $(TARGET_LDFLAGS):g" $(@D)/xs/Makefile
+        $(SED) "s:^DESTDIR = .*:DESTDIR = $(TARGET_DIR):g" $(@D)/xs/Makefile
+endef
+
+PERL_TEMPLATE_TOOLKIT_POST_CONFIGURE_HOOKS += PERL_TEMPLATE_TOOLKIT_POST_CONFIGURE_SED
+
+
+$(eval $(perl-package))
Signature · 1 line
2.14.4
#2 lore raw

RFC PATCH 1/2 perl-template-toolkit: new package

2018-08-13 19:56 GMT+02:00 Christopher McCrory <[email protected]>:

Quoted 107 lines
Signed-off-by Christopher McCrory <[email protected]>
---
 DEVELOPERS                                         |  1 +
 package/Config.in                                  |  1 +
 package/perl-template-toolkit/Config.in            | 11 ++++++++
 .../perl-template-toolkit.hash                     |  6 ++++
 .../perl-template-toolkit/perl-template-toolkit.mk | 32
++++++++++++++++++++++
 5 files changed, 51 insertions(+)
 create mode 100644 package/perl-template-toolkit/Config.in
 create mode 100644 package/perl-template-toolkit/
perl-template-toolkit.hash
 create mode 100644 package/perl-template-toolkit/perl-template-toolkit.mk
DEVELOPERS +1 -0
index 6d0e3ecceb..d35cf3fb72 100644
@@ -501,6 +501,7 @@ F:  package/perl-params-util/
 F:     package/perl-sub-install/
 F:     package/perl-sys-meminfo/
 F:     package/perl-sys-mmap/
+F:     package/perl-template-toolkit/
 
 N:     Clayton Shotwell <[email protected]>
 F:     package/audit/
package/Config.in +1 -0
index 85046ae56e..6437cc0451 100644
@@ -728,6 +728,7 @@ menu "Perl libraries/modules"
        source "package/perl-sub-install/Config.in"
        source "package/perl-sys-meminfo/Config.in"
        source "package/perl-sys-mmap/Config.in"
+       source "package/perl-template-toolkit/Config.in"
        source "package/perl-time-hires/Config.in"
        source "package/perl-timedate/Config.in"
        source "package/perl-try-tiny/Config.in"
package/perl-template-toolkit/Config.in new file +11 -0
new file mode 100644
index 0000000000..1caca074aa
@@ -0,0 +1,11 @@
+config BR2_PACKAGE_PERL_TEMPLATE_TOOLKIT
+       bool "perl-template-toolkit"
+       depends on !BR2_STATIC_LIBS
+       select BR2_PACKAGE_PERL_APPCONFIG
+       help
+         comprehensive template processing system
+
+         https://metacpan.org/release/Template-Toolkit
+
+comment "perl-template-toolkit needs a toolchain w/ dynamic library"
+       depends on BR2_STATIC_LIBS
package/perl-template-toolkit/perl-template-toolkit.hash new file +3 -0
new file mode 100644
index 0000000000..54d4553695
@@ -0,0 +1,6 @@
+# retrieved by scancpan from http://cpan.metacpan.org/
+md5    a7fae5d4fe5918f33105d92a62134067 Template-Toolkit-2.27.tar.gz
+sha256 1311a403264d0134c585af0309ff2a9d5074b8ece23ece5660d31ec96bf2c6dc

Template-Toolkit-2.27.tar.gz

package/perl-template-toolkit/perl-template-toolkit.hash new file +3 -0
+
+# computed by scancpan
+sha256 d897b2d98affd4f0489340e54ceb542383101e3d21408dfad025df71d770d842

README

package/perl-template-toolkit/perl-template-toolkit.mk new file +1 -0
new file mode 100644
index 0000000000..875437dead
@@ -0,0 +1,32 @@
+###########################################################

#####################

package/perl-template-toolkit/perl-template-toolkit.mk new file +4 -0
+#
+# perl-template-toolkit
+#
+###########################################################

#####################

package/perl-template-toolkit/perl-template-toolkit.mk new file +3 -0
+
+PERL_TEMPLATE_TOOLKIT_VERSION = 2.27
+PERL_TEMPLATE_TOOLKIT_SOURCE = Template-Toolkit-$(PERL_

TEMPLATE_TOOLKIT_VERSION).tar.gz

package/perl-template-toolkit/perl-template-toolkit.mk new file +12 -0
+PERL_TEMPLATE_TOOLKIT_SITE = $(BR2_CPAN_MIRROR)/authors/id/A/AB/ABW
+PERL_TEMPLATE_TOOLKIT_DEPENDENCIES = perl-appconfig
+PERL_TEMPLATE_TOOLKIT_LICENSE = Artistic or GPL-1.0+
+PERL_TEMPLATE_TOOLKIT_LICENSE_FILES = README
+
+# There has got to be a better way... :(
+# Some arguments to Makefile.PL do not get propagated to subdirectories
+# similar to:
+# https://rt.cpan.org/Public/Bug/Display.html?id=28632
+define PERL_TEMPLATE_TOOLKIT_POST_CONFIGURE_SED
+        $(SED) "s:^AR = .*:AR = $(TARGET_AR):g" $(@D)/xs/Makefile
+        $(SED) "s:^FULL_AR = .*:FULL_AR = $(TARGET_AR):g"

$(@D)/xs/Makefile

package/perl-template-toolkit/perl-template-toolkit.mk new file +2 -0
+        $(SED) "s:^CC = .*:CC = $(TARGET_CC):g" $(@D)/xs/Makefile
+        $(SED) "s:^CCFLAGS = .*:CCFLAGS = $(TARGET_CFLAGS):g"

$(@D)/xs/Makefile

package/perl-template-toolkit/perl-template-toolkit.mk new file +2 -0
+        $(SED) "s:^LD = .*:LD = $(TARGET_CC):g" $(@D)/xs/Makefile
+        $(SED) "s:^LDDLFLAGS = .*:LDDLFLAGS = -shared
Quoted 7 lines

$(TARGET_LDFLAGS):g" $(@D)/xs/Makefile
+ $(SED) "s:^LDLFLAGS = .*:LDLFLAGS = $(TARGET_LDFLAGS):g"
$(@D)/xs/Makefile
+ $(SED) "s:^DESTDIR = .*:DESTDIR = $(TARGET_DIR):g"
$(@D)/xs/Makefile
+endef

If you put this block of code in a function (in pkg-perl.mk) with the filename as parameter,
you could just call it, in each module

    define PERL_TEMPLATE_TOOLKIT_POST_CONFIGURE_SED
         $(call,foo,$(@D)/xs/Makefile)
    endef

Fran?ois

Quoted 10 lines
package/perl-template-toolkit/perl-template-toolkit.mk new file +2 -0
+
+PERL_TEMPLATE_TOOLKIT_POST_CONFIGURE_HOOKS += PERL_TEMPLATE_TOOLKIT_POST_

CONFIGURE_SED

package/perl-template-toolkit/perl-template-toolkit.mk new file +3 -1
+
+
+$(eval $(perl-package))
--

2.14.4

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20180814/49392ddd/attachment.html>

author
#3 lore raw

RFC PATCH 1/2 perl-template-toolkit: new package

hello

Quoted 8 lines · Fran?ois Perrad

2018-08-13 19:56 GMT+02:00 Christopher McCrory <[email protected]>:

Quoted 4 lines
Signed-off-by Christopher McCrory <[email protected]>

---

<snip>

Quoted 24 lines

+# There has got to be a better way... :(

Quoted 12 lines
package/perl-template-toolkit/perl-template-toolkit.mk new file +6 -0
+# Some arguments to Makefile.PL do not get propagated to subdirectories
+# similar to:
+# https://rt.cpan.org/Public/Bug/Display.html?id=28632
+define PERL_TEMPLATE_TOOLKIT_POST_CONFIGURE_SED
+        $(SED) "s:^AR = .*:AR = $(TARGET_AR):g" $(@D)/xs/Makefile
+        $(SED) "s:^FULL_AR = .*:FULL_AR = $(TARGET_AR):g"

$(@D)/xs/Makefile

(quoted diff) +2 -0
+        $(SED) "s:^CC = .*:CC = $(TARGET_CC):g" $(@D)/xs/Makefile
+        $(SED) "s:^CCFLAGS = .*:CCFLAGS = $(TARGET_CFLAGS):g"

$(@D)/xs/Makefile

(quoted diff) +2 -0
+        $(SED) "s:^LD = .*:LD = $(TARGET_CC):g" $(@D)/xs/Makefile
+        $(SED) "s:^LDDLFLAGS = .*:LDDLFLAGS = -shared
Quoted 7 lines

$(TARGET_LDFLAGS):g" $(@D)/xs/Makefile
+ $(SED) "s:^LDLFLAGS = .*:LDLFLAGS = $(TARGET_LDFLAGS):g"
$(@D)/xs/Makefile
+ $(SED) "s:^DESTDIR = .*:DESTDIR = $(TARGET_DIR):g"
$(@D)/xs/Makefile
+endef

If you put this block of code in a function (in pkg-perl.mk) with the filename as parameter,
you could just call it, in each module

Quoted 5 lines
    define PERL_TEMPLATE_TOOLKIT_POST_CONFIGURE_SED
         $(call,foo,$(@D)/xs/Makefile)
    endef

My makefile skills aren't good enough to handle the subtleties of the entire buildroot process. Is that something you want to handle? Or use these as is until someone has some time to work on the pkg-perl.mk bits? Or other?

Thanks for looking at all these packages I sent.

Quoted 14 lines

Fran?ois

Quoted 10 lines
(quoted diff) +2 -0
+
+PERL_TEMPLATE_TOOLKIT_POST_CONFIGURE_HOOKS +=

PERL_TEMPLATE_TOOLKIT_POST_CONFIGURE_SED

package/perl-template-toolkit/perl-template-toolkit.mk new file +3 -1
+
+
+$(eval $(perl-package))
--

2.14.4

Signature · 7 lines
Christopher McCrory
To the optimist, the glass is half full.
To the pessimist, the glass is half empty.
To the engineer, the glass is twice as big as it needs to be.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20180815/bec7df93/attachment.html>
#4 lore raw

RFC PATCH 1/2 perl-template-toolkit: new package

2018-08-15 14:03 GMT+02:00 Christopher McCrory <[email protected]>:

Quoted 45 lines

hello

On Mon, Aug 13, 2018 at 9:21 PM, Fran?ois Perrad <[email protected]

Quoted 10 lines

wrote:

2018-08-13 19:56 GMT+02:00 Christopher McCrory <[email protected]>:

Quoted 4 lines
Signed-off-by Christopher McCrory <[email protected]>

---

<snip>

Quoted 24 lines

+# There has got to be a better way... :(

Quoted 12 lines
package/perl-template-toolkit/perl-template-toolkit.mk new file +6 -0
+# Some arguments to Makefile.PL do not get propagated to subdirectories
+# similar to:
+# https://rt.cpan.org/Public/Bug/Display.html?id=28632
+define PERL_TEMPLATE_TOOLKIT_POST_CONFIGURE_SED
+        $(SED) "s:^AR = .*:AR = $(TARGET_AR):g" $(@D)/xs/Makefile
+        $(SED) "s:^FULL_AR = .*:FULL_AR = $(TARGET_AR):g"

$(@D)/xs/Makefile

(quoted diff) +2 -0
+        $(SED) "s:^CC = .*:CC = $(TARGET_CC):g" $(@D)/xs/Makefile
+        $(SED) "s:^CCFLAGS = .*:CCFLAGS = $(TARGET_CFLAGS):g"

$(@D)/xs/Makefile

(quoted diff) +2 -0
+        $(SED) "s:^LD = .*:LD = $(TARGET_CC):g" $(@D)/xs/Makefile
+        $(SED) "s:^LDDLFLAGS = .*:LDDLFLAGS = -shared
Quoted 7 lines

$(TARGET_LDFLAGS):g" $(@D)/xs/Makefile
+ $(SED) "s:^LDLFLAGS = .*:LDLFLAGS = $(TARGET_LDFLAGS):g"
$(@D)/xs/Makefile
+ $(SED) "s:^DESTDIR = .*:DESTDIR = $(TARGET_DIR):g"
$(@D)/xs/Makefile
+endef

If you put this block of code in a function (in pkg-perl.mk) with the filename as parameter,
you could just call it, in each module

Quoted 5 lines
    define PERL_TEMPLATE_TOOLKIT_POST_CONFIGURE_SED
         $(call,foo,$(@D)/xs/Makefile)
    endef
Quoted 6 lines

My makefile skills aren't good enough to handle the subtleties of the entire buildroot process. Is that something you want to handle? Or use these as is until someone has some time to work on the pkg-perl.mk bits? Or other?

It is just like that :

define patch_sub_makefile

    $(SED) "s:^AR = .*:AR = $(TARGET_AR):g" $(1)
    $(SED) "s:^FULL_AR = .*:FULL_AR = $(TARGET_AR):g" $(1)
    $(SED) "s:^CC = .*:CC = $(TARGET_CC):g" $(1)
    $(SED) "s:^CCFLAGS = .*:CCFLAGS = $(TARGET_CFLAGS):g" $(1)
    $(SED) "s:^LD = .*:LD = $(TARGET_CC):g" $(1)
    $(SED) "s:^LDDLFLAGS = .*:LDDLFLAGS = -shared $(TARGET_LDFLAGS):g" $(1)
    $(SED) "s:^LDLFLAGS = .*:LDLFLAGS = $(TARGET_LDFLAGS):g" $(1)
    $(SED) "s:^DESTDIR = .*:DESTDIR = $(TARGET_DIR):g" $(1)

endef

define PERL_TEMPLATE_TOOLKIT_POST_CONFIGURE_SED

    $(call patch_sub_makefile,$(@D)/xs/Makefile)

endef

Fran?ois

Quoted 19 lines

Thanks for looking at all these packages I sent.

Quoted 14 lines

Fran?ois

Quoted 10 lines
(quoted diff) +2 -0
+
+PERL_TEMPLATE_TOOLKIT_POST_CONFIGURE_HOOKS +=

PERL_TEMPLATE_TOOLKIT_POST_CONFIGURE_SED

package/perl-template-toolkit/perl-template-toolkit.mk new file +3 -1
+
+
+$(eval $(perl-package))
--

2.14.4

Quoted 6 lines

--
Christopher McCrory
To the optimist, the glass is half full.
To the pessimist, the glass is half empty.
To the engineer, the glass is twice as big as it needs to be.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20180815/f15391c5/attachment.html>

author
#5 lore raw

RFC PATCH 1/2 perl-template-toolkit: new package

Sorry for top posting, on phone

I'll gen up a patch with this tomorrow. You are awesome!

Quoted 66 lines · Fran?ois Perrad

2018-08-15 14:03 GMT+02:00 Christopher McCrory <[email protected]>:

Quoted 45 lines

hello

Quoted 8 lines · Fran?ois Perrad

2018-08-13 19:56 GMT+02:00 Christopher McCrory <[email protected]>:

Quoted 4 lines
Signed-off-by Christopher McCrory <[email protected]>

---

<snip>

Quoted 24 lines

+# There has got to be a better way... :(

Quoted 12 lines
package/perl-template-toolkit/perl-template-toolkit.mk new file +6 -0
+# Some arguments to Makefile.PL do not get propagated to subdirectories
+# similar to:
+# https://rt.cpan.org/Public/Bug/Display.html?id=28632
+define PERL_TEMPLATE_TOOLKIT_POST_CONFIGURE_SED
+        $(SED) "s:^AR = .*:AR = $(TARGET_AR):g" $(@D)/xs/Makefile
+        $(SED) "s:^FULL_AR = .*:FULL_AR = $(TARGET_AR):g"

$(@D)/xs/Makefile

(quoted diff) +2 -0
+        $(SED) "s:^CC = .*:CC = $(TARGET_CC):g" $(@D)/xs/Makefile
+        $(SED) "s:^CCFLAGS = .*:CCFLAGS = $(TARGET_CFLAGS):g"

$(@D)/xs/Makefile

(quoted diff) +2 -0
+        $(SED) "s:^LD = .*:LD = $(TARGET_CC):g" $(@D)/xs/Makefile
+        $(SED) "s:^LDDLFLAGS = .*:LDDLFLAGS = -shared
Quoted 7 lines

$(TARGET_LDFLAGS):g" $(@D)/xs/Makefile
+ $(SED) "s:^LDLFLAGS = .*:LDLFLAGS = $(TARGET_LDFLAGS):g"
$(@D)/xs/Makefile
+ $(SED) "s:^DESTDIR = .*:DESTDIR = $(TARGET_DIR):g"
$(@D)/xs/Makefile
+endef

If you put this block of code in a function (in pkg-perl.mk) with the filename as parameter,
you could just call it, in each module

Quoted 5 lines
    define PERL_TEMPLATE_TOOLKIT_POST_CONFIGURE_SED
         $(call,foo,$(@D)/xs/Makefile)
    endef
Quoted 6 lines

My makefile skills aren't good enough to handle the subtleties of the entire buildroot process. Is that something you want to handle? Or use these as is until someone has some time to work on the pkg-perl.mk bits? Or other?

It is just like that :

define patch_sub_makefile

    $(SED) "s:^AR = .*:AR = $(TARGET_AR):g" $(1)
    $(SED) "s:^FULL_AR = .*:FULL_AR = $(TARGET_AR):g" $(1)
    $(SED) "s:^CC = .*:CC = $(TARGET_CC):g" $(1)
    $(SED) "s:^CCFLAGS = .*:CCFLAGS = $(TARGET_CFLAGS):g" $(1)
    $(SED) "s:^LD = .*:LD = $(TARGET_CC):g" $(1)
    $(SED) "s:^LDDLFLAGS = .*:LDDLFLAGS = -shared $(TARGET_LDFLAGS):g" $(1)
    $(SED) "s:^LDLFLAGS = .*:LDLFLAGS = $(TARGET_LDFLAGS):g" $(1)
    $(SED) "s:^DESTDIR = .*:DESTDIR = $(TARGET_DIR):g" $(1)
Quoted 37 lines

endef

define PERL_TEMPLATE_TOOLKIT_POST_CONFIGURE_SED

    $(call patch_sub_makefile,$(@D)/xs/Makefile)

endef

Fran?ois

Quoted 25 lines

Thanks for looking at all these packages I sent.

Quoted 14 lines

Fran?ois

Quoted 10 lines
(quoted diff) +2 -0
+
+PERL_TEMPLATE_TOOLKIT_POST_CONFIGURE_HOOKS +=

PERL_TEMPLATE_TOOLKIT_POST_CONFIGURE_SED

package/perl-template-toolkit/perl-template-toolkit.mk new file +3 -1
+
+
+$(eval $(perl-package))
--

2.14.4

--
Christopher McCrory
To the optimist, the glass is half full.
To the pessimist, the glass is half empty.
To the engineer, the glass is twice as big as it needs to be.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20180815/390a6283/attachment.html>

author
#6 lore raw

RFC PATCH 2/2 perl-xml-parser: new package

In reply to Christopher McCrory
Signed-off-by Christopher McCrory <[email protected]>
---
 DEVELOPERS        | 1 +
 package/Config.in | 1 +
 2 files changed, 2 insertions(+)
DEVELOPERS +1 -0
index d35cf3fb72..8cd71c0cfd 100644
@@ -502,6 +502,7 @@ F:	package/perl-sub-install/
 F:	package/perl-sys-meminfo/
 F:	package/perl-sys-mmap/
 F:	package/perl-template-toolkit/
+F:	package/perl-xml-parser/
 
 N:	Clayton Shotwell <[email protected]>
 F:	package/audit/
package/Config.in +1 -0
index 6437cc0451..a83015a819 100644
@@ -736,6 +736,7 @@ menu "Perl libraries/modules"
 	source "package/perl-www-robotrules/Config.in"
 	source "package/perl-xml-libxml/Config.in"
 	source "package/perl-xml-namespacesupport/Config.in"
+	source "package/perl-xml-parser/Config.in"
 	source "package/perl-xml-sax/Config.in"
 	source "package/perl-xml-sax-base/Config.in"
 endmenu
Signature · 1 line
2.14.4
#7 lore raw

RFC PATCH 2/2 perl-xml-parser: new package

Hello,

Quoted 1 line · Christopher McCrory
Signed-off-by Christopher McCrory <[email protected]>

This seems to be a partial patch.

Your patch series seems a bit messed up. You have sent:

RFC PATCH 0/2
RFC PATCH 1/2
RFC PATCH 2/2 (this patch, which is partial)
RFC PATCH 4/4

Could you fix this up and send a proper patch series ? If you're not familiar yet with git send-email, I would suggest that you send your patch series to yourself first, to make sure everything is correct, before sending them to the Buildroot mailing list.

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
author
#8 lore raw

RFC PATCH 2/2 perl-xml-parser: new package

Hello

Quoted 14 lines · Thomas Petazzoni

Hello,

Quoted 1 line · Christopher McCrory
Signed-off-by Christopher McCrory <[email protected]>

This seems to be a partial patch.

Your patch series seems a bit messed up. You have sent:

RFC PATCH 0/2
RFC PATCH 1/2
RFC PATCH 2/2 (this patch, which is partial)
RFC PATCH 4/4

Quoted 7 lines

Could you fix this up and send a proper patch series ? If you're not familiar yet with git send-email, I would suggest that you send your patch series to yourself first, to make sure everything is correct, before sending them to the Buildroot mailing list.

On phone so formatting might be off. And I'm a little buzzed.

I had a mistake in that package and git reverted to re gen the commit, and forgot the git add afterwards. I can regen, but is the whole sed thing the way to deal with this quirk? Is there a better way that I am missing? Hense the -- rfc.

And thank you for dealing with the whole Buildroot project.

Quoted 9 lines

Thanks!

Thomas
--
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering
https://bootlin.com

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20180813/c1f7095a/attachment.html>

#9 lore raw

cover Hack for perl module subdirectories

In reply to Christopher McCrory

Hello,

Quoted 6 lines · Christopher McCrory

for AR, CC, xFLAGS, etc. This "works", but there should be a better way. Hence the RFC.

Also there is a package, libxml-parser-perl, that is a host only perl xml-parser package needed by host-intltool and metacity. Should they stay seprate or be merged?

libxml-parser-perl is intentionally not using the perl-package infrastructure, because we don't want to require building host-perl to build host-intltool.

Some libxml-parser-perl is using the system-wide Perl, which is a mandatory Buildroot dependency.

Perhaps we should add a comment in libxml-parser-perl.mk to explain this.

Best regards,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com