Cleanup drm_kms_helper_poll_enable/disable() calls
Subsystems (3)
Lyude Paul
maintainercover Cleanup drm_kms_helper_poll_enable/disable() calls
Does what it says on the label, a lot of these calls are already handled somewhere else and don't appear to be here for a legitimate reason anymore.
Lyude Paul (3):
drm/nouveau: Remove useless poll_enable() call in
switcheroo_set_state()
drm/nouveau: Remove useless poll_disable() call in
switcheroo_set_state()
drm/nouveau: Remove useless poll_enable() call in drm_load()
drivers/gpu/drm/nouveau/nouveau_drm.c | 4 +--- drivers/gpu/drm/nouveau/nouveau_vga.c | 2 -- 2 files changed, 1 insertion(+), 5 deletions(-)
Signature · 6 lines
2.17.1 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Lyude Paul
maintainerPATCH 1/3 drm/nouveau: Remove useless poll_enable() call in switcheroo_set_state()
This doesn't do anything, drm_kms_helper_poll_enable() gets called in nouveau_pmops_resume()->nouveau_display_resume()->nouveau_display_init() already.
--- drivers/gpu/drm/nouveau/nouveau_vga.c | 1 - 1 file changed, 1 deletion(-)
drivers/gpu/drm/nouveau/nouveau_vga.c +0 -1
@@ -46,7 +46,6 @@ nouveau_switcheroo_set_state(struct pci_dev *pdev,pr_err ("VGA switcheroo: switched nouveau on\n" ); dev->switch_power_state =DRM_SWITCH_POWER_CHANGING ;nouveau_pmops_resume (&pdev->dev); -drm_kms_helper_poll_enable (dev); dev->switch_power_state =DRM_SWITCH_POWER_ON ; }else {pr_err ("VGA switcheroo: switched nouveau off\n" );
Signature · 1 line
2.17.1
Lyude Paul
maintainerPATCH 2/3 drm/nouveau: Remove useless poll_disable() call in switcheroo_set_state()
In reply to Lyude PaulThis won't do anything but potentially make us miss hotplugs. We already call drm_kms_helper_poll_disable() in nouveau_pmops_suspend()->nouveau_display_suspend()->nouveau_display_fini()
--- drivers/gpu/drm/nouveau/nouveau_vga.c | 1 - 1 file changed, 1 deletion(-)
drivers/gpu/drm/nouveau/nouveau_vga.c +0 -1
@@ -50,7 +50,6 @@ nouveau_switcheroo_set_state(struct pci_dev *pdev, }else {pr_err ("VGA switcheroo: switched nouveau off\n" ); dev->switch_power_state =DRM_SWITCH_POWER_CHANGING ; -drm_kms_helper_poll_disable (dev);nouveau_switcheroo_optimus_dsm ();nouveau_pmops_suspend (&pdev->dev); dev->switch_power_state =DRM_SWITCH_POWER_OFF ;
Signature · 6 lines
2.17.1 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Lyude Paul
maintainerPATCH 3/3 drm/nouveau: Remove useless poll_enable() call in drm_load()
In reply to Lyude PaulAgain, this doesn't do anything. drm_kms_helper_poll_enable() will have already been called in nouveau_display_init()
--- drivers/gpu/drm/nouveau/nouveau_drm.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/gpu/drm/nouveau/nouveau_drm.c +1 -3
@@ -592,10 +592,8 @@ nouveau_drm_load(struct drm_device *dev, unsigned long flags)pm_runtime_allow (dev->dev);pm_runtime_mark_last_busy (dev->dev);pm_runtime_put (dev->dev); - }else { -/* enable polling for external displays */ -drm_kms_helper_poll_enable (dev); } +return 0 ; fail_dispinit:
Signature · 1 line
2.17.1