Skip to contentSkip to conversation

package/aircrack-ng: powerpc arch requires altivec

PATCH Superseded Matt Weber 2 participants 3 messages Aug 14, 2018 – Aug 27, 2018

lore
Share & tools
lore

Matt Weber

author
#0 lore raw

PATCH v2 1/1 package/aircrack-ng: powerpc arch requires altivec

The powerpc support in this package currently requires an arch with altivec accelerator support. This is a bug and the the powerpc arch should have a non-simd option like ARM/x86.

Upstream issue: https://github.com/aircrack-ng/aircrack-ng/issues/1941

Fixes
http://autobuild.buildroot.net/results/87e82a5e8d0b1c1ff10ec3e59d25bcd56b329075

Signed-off-by Matthew Weber <[email protected]>

--
Changes
v1 -> v2
[Thomas
- Add issue link to Config.in
- Reworded description above to note this is a bug

---
 package/aircrack-ng/Config.in | 3 +++
 1 file changed, 3 insertions(+)
package/aircrack-ng/Config.in +3 -0
index f3e2bc4ef1..70ddcb6111 100644
@@ -4,6 +4,9 @@ config BR2_PACKAGE_AIRCRACK_NG
 	depends on BR2_TOOLCHAIN_HAS_THREADS
 	depends on BR2_INSTALL_LIBSTDCPP
 	depends on !BR2_STATIC_LIBS # dlfcn.h
+	# https://github.com/aircrack-ng/aircrack-ng/issues/1941
+	depends on BR2_POWERPC_CPU_HAS_ALTIVEC  || \
+		!(BR2_powerpc || BR2_powerpc64 || BR2_powerpc64le)
 	select BR2_PACKAGE_OPENSSL if !BR2_PACKAGE_LIBGCRYPT
 	help
 	  A set of tools for auditing wireless networks
Signature · 1 line
2.17.0
Applied
#1 lore raw

PATCH v2 1/1 package/aircrack-ng: powerpc arch requires altivec

Hello,

Quoted 16 lines · Matt Weber

The powerpc support in this package currently requires an arch with altivec accelerator support. This is a bug and the the powerpc arch should have a non-simd option like ARM/x86.

Upstream issue: https://github.com/aircrack-ng/aircrack-ng/issues/1941

Fixes
http://autobuild.buildroot.net/results/87e82a5e8d0b1c1ff10ec3e59d25bcd56b329075

Signed-off-by Matthew Weber <[email protected]>

--
Changes
v1 -> v2
[Thomas
- Add issue link to Config.in
- Reworded description above to note this is a bug

Quoted 3 lines
---
 package/aircrack-ng/Config.in | 3 +++
 1 file changed, 3 insertions(+)

Applied to master, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
author
#2 lore raw

PATCH v2 1/1 package/aircrack-ng: powerpc arch requires altivec

Peter/Thomas,

Quoted 24 lines · Thomas Petazzoni

Hello,

Quoted 16 lines · Matt Weber

The powerpc support in this package currently requires an arch with altivec accelerator support. This is a bug and the the powerpc arch should have a non-simd option like ARM/x86.

Upstream issue: https://github.com/aircrack-ng/aircrack-ng/issues/1941

Fixes
http://autobuild.buildroot.net/results/87e82a5e8d0b1c1ff10ec3e59d25bcd56b329075

Signed-off-by Matthew Weber <[email protected]>

--
Changes
v1 -> v2
[Thomas
- Add issue link to Config.in
- Reworded description above to note this is a bug

Quoted 3 lines
---
 package/aircrack-ng/Config.in | 3 +++
 1 file changed, 3 insertions(+)
Quoted 1 line

Applied to master, thanks.

Just sent patches to properly fix this issue. They won't apply to 'next' as the revert is against a master commit. I'm assuming the series would be applied prior to this release or is the timeline to close?

http://patchwork.ozlabs.org/patch/962684/
http://patchwork.ozlabs.org/patch/962683/

Matt