Skip to contentSkip to conversation

cpu/hotplug: Non-SMP machines do not make use of booted_once

PATCH In review Abel Vesa 2 participants 2 messages Aug 14, 2018 CPU hotplug

lore
Share & tools
lore

Abel Vesa

author
#0 lore raw

PATCH 1/1 cpu/hotplug: Non-SMP machines do not make use of booted_once

Following commit breaks the non-SMP builds.

[0cc3cd21657be04cb0] cpu/hotplug: Boot HT siblings at least once

---
 kernel/cpu.c | 2 ++
 1 file changed, 2 insertions(+)
kernel/cpu.c +2 -0
index 099fb20cd7be..f06c513c5c42 100644
@@ -2272,6 +2272,8 @@ void __init boot_cpu_init(void)
  */
 void __init boot_cpu_hotplug_init(void)
 {
+#ifdef CONFIG_SMP
 	this_cpu_write(cpuhp_state.booted_once, true);
+#endif
 	this_cpu_write(cpuhp_state.state, CPUHP_ONLINE);
 }
Signature · 1 line
2.18.0
#1 lore raw
Quoted 2 lines · Abel Vesa

Following commit breaks the non-SMP builds.

Thanks, we obviously don't do a lot of coverage of UP any more.

I'm not sure if we should just move the bool's to be bitfields and make them all available unconditionally, because the #ifdef in code annoys me.

I'll think about it. The x86 maintainers are all on vacation this week, and I don't want to disturb them, so I'll fix it one way or another.

Linus