Skip to contentSkip to conversation

dt-bindings: leds: Add bindings for lm3697 driver

PATCH Superseded Dan Murphy 2 participants 6 messages Aug 15, 2018

Subsystems (2)

v3 of 11 Superseded Latest is v11 →

lore
Share & tools
lore

Dan Murphy

author
#0 lore raw

PATCH v3 1/2 dt-bindings: leds: Add bindings for lm3697 driver

Add the device tree bindings for the lm3697
LED driver for backlighting and display.

---

v3 - Updated subject with prefered title - https://lore.kernel.org/patchwork/patch/972337/
v2 - Fixed subject and patch commit message - https://lore.kernel.org/patchwork/patch/971326/

 .../devicetree/bindings/leds/leds-lm3697.txt  | 89 +++++++++++++++++++
 1 file changed, 89 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/leds/leds-lm3697.txt
Documentation/devicetree/bindings/leds/leds-lm3697.txt new file +89 -0
new file mode 100644
index 000000000000..34403a48a0ce
@@ -0,0 +1,89 @@
+* Texas Instruments - LM3697 Highly Efficient White LED Driver
+
+The LM3697 11-bit LED driver provides high-
+performance backlight dimming for 1, 2, or 3 series
+LED strings while delivering up to 90% efficiency.
+
+This device is suitable for Display and Keypad Lighting
+
+Required properties:
+	- compatible:
+		"ti,lm3967"
+	- reg :  I2C slave address
+	- #address-cells : 1
+	- #size-cells : 0
+
+Optional properties:
+	- enable-gpios : gpio pin to enable/disable the device.
+	- vled-supply : LED supply
+
+Required child properties:
+	- reg : 0 - LED is Controlled by bank A
+		1 - LED is Controlled by bank B
+	- led-sources - Indicates which HVLED string is associated to which
+			control bank.  The HVLED string cannot be associated with
+			two control banks.  This property is an array of 3 and
+			all positions in the array must be populated.
+			Additional information is contained
+			in Documentation/devicetree/bindings/leds/common.txt
+			0 - End of array if all 3 LEDs are not declared for a
+			    single control bank.
+			1 - HVLED 1 string
+			2 - HVLED 2 string
+			3 - HVLED 3 string
+
+Optional child properties:
+	- label : see Documentation/devicetree/bindings/leds/common.txt
+	- linux,default-trigger :
+	   see Documentation/devicetree/bindings/leds/common.txt
+
+Example:
+
+HVLED string 1 and 2 controlled by control bank A and HVLED string controlled by
+control bank B.
+
+led-controller@36 {
+	compatible = "ti,lm3967";
+	reg = <0x36>;
+	#address-cells = <1>;
+	#size-cells = <0>;
+
+	enable-gpios = <&gpio1 28 GPIO_ACTIVE_HIGH>;
+	vled-supply = <&vbatt>;
+
+	led@0 {
+		reg = <0>;
+		led-sources = <0x1 0x2 0x0>;
+		label = "white:first_backlight_cluster";
+		linux,default-trigger = "backlight";
+	};
+
+	led@1 {
+		reg = <1>;
+		led-sources = <0x3 0x0 0x0>;
+		label = "white:second_backlight_cluster";
+		linux,default-trigger = "backlight";
+	};
+}
+
+All HVLED strings controlled by control bank A
+
+led-controller@36 {
+	compatible = "ti,lm3967";
+	reg = <0x36>;
+	#address-cells = <1>;
+	#size-cells = <0>;
+
+	enable-gpios = <&gpio1 28 GPIO_ACTIVE_HIGH>;
+	vled-supply = <&vbatt>;
+
+	led@0 {
+		reg = <0>;
+		led-sources = <0x1 0x2 0x3>;
+		label = "white:backlight_cluster";
+		linux,default-trigger = "backlight";
+	};
+}
+
+For more product information please see the link below:
+http://www.ti.com/lit/ds/symlink/lm3697.pdf
Signature · 1 line
2.17.0.582.gccdcbd54c
author
#1 lore raw

PATCH v3 2/2 leds: lm3697: Introduce the lm3697 driver

Introduce the lm3697 LED driver for
backlighting and display.

Datasheet location:
http://www.ti.com/lit/ds/symlink/lm3697.pdf

---

v3 - Add code to support led-sources and control bank configuration also fix other miscellaneous issues reported- https://lore.kernel.org/patchwork/patch/972336/
v2 - Removed unneed 'of' calls in dt_parse, fixed comment, fixed checkpatch error, and change led registration - https://lore.kernel.org/patchwork/patch/971327/

 drivers/leds/Kconfig       |   9 +
 drivers/leds/Makefile      |   1 +
 drivers/leds/leds-lm3697.c | 403 +++++++++++++++++++++++++++++++++++++
 3 files changed, 413 insertions(+)
 create mode 100644 drivers/leds/leds-lm3697.c
drivers/leds/Kconfig +9 -0
index 44097a3e0fcc..784cbe375724 100644
@@ -151,6 +151,15 @@ config LEDS_LM3642
 	  converter plus 1.5A constant current driver for a high-current
 	  white LED.
 
+config LEDS_LM3697
+	tristate "LED support for LM3697 Chip"
+	depends on LEDS_CLASS && I2C
+	select REGMAP_I2C
+	help
+	  This option enables support for LEDs connected to LM3697.
+	  The LM3697 is an 11 bit high performance backlight driver for
+	  keypad and display lighting.
+
 config LEDS_LM3692X
 	tristate "LED support for LM3692x Chips"
 	depends on LEDS_CLASS && I2C && OF
drivers/leds/Makefile +1 -0
index 420b5d2cfa62..2813f089f3db 100644
@@ -19,6 +19,7 @@ obj-$(CONFIG_LEDS_LOCOMO)		+= leds-locomo.o
 obj-$(CONFIG_LEDS_LM3530)		+= leds-lm3530.o
 obj-$(CONFIG_LEDS_LM3533)		+= leds-lm3533.o
 obj-$(CONFIG_LEDS_LM3642)		+= leds-lm3642.o
+obj-$(CONFIG_LEDS_LM3697)		+= leds-lm3697.o
 obj-$(CONFIG_LEDS_MIKROTIK_RB532)	+= leds-rb532.o
 obj-$(CONFIG_LEDS_S3C24XX)		+= leds-s3c24xx.o
 obj-$(CONFIG_LEDS_NET48XX)		+= leds-net48xx.o
drivers/leds/leds-lm3697.c new file +403 -0

403 lines not on this page · raw message

Signature · 1 line
2.17.0.582.gccdcbd54c
#2 lore raw
In reply to Dan Murphy

Hi Dan,

Thank you for the update.

Quoted 39 lines · Dan Murphy

Add the device tree bindings for the lm3697
LED driver for backlighting and display.

---

v3 - Updated subject with prefered title - https://lore.kernel.org/patchwork/patch/972337/
v2 - Fixed subject and patch commit message - https://lore.kernel.org/patchwork/patch/971326/

 .../devicetree/bindings/leds/leds-lm3697.txt  | 89 +++++++++++++++++++
 1 file changed, 89 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/leds/leds-lm3697.txt
Documentation/devicetree/bindings/leds/leds-lm3697.txt new file +20 -0
new file mode 100644
index 000000000000..34403a48a0ce
@@ -0,0 +1,89 @@
+* Texas Instruments - LM3697 Highly Efficient White LED Driver
+
+The LM3697 11-bit LED driver provides high-
+performance backlight dimming for 1, 2, or 3 series
+LED strings while delivering up to 90% efficiency.
+
+This device is suitable for Display and Keypad Lighting
+
+Required properties:
+	- compatible:
+		"ti,lm3967"
+	- reg :  I2C slave address
+	- #address-cells : 1
+	- #size-cells : 0
+
+Optional properties:
+	- enable-gpios : gpio pin to enable/disable the device.
+	- vled-supply : LED supply
+
+Required child properties:

Documentation/devicetree/bindings/leds/leds-lm3697.txt line 30

Quoted 10 lines
Documentation/devicetree/bindings/leds/leds-lm3697.txt new file +10 -0
+	- reg : 0 - LED is Controlled by bank A
+		1 - LED is Controlled by bank B
+	- led-sources - Indicates which HVLED string is associated to which
+			control bank.  The HVLED string cannot be associated with
+			two control banks.  This property is an array of 3 and
+			all positions in the array must be populated.
+			Additional information is contained
+			in Documentation/devicetree/bindings/leds/common.txt
+			0 - End of array if all 3 LEDs are not declared for a
+			    single control bank.

This is needless complication. I propose to define led-sources as an array of three boolean values, whose state signifies which LED strings are controlled by the bank defined by the reg property in the given child node. I.e. <HVLED1 HVLED2 HVLED3>.

I modified your examples below accordingly.

Quoted 16 lines
Documentation/devicetree/bindings/leds/leds-lm3697.txt new file +16 -0
+			1 - HVLED 1 string
+			2 - HVLED 2 string
+			3 - HVLED 3 string
+
+Optional child properties:
+	- label : see Documentation/devicetree/bindings/leds/common.txt
+	- linux,default-trigger :
+	   see Documentation/devicetree/bindings/leds/common.txt
+
+Example:
+
+HVLED string 1 and 2 controlled by control bank A and HVLED string controlled by
+control bank B.
+
+led-controller@36 {
+	compatible = "ti,lm3967";

Documentation/devicetree/bindings/leds/leds-lm3697.txt

Quoted 10 lines
Documentation/devicetree/bindings/leds/leds-lm3697.txt new file +10 -0
+	reg = <0x36>;
+	#address-cells = <1>;
+	#size-cells = <0>;
+
+	enable-gpios = <&gpio1 28 GPIO_ACTIVE_HIGH>;
+	vled-supply = <&vbatt>;
+
+	led@0 {
+		reg = <0>;
+		led-sources = <0x1 0x2 0x0>
		led-sources = <1 1 0>;

;

Documentation/devicetree/bindings/leds/leds-lm3697.txt line 63

Quoted 7 lines
Documentation/devicetree/bindings/leds/leds-lm3697.txt new file +7 -0
+		label = "white:first_backlight_cluster";
+		linux,default-trigger = "backlight";
+	};
+
+	led@1 {
+		reg = <1>;
+		led-sources = <0x3 0x0 0x0>;
		led-sources = <0 0 1>;
Quoted 9 lines
Documentation/devicetree/bindings/leds/leds-lm3697.txt new file +9 -0
+		label = "white:second_backlight_cluster";
+		linux,default-trigger = "backlight";
+	};
+}
+
+All HVLED strings controlled by control bank A
+
+led-controller@36 {
+	compatible = "ti,lm3967";

Documentation/devicetree/bindings/leds/leds-lm3697.txt line 82

Quoted 10 lines
Documentation/devicetree/bindings/leds/leds-lm3697.txt new file +10 -0
+	reg = <0x36>;
+	#address-cells = <1>;
+	#size-cells = <0>;
+
+	enable-gpios = <&gpio1 28 GPIO_ACTIVE_HIGH>;
+	vled-supply = <&vbatt>;
+
+	led@0 {
+		reg = <0>;
+		led-sources = <0x1 0x2 0x3>;
		led-sources = <1 1 1>;
Quoted 8 lines
Documentation/devicetree/bindings/leds/leds-lm3697.txt new file +7 -0
+		label = "white:backlight_cluster";
+		linux,default-trigger = "backlight";
+	};
+}
+
+For more product information please see the link below:
+http://www.ti.com/lit/ds/symlink/lm3697.pdf
Signature · 2 lines
Best regards,
Jacek Anaszewski
author
#3 lore raw

Jacek

Quoted 51 lines · Jacek Anaszewski

Hi Dan,

Thank you for the update.

Quoted 46 lines · Dan Murphy

Add the device tree bindings for the lm3697
LED driver for backlighting and display.

---

v3 - Updated subject with prefered title - https://lore.kernel.org/patchwork/patch/972337/
v2 - Fixed subject and patch commit message - https://lore.kernel.org/patchwork/patch/971326/

 .../devicetree/bindings/leds/leds-lm3697.txt  | 89 +++++++++++++++++++
 1 file changed, 89 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/leds/leds-lm3697.txt
Documentation/devicetree/bindings/leds/leds-lm3697.txt new file +27 -0
new file mode 100644
index 000000000000..34403a48a0ce
@@ -0,0 +1,89 @@
+* Texas Instruments - LM3697 Highly Efficient White LED Driver
+
+The LM3697 11-bit LED driver provides high-
+performance backlight dimming for 1, 2, or 3 series
+LED strings while delivering up to 90% efficiency.
+
+This device is suitable for Display and Keypad Lighting
+
+Required properties:
+	- compatible:
+		"ti,lm3967"
+	- reg :  I2C slave address
+	- #address-cells : 1
+	- #size-cells : 0
+
+Optional properties:
+	- enable-gpios : gpio pin to enable/disable the device.
+	- vled-supply : LED supply
+
+Required child properties:
+	- reg : 0 - LED is Controlled by bank A
+		1 - LED is Controlled by bank B
+	- led-sources - Indicates which HVLED string is associated to which
+			control bank.  The HVLED string cannot be associated with
+			two control banks.  This property is an array of 3 and
+			all positions in the array must be populated.
+			Additional information is contained
Quoted 8 lines

Documentation/devicetree/bindings/leds/leds-lm3697.txt line 30

Quoted 3 lines
Documentation/devicetree/bindings/leds/leds-lm3697.txt new file +3 -0
+			in Documentation/devicetree/bindings/leds/common.txt
+			0 - End of array if all 3 LEDs are not declared for a
+			    single control bank.

This is needless complication. I propose to define led-sources as an array of three boolean values, whose state signifies which LED strings are controlled by the bank defined by the reg property in the given child node. I.e. <HVLED1 HVLED2 HVLED3>.

I struggled a bit with this definition. Once I got it working it ended up producing an overly complex control bank algorithm.

I will take a look at implementing the suggestion but the complication comes in the numerous DT configurations we could encounter. Part of the issue is that the user can connect to CTRL bank b only or CTRL bank a only or a combination of that

2^3

Dan

Quoted 73 lines

I modified your examples below accordingly.

Quoted 16 lines
Documentation/devicetree/bindings/leds/leds-lm3697.txt new file +16 -0
+			1 - HVLED 1 string
+			2 - HVLED 2 string
+			3 - HVLED 3 string
+
+Optional child properties:
+	- label : see Documentation/devicetree/bindings/leds/common.txt
+	- linux,default-trigger :
+	   see Documentation/devicetree/bindings/leds/common.txt
+
+Example:
+
+HVLED string 1 and 2 controlled by control bank A and HVLED string controlled by
+control bank B.
+
+led-controller@36 {
+	compatible = "ti,lm3967";

Documentation/devicetree/bindings/leds/leds-lm3697.txt

Quoted 10 lines
Documentation/devicetree/bindings/leds/leds-lm3697.txt new file +10 -0
+	reg = <0x36>;
+	#address-cells = <1>;
+	#size-cells = <0>;
+
+	enable-gpios = <&gpio1 28 GPIO_ACTIVE_HIGH>;
+	vled-supply = <&vbatt>;
+
+	led@0 {
+		reg = <0>;
+		led-sources = <0x1 0x2 0x0>
		led-sources = <1 1 0>;

;

Documentation/devicetree/bindings/leds/leds-lm3697.txt line 63

Quoted 7 lines
Documentation/devicetree/bindings/leds/leds-lm3697.txt new file +7 -0
+		label = "white:first_backlight_cluster";
+		linux,default-trigger = "backlight";
+	};
+
+	led@1 {
+		reg = <1>;
+		led-sources = <0x3 0x0 0x0>;
		led-sources = <0 0 1>;
Quoted 9 lines
Documentation/devicetree/bindings/leds/leds-lm3697.txt new file +9 -0
+		label = "white:second_backlight_cluster";
+		linux,default-trigger = "backlight";
+	};
+}
+
+All HVLED strings controlled by control bank A
+
+led-controller@36 {
+	compatible = "ti,lm3967";

Documentation/devicetree/bindings/leds/leds-lm3697.txt line 82

Quoted 10 lines
Documentation/devicetree/bindings/leds/leds-lm3697.txt new file +10 -0
+	reg = <0x36>;
+	#address-cells = <1>;
+	#size-cells = <0>;
+
+	enable-gpios = <&gpio1 28 GPIO_ACTIVE_HIGH>;
+	vled-supply = <&vbatt>;
+
+	led@0 {
+		reg = <0>;
+		led-sources = <0x1 0x2 0x3>;
		led-sources = <1 1 1>;
Quoted 8 lines
Documentation/devicetree/bindings/leds/leds-lm3697.txt new file +7 -0
+		label = "white:backlight_cluster";
+		linux,default-trigger = "backlight";
+	};
+}
+
+For more product information please see the link below:
+http://www.ti.com/lit/ds/symlink/lm3697.pdf
Signature · 2 lines
------------------
Dan Murphy
#4 lore raw

Dan,

Quoted 63 lines · Dan Murphy

Jacek

Quoted 51 lines · Jacek Anaszewski

Hi Dan,

Thank you for the update.

Quoted 46 lines · Dan Murphy

Add the device tree bindings for the lm3697
LED driver for backlighting and display.

---

v3 - Updated subject with prefered title - https://lore.kernel.org/patchwork/patch/972337/
v2 - Fixed subject and patch commit message - https://lore.kernel.org/patchwork/patch/971326/

 .../devicetree/bindings/leds/leds-lm3697.txt  | 89 +++++++++++++++++++
 1 file changed, 89 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/leds/leds-lm3697.txt
Documentation/devicetree/bindings/leds/leds-lm3697.txt new file +27 -0
new file mode 100644
index 000000000000..34403a48a0ce
@@ -0,0 +1,89 @@
+* Texas Instruments - LM3697 Highly Efficient White LED Driver
+
+The LM3697 11-bit LED driver provides high-
+performance backlight dimming for 1, 2, or 3 series
+LED strings while delivering up to 90% efficiency.
+
+This device is suitable for Display and Keypad Lighting
+
+Required properties:
+	- compatible:
+		"ti,lm3967"
+	- reg :  I2C slave address
+	- #address-cells : 1
+	- #size-cells : 0
+
+Optional properties:
+	- enable-gpios : gpio pin to enable/disable the device.
+	- vled-supply : LED supply
+
+Required child properties:
+	- reg : 0 - LED is Controlled by bank A
+		1 - LED is Controlled by bank B
+	- led-sources - Indicates which HVLED string is associated to which
+			control bank.  The HVLED string cannot be associated with
+			two control banks.  This property is an array of 3 and
+			all positions in the array must be populated.
+			Additional information is contained
Quoted 8 lines

Documentation/devicetree/bindings/leds/leds-lm3697.txt line 30

Quoted 3 lines
Documentation/devicetree/bindings/leds/leds-lm3697.txt new file +3 -0
+			in Documentation/devicetree/bindings/leds/common.txt
+			0 - End of array if all 3 LEDs are not declared for a
+			    single control bank.

This is needless complication. I propose to define led-sources as an array of three boolean values, whose state signifies which LED strings are controlled by the bank defined by the reg property in the given child node. I.e. <HVLED1 HVLED2 HVLED3>.

Quoted 8 lines

I struggled a bit with this definition. Once I got it working it ended up producing an overly complex control bank algorithm.

I will take a look at implementing the suggestion but the complication comes in the numerous DT configurations we could encounter. Part of the issue is that the user can connect to CTRL bank b only or CTRL bank a only or a combination of that

2^3

I tried to play a bit with that and here is what I got (simplified DT parsing):

int used_hvleds[3] = {0, 0 ,0};
int used_control_banks[2] = {0, 0};

int parse_child_node(struct fwnode_handle *child)

{
	int bank_hvleds[3];

	fwnode_property_read_u32_array(child, "led-sources",
		bank_hvleds, LM3697_MAX_LED_STRINGS);

	for (i = 0; i <= 3; i++) {
		if (bank_hvleds[i] && used_hvleds[i])
			return -EINVAL;
		used_hvleds[i] = 1;
	}

	return 0;
}

struct fwnode_handle *child = NULL;

device_for_each_child_node(priv->dev, child)

	fwnode_property_read_u32(child, "reg", &control_bank);
	if (used_control_banks[control_bank])
		goto err;
	used_control_banks[control_bank] = 1;
	if (parse_child_node(child))
		goto err;
Quoted 75 lines
Quoted 73 lines

I modified your examples below accordingly.

Quoted 16 lines
Documentation/devicetree/bindings/leds/leds-lm3697.txt new file +16 -0
+			1 - HVLED 1 string
+			2 - HVLED 2 string
+			3 - HVLED 3 string
+
+Optional child properties:
+	- label : see Documentation/devicetree/bindings/leds/common.txt
+	- linux,default-trigger :
+	   see Documentation/devicetree/bindings/leds/common.txt
+
+Example:
+
+HVLED string 1 and 2 controlled by control bank A and HVLED string controlled by
+control bank B.
+
+led-controller@36 {
+	compatible = "ti,lm3967";

Documentation/devicetree/bindings/leds/leds-lm3697.txt

Quoted 10 lines
Documentation/devicetree/bindings/leds/leds-lm3697.txt new file +10 -0
+	reg = <0x36>;
+	#address-cells = <1>;
+	#size-cells = <0>;
+
+	enable-gpios = <&gpio1 28 GPIO_ACTIVE_HIGH>;
+	vled-supply = <&vbatt>;
+
+	led@0 {
+		reg = <0>;
+		led-sources = <0x1 0x2 0x0>
		led-sources = <1 1 0>;

;

Documentation/devicetree/bindings/leds/leds-lm3697.txt line 63

Quoted 7 lines
Documentation/devicetree/bindings/leds/leds-lm3697.txt new file +7 -0
+		label = "white:first_backlight_cluster";
+		linux,default-trigger = "backlight";
+	};
+
+	led@1 {
+		reg = <1>;
+		led-sources = <0x3 0x0 0x0>;
		led-sources = <0 0 1>;
Quoted 9 lines
Documentation/devicetree/bindings/leds/leds-lm3697.txt new file +9 -0
+		label = "white:second_backlight_cluster";
+		linux,default-trigger = "backlight";
+	};
+}
+
+All HVLED strings controlled by control bank A
+
+led-controller@36 {
+	compatible = "ti,lm3967";

Documentation/devicetree/bindings/leds/leds-lm3697.txt line 82

Quoted 10 lines
Documentation/devicetree/bindings/leds/leds-lm3697.txt new file +10 -0
+	reg = <0x36>;
+	#address-cells = <1>;
+	#size-cells = <0>;
+
+	enable-gpios = <&gpio1 28 GPIO_ACTIVE_HIGH>;
+	vled-supply = <&vbatt>;
+
+	led@0 {
+		reg = <0>;
+		led-sources = <0x1 0x2 0x3>;
		led-sources = <1 1 1>;
Quoted 8 lines
Documentation/devicetree/bindings/leds/leds-lm3697.txt new file +7 -0
+		label = "white:backlight_cluster";
+		linux,default-trigger = "backlight";
+	};
+}
+
+For more product information please see the link below:
+http://www.ti.com/lit/ds/symlink/lm3697.pdf
Signature · 2 lines
Best regards,
Jacek Anaszewski
author
#5 lore raw

Jacek

Quoted 69 lines · Jacek Anaszewski

Dan,

Quoted 66 lines · Dan Murphy

Jacek

Quoted 51 lines · Jacek Anaszewski

Hi Dan,

Thank you for the update.

Quoted 46 lines · Dan Murphy

Add the device tree bindings for the lm3697
LED driver for backlighting and display.

---

v3 - Updated subject with prefered title - https://lore.kernel.org/patchwork/patch/972337/
v2 - Fixed subject and patch commit message - https://lore.kernel.org/patchwork/patch/971326/

 .../devicetree/bindings/leds/leds-lm3697.txt  | 89 +++++++++++++++++++
 1 file changed, 89 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/leds/leds-lm3697.txt
Documentation/devicetree/bindings/leds/leds-lm3697.txt new file +27 -0
new file mode 100644
index 000000000000..34403a48a0ce
@@ -0,0 +1,89 @@
+* Texas Instruments - LM3697 Highly Efficient White LED Driver
+
+The LM3697 11-bit LED driver provides high-
+performance backlight dimming for 1, 2, or 3 series
+LED strings while delivering up to 90% efficiency.
+
+This device is suitable for Display and Keypad Lighting
+
+Required properties:
+	- compatible:
+		"ti,lm3967"
+	- reg :  I2C slave address
+	- #address-cells : 1
+	- #size-cells : 0
+
+Optional properties:
+	- enable-gpios : gpio pin to enable/disable the device.
+	- vled-supply : LED supply
+
+Required child properties:
+	- reg : 0 - LED is Controlled by bank A
+		1 - LED is Controlled by bank B
+	- led-sources - Indicates which HVLED string is associated to which
+			control bank.  The HVLED string cannot be associated with
+			two control banks.  This property is an array of 3 and
+			all positions in the array must be populated.
+			Additional information is contained
Quoted 8 lines

Documentation/devicetree/bindings/leds/leds-lm3697.txt line 30

Quoted 3 lines
Documentation/devicetree/bindings/leds/leds-lm3697.txt new file +3 -0
+			in Documentation/devicetree/bindings/leds/common.txt
+			0 - End of array if all 3 LEDs are not declared for a
+			    single control bank.

This is needless complication. I propose to define led-sources as an array of three boolean values, whose state signifies which LED strings are controlled by the bank defined by the reg property in the given child node. I.e. <HVLED1 HVLED2 HVLED3>.

I struggled a bit with this definition. Once I got it working it ended up producing an overly complex control bank algorithm.

Quoted 9 lines
Quoted 5 lines

I will take a look at implementing the suggestion but the complication comes in the numerous DT configurations we could encounter. Part of the issue is that the user can connect to CTRL bank b only or CTRL bank a only or a combination of that

2^3

I tried to play a bit with that and here is what I got (simplified DT parsing):

Thanks for the attempt. I think with my current code patch I might be able to get this to work. As per your suggestion. It just takes a while to test all the combos
Dan

Quoted 106 lines

int used_hvleds[3] = {0, 0 ,0};
int used_control_banks[2] = {0, 0};

int parse_child_node(struct fwnode_handle *child)

{
	int bank_hvleds[3];

	fwnode_property_read_u32_array(child, "led-sources",
		bank_hvleds, LM3697_MAX_LED_STRINGS);

	for (i = 0; i <= 3; i++) {
		if (bank_hvleds[i] && used_hvleds[i])
			return -EINVAL;
		used_hvleds[i] = 1;
	}

	return 0;
}

struct fwnode_handle *child = NULL;

device_for_each_child_node(priv->dev, child)

	fwnode_property_read_u32(child, "reg", &control_bank);
	if (used_control_banks[control_bank])
		goto err;
	used_control_banks[control_bank] = 1;
	if (parse_child_node(child))
		goto err;
Quoted 75 lines
Quoted 73 lines

I modified your examples below accordingly.

Quoted 16 lines
Documentation/devicetree/bindings/leds/leds-lm3697.txt new file +16 -0
+			1 - HVLED 1 string
+			2 - HVLED 2 string
+			3 - HVLED 3 string
+
+Optional child properties:
+	- label : see Documentation/devicetree/bindings/leds/common.txt
+	- linux,default-trigger :
+	   see Documentation/devicetree/bindings/leds/common.txt
+
+Example:
+
+HVLED string 1 and 2 controlled by control bank A and HVLED string controlled by
+control bank B.
+
+led-controller@36 {
+	compatible = "ti,lm3967";

Documentation/devicetree/bindings/leds/leds-lm3697.txt

Quoted 10 lines
Documentation/devicetree/bindings/leds/leds-lm3697.txt new file +10 -0
+	reg = <0x36>;
+	#address-cells = <1>;
+	#size-cells = <0>;
+
+	enable-gpios = <&gpio1 28 GPIO_ACTIVE_HIGH>;
+	vled-supply = <&vbatt>;
+
+	led@0 {
+		reg = <0>;
+		led-sources = <0x1 0x2 0x0>
		led-sources = <1 1 0>;

;

Documentation/devicetree/bindings/leds/leds-lm3697.txt line 63

Quoted 7 lines
Documentation/devicetree/bindings/leds/leds-lm3697.txt new file +7 -0
+		label = "white:first_backlight_cluster";
+		linux,default-trigger = "backlight";
+	};
+
+	led@1 {
+		reg = <1>;
+		led-sources = <0x3 0x0 0x0>;
		led-sources = <0 0 1>;
Quoted 9 lines
Documentation/devicetree/bindings/leds/leds-lm3697.txt new file +9 -0
+		label = "white:second_backlight_cluster";
+		linux,default-trigger = "backlight";
+	};
+}
+
+All HVLED strings controlled by control bank A
+
+led-controller@36 {
+	compatible = "ti,lm3967";

Documentation/devicetree/bindings/leds/leds-lm3697.txt line 82

Quoted 10 lines
Documentation/devicetree/bindings/leds/leds-lm3697.txt new file +10 -0
+	reg = <0x36>;
+	#address-cells = <1>;
+	#size-cells = <0>;
+
+	enable-gpios = <&gpio1 28 GPIO_ACTIVE_HIGH>;
+	vled-supply = <&vbatt>;
+
+	led@0 {
+		reg = <0>;
+		led-sources = <0x1 0x2 0x3>;
		led-sources = <1 1 1>;
Quoted 8 lines
Documentation/devicetree/bindings/leds/leds-lm3697.txt new file +7 -0
+		label = "white:backlight_cluster";
+		linux,default-trigger = "backlight";
+	};
+}
+
+For more product information please see the link below:
+http://www.ti.com/lit/ds/symlink/lm3697.pdf
Signature · 2 lines
------------------
Dan Murphy