Skip to contentSkip to conversation

iio: health: max30102: Mark expected switch fall-throughs

PATCH In review Gustavo A. R. Silva 2 participants 2 messages Aug 15, 2018 – Aug 19, 2018 IIO

lore
Share & tools
lore

Gustavo A. R. Silva

author
#0 lore raw

PATCH 1/1 iio: health: max30102: Mark expected switch fall-throughs

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.

Notice that in this particular case, I placed the "fall through" annotation at the bottom of the case, which is what GCC is expecting to find.

Addresses-Coverity-ID: 1458342 ("Missing break in switch")
Addresses-Coverity-ID: 1458345 ("Missing break in switch")

Signed-off-by Gustavo A. R. Silva <[email protected]>
---
 drivers/iio/health/max30102.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
drivers/iio/health/max30102.c +4 -2
index 15ccadc..3e29562 100644
@@ -282,9 +282,11 @@ static int max30102_read_measurement(struct max30102_data *data,
 	switch (measurements) {
 	case 3:
 		MAX30102_COPY_DATA(2);
-	case 2: /* fall-through */
+		/* fall through */
+	case 2:
 		MAX30102_COPY_DATA(1);
-	case 1: /* fall-through */
+		/* fall through */
+	case 1:
 		MAX30102_COPY_DATA(0);
 		break;
 	default:
Signature · 1 line
2.7.4
maintainer
#1 lore raw
Quoted 10 lines · On Wed, 15 Aug 2018 11:23:49 -0500 "Gustavo A. R. Silva"…

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.

Notice that in this particular case, I placed the "fall through" annotation at the bottom of the case, which is what GCC is expecting to find.

Addresses-Coverity-ID: 1458342 ("Missing break in switch")
Addresses-Coverity-ID: 1458345 ("Missing break in switch")

Signed-off-by Gustavo A. R. Silva <[email protected]>

Applied to the togreg branch of iio.git and pushed out as testing for the autobuilders to play with it.

Thanks,

Jonathan

Quoted 22 lines
---
 drivers/iio/health/max30102.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
drivers/iio/health/max30102.c +4 -2
index 15ccadc..3e29562 100644
@@ -282,9 +282,11 @@ static int max30102_read_measurement(struct max30102_data *data,
 	switch (measurements) {
 	case 3:
 		MAX30102_COPY_DATA(2);
-	case 2: /* fall-through */
+		/* fall through */
+	case 2:
 		MAX30102_COPY_DATA(1);
-	case 1: /* fall-through */
+		/* fall through */
+	case 1:
 		MAX30102_COPY_DATA(0);
 		break;
 	default: